centos6 ,
server, proxy,mysql ,web - installed on separate servers

are these normal triggers or lld generated triggers ? are they templated or directly attached to a template or host ?

It's happened for both normal and lld as well.all triggers we have they are templated and host assign to template.
Thanks!

Could you tell in which case you perform  "Query   update triggers set comments=where triggerid=..."
?
I can't find it in php side,so looks like it performed by zabbix-server.

Thanks for help.

This might be a SQL statement performed by Zabbix server in src/libs/zbxdbhigh/lld_trigger.c, lld_triggers_save() function:

if (0 != (trigger->flags & ZBX_FLAG_LLD_TRIGGER_UPDATE_COMMENTS))
{
	comments_esc = DBdyn_escape_string(trigger->comments);
	zbx_snprintf_alloc(&sql, &sql_alloc, &sql_offset, "%scomments='%s'", d,
			comments_esc);
	zbx_free(comments_esc);
	d = ",";
}

It is supposed to only be executed when a discovered trigger description has changed and needs to be updated.

Thanks!

But I have this problem for normal trigger as well not only for lld ....and not all triggers.
Lld is a trapper, but it send the same value
How can I debug the issue ?
I installed zabbix server by rpm.
Could you check the issue ?
I am able to reproduce it.

Thanks.

Here is how we currently understand the problem. LLD triggers cannot be edited in configuration, so it is not possible to change their description there. However, it is currently possible to add a description for an LLD trigger in "Monitoring" -> "Triggers" by clicking "Add" in the "Description" column. There, LLD triggers are not distinguished from normal triggers. When next time LLD runs, it removes the added description, because there is no description in the trigger prototype.

We are running zabbix on large scale and counting on zabbix dashboard.

This bug prevent our NOC (operators) working effectively.

Since it's really urgent (show stopper) for us, can you provide ETA when it can be fix?

It will be much appreciate if you guys could provide temporary workaround so we could work with the Dashboard.

Thanks

If you are in a hurry, you can apply the following patch:

$ svn di
Index: src/libs/zbxdbhigh/lld_trigger.c
===================================================================
--- src/libs/zbxdbhigh/lld_trigger.c    (revision 53288)
+++ src/libs/zbxdbhigh/lld_trigger.c    (working copy)
@@ -1266,7 +1266,7 @@
                                d = ",";
                        }
 
-                       if (0 != (trigger->flags & ZBX_FLAG_LLD_TRIGGER_UPDATE_COMMENTS))
+                       if (0 != (trigger->flags & ZBX_FLAG_LLD_TRIGGER_UPDATE_COMMENTS) && '\0' != *trigger->comments)
                        {
                                comments_esc = DBdyn_escape_string(trigger->comments);
                                zbx_snprintf_alloc(&sql, &sql_alloc, &sql_offset, "%scomments='%s'", d,

This will prevent LLD from clearing trigger description.

Many Thanks ! will implement.

Hi,

after change lld_trigger.c and replace zabbix_server.exe, I see the following error in /var/log/zabbix/zabbix_server.log :

[Z3005] query failed: [1064] You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'where triggerid=1089259' at line 1 [update triggers set where triggerid=1089259

is it relate to the fix ? I didn't see this error before.

Thanks

Yes, the problem is related to the patch I offered above. Sorry for not testing it properly. The following patch should be better:

$ svn di
Index: src/libs/zbxdbhigh/lld_trigger.c
===================================================================
--- src/libs/zbxdbhigh/lld_trigger.c    (revision 53288)
+++ src/libs/zbxdbhigh/lld_trigger.c    (working copy)
@@ -664,7 +664,7 @@
                buffer = zbx_strdup(buffer, comments_proto);
                substitute_discovery_macros(&buffer, jp_row, ZBX_MACRO_ANY, NULL, 0);
                zbx_lrtrim(buffer, ZBX_WHITESPACE);
-               if (0 != strcmp(trigger->comments, buffer))
+               if (0 != strcmp(trigger->comments, buffer) && '\0' != *buffer)
                {
                        trigger->comments_orig = trigger->comments;
                        trigger->comments = buffer;

Please revert the old patch and apply the new one instead.

Now I see the following :

10672:20150706:052612.455 [Z3005] query failed: [1452] Cannot add or update a child row: a foreign key constraint fails (`zabbix`.`functions`, CONSTRAINT `c_functions_1` FOREIGN KEY (`itemid`) REFERENCES `items` (`itemid`) ON DELETE CASCADE) [insert into functions (functionid,itemid,triggerid,function,parameter) values (2328445,1368708,1302612,'strlen',''),(2328446,1368708,1302612,'last','');
]

is it relate ?

Thanks

I currently do not see how this error could be related.

Hi,

just want to update that your fix solved the problem - Many Thanks !!!

will it included in v3.0 ?

Thanks
Natalia

My patch above was just a simple hack that is specific to your use case. For the general use case, we currently do not have a solution.

For instance, we thought about forbidding to add a trigger description for LLD triggers through "Monitoring" -> "Triggers". This looks logical, because then the behavior would be the same as in "Configuration", and the current behavior of allowing to modify trigger description in "Monitoring" can be considered a bug. Unfortunately, that would break your use case entirely.

we need/must possibility to add trigger description for LLD triggers through "Monitoring" -> "Triggers".
We have a lot of LLD and NOC (operators) adding description a lot via "Monitoring" -> "Triggers".

Please update once you will get any decision.

Thanks!

We discussed this and decided not to allow comment updating for discovered triggers.

RESOLVED for 2.2 in svn://svn.zabbix.com/branches/dev/ZBX-9656-22

(1) No translation string changes.

oleg.egorov CLOSED

(2) [A] Zabbix 2.2 PHP min version is 5.3
But you use short array syntax - [], which is available only from 5.4.

	$result = API::Trigger()->update([
		'triggerid' => getRequest('triggerid'),
		'comments' => $comments
	]);

No other frontend issue, after fixing you can merge to 2.2

iivs RESOLVED in r63103

oleg.egorov CLOSED

TESTED

Fixed in:

• pre-2.2.16rc1 r63116
• pre-3.0.6rc1 r63117
• pre-3.2.2rc1 r63118
• pre-3.3.0 (trunk) r63119

(3) Documentation

• Upgrade notes for 2.2.16
• Upgrade notes for 3.0.6
• Upgrade notes for 3.2.2
• Monitoring -> Triggers 2.2
• Monitoring -> Triggers 3.0
• Monitoring -> Triggers 3.2

RESOLVED

iivs Looks good to me.

CLOSED