[ZBX-9864] compilation warning about SIZE_T_MAX being redefined Created: 2015 Sep 10  Updated: 2017 May 30  Resolved: 2015 Oct 12

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Agent (G), Proxy (P), Server (S)
Affects Version/s: 2.2.11rc1
Fix Version/s: 2.2.11rc1, 2.4.7rc1, 3.0.0alpha3

Type: Incident report Priority: Minor
Reporter: Aleksandrs Saveljevs Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: compilation
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

There is the following compilation warning when compiling Zabbix agent on NetBSD 5.0:

In file included from listener.c:20:
../../include/common.h:796:1: warning: "SIZE_T_MAX" redefined
In file included from /usr/include/sys/param.h:154,
                 from /usr/include/arpa/nameser.h:58,
                 from ../../include/sysinc.h:137,
                 from ../../include/common.h:23,
                 from listener.c:20:
/usr/include/machine/limits.h:73:1: warning: this is the location of the previous definition

It was introduced in ZBX-9682. While working on it, it might be nice to also fix definitions like the following:

#define is_ushort(str, value) \
	is_uint_n_range(str, (size_t)SIZE_T_MAX, value, sizeof(unsigned short), 0x0, 0xFFFF)

Here, (size_t) cast is unnecessary, provided SIZE_T_MAX is of type size_t.



 Comments   
Comment by Alexander Vladishev [ 2015 Sep 12 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-9864

Comment by Aleksandrs Saveljevs [ 2015 Sep 16 ]

Looks good, but the following ChangeLog diff is proposed:

-...G...PS. [ZBX-9864] fixed compilation warnings under NetBSD (Sasha)
+...G...PS. [ZBX-9864] fixed compilation warnings regarding SIZE_T_MAX under NetBSD (Sasha)

Otherwise, we may have different warnings on NetBSD and it is not clear which one was fixed.

sasha Many thanks! CLOSED

Comment by Alexander Vladishev [ 2015 Oct 12 ]

Fixed in:

  • pre-2.2.11 r56065
  • pre-2.4.7 r56066
  • pre-3.0.0alpha3 r56067
Generated at Fri Apr 19 23:25:17 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.