[ZBX-9888] prohibit to save not obvious and incorrect conditions expression for action Created: 2015 Sep 18 Updated: 2017 May 30 Resolved: 2015 Nov 04 |
|
| Status: | Closed |
| Project: | ZABBIX BUGS AND ISSUES |
| Component/s: | API (A), Frontend (F) |
| Affects Version/s: | 2.2.10, 2.4.6, 2.5.0 |
| Fix Version/s: | 3.0.0alpha4 |
| Type: | Incident report | Priority: | Minor |
| Reporter: | Oleksii Zagorskyi | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 3 |
| Labels: | actions, expressions, triggers, usability | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
This is continuation of a We've discussed it a bit now and agreed that would be much more user friendly to not allow store incorrect expression as discussed in Sasha confirmed that the expression considered to be incorrect (as for server) only for "AND with several Triggers". We could add such sanity check on frontend side and do not allow to store incorrect expression. |
| Comments |
| Comment by Gunars Pujats (Inactive) [ 2015 Oct 06 ] |
|
(1) [A] Added translation string:
sasha CLOSED |
| Comment by Gunars Pujats (Inactive) [ 2015 Oct 06 ] |
|
RESOLVED in development branch svn://svn.zabbix.com/branches/dev/ZBX-9888 |
| Comment by Alexander Vladishev [ 2015 Oct 23 ] |
|
(2) Only several conditions "Trigger" with "=" operator must be prohibited. gunarspujats RESOLVED in r56361. sasha Impossible to create condition with two or more triggers with "<>" operator. REOPENED gunarspujats RESOLVED in r56378. sasha Unit tests must be fixed. REOPENED gunarspujats RESOLVED in r56403. sasha CLOSED |
| Comment by Alexander Vladishev [ 2015 Oct 23 ] |
|
(3) $triggers_count must be calculated only with evaltype=CONDITION_EVAL_TYPE_AND. gunarspujats RESOLVED in r56361. sashas CLOSED |
| Comment by Alexander Vladishev [ 2015 Oct 27 ] |
|
(4) Take a look at my changes in r56398. gunarspujats CLOSED |
| Comment by Alexander Vladishev [ 2015 Oct 28 ] |
|
Successfully tested! Take a look at my changes in r56407 before a merge. gunarspujats CLOSED |
| Comment by Gunars Pujats (Inactive) [ 2015 Oct 28 ] |
|
Fixed in:
|
| Comment by Alexander Vladishev [ 2015 Oct 29 ] |
|
(5) Documentation: martins-v Updated documentation: Action conditions gunarspujats Updated documentation: API / changes from 2.4 to 3.0 sasha Thanks! CLOSED |