[ZBX-9970] it service name incorrectly uppercased Created: 2015 Oct 19  Updated: 2017 May 30  Resolved: 2015 Oct 30

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 3.0.0alpha3
Fix Version/s: 3.0.0alpha4

Type: Incident report Priority: Trivial
Reporter: richlv Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: itservices
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File it_serv_case.png    

 Description   

in the it service configuration, click on a service. in the popup, it service name is uppercased.
as it service names are case sensitive, that is incorrect

in this example, we have clicked on it service 'a'. popup says it's 'A', which is not correct - we also have service called 'A', but it is a different one

 Comments   
Comment by Pavel Amosov (Inactive) [ 2015 Oct 19 ]

There are 2 issues:
1. links that call out a context navigation should be visually different from normal links: there's the style with dotted underline;
2. I think in this case we can simply avoid placing the heading: it's clear from the context that it's related to the "Service a" because we have clicked on it

sasha Heading must be removed from this popup menu.

Comment by Gunars Pujats (Inactive) [ 2015 Oct 22 ]

(1) Removed translation string:

  • Service "%1$s"

sasha CLOSED

Comment by Gunars Pujats (Inactive) [ 2015 Oct 22 ]

RESOLVED in development branch svn://svn.zabbix.com/branches/dev/ZBX-9970

Comment by Alexander Vladishev [ 2015 Oct 24 ]

(2) Unused translation string must be removed

frontends/php/jsLoader.php:216

'Service "%1$s"' => _('Service "%1$s"'),

gunarspujats RESOLVED in r56362.

sasha CLOSED

Comment by Alexander Vladishev [ 2015 Oct 26 ]

(3) Take a look at my changes in r56358

gunarspujats CLOSED

Comment by Gunars Pujats (Inactive) [ 2015 Oct 26 ]

Fixed in:

  • pre-3.0.0alpha4 (trunk) r56368
Comment by richlv [ 2015 Oct 29 ]

(4) this resulted in a functional change. although small, it should be documented otherwise nobody can easily know whether some change is intentional or a regression (and could storm issue tracker to report it )

as discussed with martins-v, this should go in the "upgrade notes" page, probably as a separate section about frontend changes

sasha It is a very small change. It really should be documented? I think no!

There is no any functional changes.

<richlv> the description of the change is "IT service name removed configuration popup" or similar. it is a change, the frontend looks different and otherwise there is no way whatsoever to know whether some change was accidental or not

martins-v I've added a sentence to https://www.zabbix.com/documentation/3.0/manual/installation/upgrade_notes_300#frontend_changes. RESOLVED

<richlv> yay, thanks

CLOSED

Generated at Wed Apr 24 16:40:55 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.