[ZBX-9991] Host group may falsely be added when cloning a template Created: 2015 Oct 24  Updated: 2017 May 30  Resolved: 2016 Mar 01

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 2.2.10
Fix Version/s: 2.2.12rc1, 2.4.8rc1, 3.0.0beta2

Type: Incident report Priority: Minor
Reporter: Marc Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: cloning, hostgroup, templates
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

A cloned template gets the last selected host group of Configuration->Templates silently added.

 Comments   
Comment by Marc [ 2015 Nov 11 ]

Same happens after selecting a different host group in the combo-box when editing a template.

Comment by vitalijs.cemeris (Inactive) [ 2015 Dec 08 ]

(1) No translation strings changed.

iivs CLOSED

Comment by vitalijs.cemeris (Inactive) [ 2015 Dec 08 ]

RESOLVED in development branch svn://svn.zabbix.com/branches/dev/ZBX-9991

Comment by Ivo Kurzemnieks [ 2016 Jan 14 ]

(2) Please, review my minor changes in r57627.

vitalijs.cemeris CLOSED

Comment by Ivo Kurzemnieks [ 2016 Jan 14 ]

TESTED,
don't forget to close (2) before merging. Keep in mind that trunk has different code.
In trunk this problem can occur only if all groups are removed. So probably a different fix should be provided.

Comment by vitalijs.cemeris (Inactive) [ 2016 Jan 22 ]

Falsely added host group when cloning template is
Fixed in:

  • pre-2.2.12rc1 r57912
  • pre-2.4.8rc1 r57913
  • pre-3.0.0beta2 r57938
Comment by vitalijs.cemeris (Inactive) [ 2016 Jan 22 ]

(3) different fix for trunk should be provided
RESOLVED in development branch svn://svn.zabbix.com/branches/dev/ZBX-9991
r57927

iivs CLOSED

Comment by Alexander Vladishev [ 2016 Jan 25 ]

(4) it also must be fixed for hosts

vitalijs.cemeris RESOLVED in r57965

iivs

  • Discovered host clone form is broken;
  • comparison against zero should be written as "equals" or "not equals", not "greater than";
  • comments must start with capital letter and end with a dot;
  • comment is misleading. The following code executes on form update once, not on create form.

REOPENED

vitalijs.cemeris RESOLVED in r58293

iivs The issue in general is not fixed.
1) Open a host
2) click full clone
3) remove group and leave groups empy
4) press save
5) the group has returned

REOPENED

vitalijs.cemeris RESOLVED in r58471

iivs Please, see my minor changes in r58516

vitalijs.cemeris CLOSED

Comment by Ivo Kurzemnieks [ 2016 Feb 17 ]

TESTED,

close (4) before merging. Careful when merging to 3.0 and trunk, the code might me different.

Comment by vitalijs.cemeris (Inactive) [ 2016 Feb 18 ]

(5) RESOLVED for 2.4 in development branch svn://svn.zabbix.com/branches/dev/ZBX-9991
r58557

iivs

Undefined variable: groupId [hosts.php:794 → CView->render() → include() in C:\Development\ZBX-9991\frontends\php\include\views\configuration.host.edit.php:110]

REOPENED

vitalijs.cemeris RESOLVED in r58705

iivs Please, see my minor changes in r58722

vitalijs.cemeris CLOSED

Comment by vitalijs.cemeris (Inactive) [ 2016 Feb 19 ]

Falsely added host group when cloning host is
Fixed in:

  • pre-2.2.12rc1 r58523
  • pre-2.4.8.rc1 r58743
Generated at Fri Apr 19 03:51:28 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.