minimum severity would be a duplicate of ZBXNEXT-992 - let's leave this one for filtering by group

Specification: https://www.zabbix.org/wiki/Docs/specs/ZBXNEXT-1036

IMPLEMENTED IN svn://svn.zabbix.com/branches/dev/ZBXNEXT-1036 r50610

(1) String changes

New strings:

• Yesterday
• Current week
• Current month
• Current year
• Last week
• Last month
• Last year

iivs CLOSED.

<richlv> looks like string 'Week' might have been removed - could you please check ? REOPENED

oleg.egorov Confirmed.

Removed strings:

• Week

RESOLVED

iivs CLOSED.

(2)

• even though there is enough horizontal space, group selector does not seem to scale very well when many groups are selected (to mimic the previous behaviour)

• notice how date filter got split up. this would happen also if a smaller amount of groups (let's say 6) would be selected. the same would happen with the host filter, too

oleg.egorov
2.1 After discussion with richlv, CLOSED. Will be not fixed.
2.2 RESOLVED IN r50870

iivs CLOSED.

(3) Date and time set in filter is not remembered when coming back from different page

oleg.egorov Waiting for answer from sasha

oleg.egorov Issue confirmed

RESOLVED IN r50870

iivs CLOSED.

(4) Function daysInMonth() duplicates in class.calendar.js. Let's move it somewhere else.
Also, please, give function descriptions in reports.toptriggers.js.php

oleg.egorov RESOLVED IN r50845, r50847

iivs CLOSED.

(5) I didn't see that documentation mentions changing page title and subtitle. Let's change it back.

oleg.egorov RESOLVED IN r50845

iivs CLOSED.

(6) Redundant code:

1. chkbxRange.clearSelectedOnFilterChange();
   

   There are no checkboxes to clear after filtering and resetting.

2. $filterTable->setCellPadding(0);
   $filterTable->setCellSpacing(0);
   

   has no effect due to .filter class is css

oleg.egorov RESOLVED IN r50845

iivs CLOSED.

(7) tests/selenium/testGeneric.php will no longer work, there is no report5.php

oleg.egorov RESOLVED IN r50845

iivs CLOSED.

(8) Tag creation and helper functions should be moved from controller to view

oleg.egorov RESOLVED IN r50845

iivs CLOSED.

(9) Coding style and refactoring:
1.

require_once dirname(__FILE__).'/js/reports.toptriggers.js.php';

should be on top

• reports.toptriggers.php: 20 requries one more space
• reports.toptriggers.php: 21 missing space before =
• reports.toptriggers.php: 26 space should be after comma and no space before 'zbx_filter'

2. setAttribute('style', ... _ can be replaced with _addStyle(' ...

3. $filterHosts as $host can be renamded to $filterHosts as $filterHost or $hosts as $host, since $hosts will be overwritten later. Same for groups.

4. Make some refactoring for API calls so that 'output' goes as first option

5. Update to trunk and make sure buttons still work, filter buttons have jquery classes and shadows, 'buttonClass' is removed, {[useJQueryStyle('main')}} is removed and CButton links have proper classes.

oleg.egorov RESOLVED IN r50845, r50847, r50850, r50876.
Redesigned period links in r50853
Removed quickTimeInput ID r50872
Fixed daysInMonth function request from calendar r50879

iivs CLOSED.

TESTED.

Implemented in trunk r50886

(10) Documented in:

• https://www.zabbix.com/documentation/3.0/manual/introduction/whatsnew300#filtering_options
• https://www.zabbix.com/documentation/3.0/manual/web_interface/frontend_sections/reports/triggers_top

RESOLVED.

oleg.egorov Thanks, CLOSED

(11) Let's redesign it and remove the extra CSS we added to main.css.

oleg.egorov As was been discussed, resolved in r50986

iivs Design looks good to me. Better than previous version. I improved CSS and coding style in r51074. Please, review.

oleg.egorov CLOSED

FIXED IN 2.5.0(trunk) r51084
CLOSED

(12) Screenshots updated at:

• https://www.zabbix.com/documentation/3.0/manual/introduction/whatsnew300#filtering_options
• https://www.zabbix.com/documentation/3.0/manual/web_interface/frontend_sections/reports/triggers_top

RESOLVED.

oleg.egorov Thanks. CLOSED