[ZBXNEXT-1061] Ability to switch items in simple graphs, but keep the temporal settings Created: 2011 Dec 23  Updated: 2018 Nov 28

Status: Open
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: 1.8.9, 1.9.8 (beta)
Fix Version/s: None

Type: New Feature Request Priority: Minor
Reporter: Volker Fröhlich Assignee: Unassigned
Resolution: Unresolved Votes: 17
Labels: graphs, patch, patchongithub, period, unsquashable, usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File 0001-Switch-between-graphs-simple-graphs-and-screens-with.patch     Text File ZBXNEXT-1061-2.0.9-2-temporal.patch     PNG File ZBXNEXT-1061-2.0.9-temporal-set.png     PNG File ZBXNEXT-1061-2.0.9-temporal-unset.png     File ZBXNEXT-1061-Switch-between-graphs-simple-graphs-and-screens-with_2.2.1.patch     File ZBXNEXT-1061-Switch-between-graphs-simple-graphs-and-screens-with_2.4.2.patch     PNG File pinset.png     PNG File pinunset.png     PNG File simple-graph-keep-period.png    
Issue Links:
Duplicate
is duplicated by ZBXNEXT-1655 Remember last selected time period in... Closed
is duplicated by ZBXNEXT-1909 Maintain the selected timeframe betwe... Closed
is duplicated by ZBXNEXT-2799 Option to preserve zoom/filter select... Closed
is duplicated by ZBXNEXT-3063 Custom timespans Closed
is duplicated by ZBX-9173 Remember last timeframe when switchin... Closed
is duplicated by ZBX-10771 chooser time is reset when we change ... Closed

 Description   

Scenario: Something goes wrong on a host

I figure out A has alerting values. It comes to my mind, to check the development of B, because it is related to A.

Being in Latest data, I went on to see one of the simple graphs. Switching to a different simple graph, I must return to Latest data and follow the link to the desired simple graph. That alone is not very efficient, but worse: The temporal settings are lost, so I have to set that again over and over.

This ticket is related to ZBXNEXT-862.

I know you can switch by replacing the itemid Get parameter, but that's not very handy and the temporal settings are lost either way, it seems.

I'd be hoping for a simple way to switch through hosts and items, keeping my temporal settings. Even more fancy: A method to quickly throw all these graphs on top of another to compare them easily.

keywords : period



 Comments   
Comment by Marc [ 2013 Oct 16 ]

Attached patch ZBXNEXT-1061-2.0.9-temporal.patch is not tested very well!
If filter is 'pinned' the last set period is used for any other custom graph and history graph.:

  • Custom graphs
  • History charts
  • Host screens
  • Screens

Edit, some more details:
The patch introduces new profile indexes web.common.pinned.set, web.common.pinned.period, web.common.pinned.stime and web.common.pinned.isnow.
These (except .set) are always updated beside the individual indexes to the current values when changing the period of a filter for custom graphs and history graphs.

If a filter get's pinned by the new 'Pin period' button, then web.common.pinned.set is set and any mentioned graph considers values from web.common.pinned.* instead.

Comment by Volker Fröhlich [ 2013 Oct 19 ]

I've tried it and I like the implementation. It solves my issue; it's intuitive to use and of great practical value. It could also be extended to screens though.

Thinking further, based on the same principle one could also have a limited number of temporal pre-sets and choose between them. Even an arbitrary number of time-settings could be stored and named and chosen from.

Comment by Volker Fröhlich [ 2013 Nov 04 ]

The -2-patch also includes screens.

Everything still works as expected, but the behaviour is interesting when you've got multiple windows open.

Comment by Volker Fröhlich [ 2013 Nov 14 ]

Forward-ported patch for 2.2.0

Comment by Corey Shaw [ 2013 Dec 09 ]

Attached the patch for Zabbix 2.2.1 (the 2.2.0 wouldn't apply correctly)

Comment by Corey Shaw [ 2013 Dec 17 ]

Fixed a couple of minor bugs in the 2.2.1 patch (was missing a couple of commas)

Comment by richlv [ 2013 Dec 20 ]

ZBXNEXT-862 is slightly related

Comment by Pavels Jelisejevs (Inactive) [ 2014 Apr 10 ]

I definitely like the second implementation better. In the described scenario it would be much more useful if the graphs would be displayed on a single image or on a single page, stacked. We've actually had some internal discussions about this feature, but haven't come to any conclusion yet.

Comment by Corey Shaw [ 2014 Nov 20 ]

I just did some major fixes to the original Zabbix 2.4.2 port of this patch. The new patch has been attached and it actually works correctly now.

Comment by dimir [ 2016 Jan 20 ]

Trunk changed significantly, 2.4.2 wouldn't apply.

Comment by richlv [ 2016 Apr 16 ]

for the record, applies to 2.4.7 with a single minor offset

Comment by richlv [ 2016 May 02 ]

another thing to note - does seem to be erratic with auto-refresh enabled. with auto-refresh disabled, seems to work as expected.

Comment by Alexey Naidyonov [ 2018 Nov 24 ]

The patch above should be merged upstream as-soon-as-hecking-possible.

While investigating an incident, you have to click through tons of charts trying to figure out correlated events. This job requires lots of patience and clicking that date selector (every. hecking. time. TWICE.) doesn't help at all.

No, seriously. This use case is so obvious I fail to understand how it could have been missed.

Comment by dimir [ 2018 Nov 24 ]

You are absolutely right, will try to get some attention to this one.

Comment by dimir [ 2018 Nov 26 ]

Since we have dashboards now, do you think https://support.zabbix.com/browse/ZBXNEXT-4780 would suffice?

Comment by Backoffice Team [ 2018 Nov 26 ]

I don't think dashboard can resolve this since when debugging we are usually looking at many different hosts. So, switching views from hosts and having them synced at the same time frame would be very helpful.

The problem with debuging and dashboards is that some/most times we don't know what we are looking for, so it's impossible to create the dashboard in advance. Creating them on the go is not pratical either.

One approach i use is see the latest data and combine the items, but thats not easy for the average user as well.

Comment by dimir [ 2018 Nov 27 ]

I see now. Makes sense. OK, will continue trying to get attention to this one.

Comment by dimir [ 2018 Nov 27 ]

I spoke to one of the PHP devs. In 4.0 the functionality to pass the period (HTTP GET variables from and to) for simple graphs in URL is already there. And they are updated in URL when you move timeline bar. So, is it enough to implement the following things:

  • ability to copy URL with selected period
  • ability to keep selected period

as seen in this screenshot?
 

The button could say "Copy link".

For the future it could be considered to save multiple pre-defined user periods to profile.

This task shouldn't take long time, current vision, around a week. But the closest version this could fit in is unfortunately 4.4 .

Comment by Filipe Paternot [ 2018 Nov 27 ]

I don't get it.

The ability to copy URL would be:

  • for sharing that graph?
  • or some kind of hack to get that from/to time selectors to another graph?
  • – if the last question is true, should't we have a "use copied link to current graph"?

 

Maybe keeping the selected period could be the default behaviour and the user should be able to switch it on/off on his profile page. I like the idea of "keep selected period" too.

 

I think that maybe saving multiple pre-defined user periods would be too much. I don't see that use case right now.

Comment by dimir [ 2018 Nov 27 ]

Sorry, by "the ability to copy URL" I meant for sharing that with someone. When clicking that it would ensure the link contains "from" and "to" GET variables, which would ensure the recipient would get the view with desired period.

Comment by richlv [ 2018 Nov 28 ]

That seems to be unrelated to this issue & the patch in it - a button to pin the selected period so that clicking around the UI would keep the period in all the graphs whenever clicking around.

Comment by dimir [ 2018 Nov 28 ]

No problem, that was just a suggestion.

Generated at Fri Mar 29 08:16:26 EET 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.