Implemented in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-109
(1) configuration.edit.js.php:421 line - 123 sumbols
To resolved it, you can move
(typeof dCheck['ports'] == 'undefined' || ZBX_CHECKLIST[dcheckid]['ports'] === dCheck['ports'])
to condition begin
Like
if ((typeof dCheck['ports'] == 'undefined' || ZBX_CHECKLIST[dcheckid]['ports'] === dCheck['ports']) && (typeof dCheck['type'] == 'undefined' || ZBX_CHECKLIST[dcheckid]['type'] === dCheck['type']) && (typeof dCheck['key_'] == 'undefined' || ZBX_CHECKLIST[dcheckid]['key_'] === dCheck['key_'])
Eduards RESOLVED r.34040
oleg.egorov CLOSED
(2) FTP:23 after save is FTP(23) - it's OK, but if click "edit", then form is:
Check type: FTP
Port range: 21
"Port range" is default port
This problem exist not only for FTP
Eduards RESOLVED r.34039
oleg.egorov CLOSED
(3)
Check type: SNMPv1 agent
Port range: 219
SNMP community: 1
SNMP OID: 2
After save is SNMPv1 agent (219) "2" and after reopen is SNMPv1 agent (219) "2"
But if edit it
Check type: SNMPv1 agent
Port range: 219
SNMP community: 1
SNMP OID: 0
After save is SNMPv1 agent (219) "0", but after discovery reopen is SNMPv1 agent (219)
Without * "0"*
Same problem with other places if user "0", for example:
Check type: Zabbix agent
Port range: 219
Key: 0
Eduards RESOLVED r.34057
oleg.egorov CLOSED
oleg.egorov REOPENED
(4) After "check" update, "device uniqueness criteria" is with old data.
Example:
Was:
Check type: Zabbix agent
Port range: 219
Key: 0
Device uniqueness criteria:
Zabbix agent (219)
After update:
Check type: Zabbix agent
Port range: 300
Key: 1
Device uniqueness criteria:
Zabbix agent (219)
Device uniqueness criteria still Zabbix agent (219)
Eduards RESOLVED r.34057
oleg.egorov CLOSED
(5) I have
Device uniqueness criteria:
IP address
Zabbix agent (219)
After edit Zabbix agent (219)
From Zabbix agent (219) to FTP (22)
I still have
Device uniqueness criteria:
IP address
Zabbix agent (219)
Added:
If in radio was selected Zabbix agent (219)
After save I have device uniqueness criteria without selected item, and if it save, we have error:
Warning. Field "Device uniqueness criteria" is mandatory.
And I think it save not existing value...
Eduards RESOLVED r.34057
oleg.egorov CLOSED
(6)
Checks: SNMPv3 agent (21)
Security level: authPriv
After save/update don't save:
Authentication protocol and Authentication protocol
Eduards RESOLVED r.34057
oleg.egorov CLOSED
(7) Checks: Zabbix agent
Port range: 161
key: key
Then select SNMPv1 and we have:
Port range: 161
SNMP OID: key
If changed "type", then unset other values...
Eduards RESOLVED r.34077
oleg.egorov REOPENED, not resolved
Eduards RESOLVED r.34083
oleg.egorov CLOSED
(8) Create discovery rule
I add new check, for example ftp:21
Then "save"
Warning. Incorrect value for field "name": cannot be empty.
Again "save"
... And we now don't have check, it lost...
Eduards RESOLVED r.34077
oleg.egorov CLOSED
(9) Checks
1) Create new "ICMP ping"
2) Then "New"
3) Then "Edit" for "ICMP ping"
4) Then Update
Result:
ICMP ping
ICMP ping
Check duplicates...
Eduards RESOLVED r.34077
oleg.egorov CLOSED
And please, if it possible, fix "Enable" bug under this ZBXNEXT
Eduards RESOLVED r.34083
oleg.egorov CLOSED
(10) Possible set "000000000001" value for port field
Eduards RESOLVED r.34083
oleg.egorov Possible save "0 1" values, after save we have " 1"...
And
dCheck.ports = dCheck.ports.replace(/^[0]+/g, '');
I think not a perfect solution replace "0"
Eduards RESOLVED r.34086 
oleg.egorov CLOSED, open ZBX-6344
(11) Create checks FTP and Zabbix agent
Device uniqueness criteria select Zabbix agent, remove FTP.
And now device uniqueness criteria is IP address
Eduards RESOLVED r.34090, r.34093
oleg.egorov CLOSED
TESTED
Fixed in versions pre-2.1.0 (beta) r34096
(12) documentation. for somebody to work on it, all changes should be summarised here
martins-v Documentation changes:
- https://www.zabbix.com/documentation/2.2/manual/introduction/whatsnew220#editable_discovery_checks
- updated screenshots at: https://www.zabbix.com/documentation/2.2/manual/discovery/network_discovery/rule
martins-v CLOSED.
(14) Default value is "Disabled", but should be "Enabled"
Eduards RESOLVED r.34118
oleg.egorov CLOSED
(15)
1) Create new discovery
2) add check Zabbix agent
3) add check FTP
4) select in "Device uniqueness criteria" Zabbix agent
5) Save -> Warning. Incorrect value for field "name": cannot be empty.
...and Device uniqueness criteria is IP address
Same problem in discovery edit
Eduards RESOLVED r.34128
oleg.egorov CLOSED
REOPENED (3)
(16) "Edit" in checks now don't work.
1) Create new discovery
2) Add new check
3) And try edit it
Eduards RESOLVED r.34130
oleg.egorov CLOSED
(17) Remove don't work...
ReferenceError: new0 is not defined error source line: [Break On This Error] javascript: removeDCheckRow(new0);
Eduards RESOLVED r.34130
oleg.egorov CLOSED
(18) Unused check fields must be cleared in DB
Eduards RESOLVED r.34143
oleg.egorov CLOSED
TESTED
Fixed in versions pre-2.1.0 (beta) r34155
(18) The "dcheck" record should not be deleted for edited discovery checks.
Eduards Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-109
sasha TESTED. Please review my changes in r35437
Eduards CLOSED
Fixed in versions pre-2.1.0 (beta) r.35439
(12) is not closed -> REOPENED
martins-v I closed it now.