Removed all of the DM-related code from the frontend. Please test and review.

that should be in svn://svn.zabbix.com/branches/dev/ZBXNEXT-1343 , i guess

I've added a note to the specification about entries in the database, that should be deleted:

http://www.zabbix.org/wiki/Docs/specs/ZBXNEXT-1343#Database_changes

(1) [S] ZBX_SYNC, ZBX_HISTORY and ZBX_HISTORY_SYNC should be removed from C code and schema.tmpl

<dimir> RESOLVED in r29777, r29781. Please check also frontend change in r29782.

<Sasha> CLOSED

(2) [S] Please review my changes in r29661, r29678, 29689 and 29690

<dimir> CLOSED

Removed TABLE_TYPE_CONFIG and TABLE_TYPE_HISTORY table constants from frontend in r29796. Also updated schema.inc.php, it was missing few changes from schema.tmpl .

(3) not directly related, but whenever we click on the "main" menu (like "monitoring", "configuration" etc), 'submenu' opens the first entry (like "dashboard", "host groups")... except in administration. here it previously always defaulted to "dm", now it defaults to "proxies".
probably should default to "general", to match all other sections

pointed out by andris

Eduards RESOLVED r.44077

jelisejev CLOSED.

(4) a small question - are we going to remove DM related tables from schema ?
If not, then why ?

<dimir> http://www.zabbix.org/wiki/Docs/specs/ZBXNEXT-1343#Database_changes

<zalex> dang, How I missed that ? :>
Thanks, CLOSED.

(5) ZBX-5549

<richlv> this was about PERM_READ_LIST, which was removed in that issue

CLOSED

why remove it? and what is the alternative? please dont say proxys!

any news on this? I don't see any change in 2.2 roadmap

We decided not to remove in 2.2.

If it's still aimed to be removed, then update the documentation accordantly, please!

There has to be a very clear indication that this feature is going to be removed.
This is especially important to new users who might consider to use "old style DM" in their architecture.

what would be the alternatve?
We have different locations there are connected by VPN, if a VPN goes down we get also alerts if we use nodes, when we use proxys there are no alerts when the VPN is down, and we think all works good on this.
install a new zabbix instance on the different locations is no option, because we keep track of our locations

PS: sorry for my bad english, but ih hope you understand me..

Solutions?! Proxy must send alerts, but its limited to get only data from 1day

(6) let's check whether this fixes ZBX-7890 as well

sasha CLOSED it should be fixed separately.

Proxy is the biggest part of the solution. It has many advantages. We use DM because nothing else was
available back in 1.4.x but would have changed to a proxy solution any time.
We monitor proxies by the following item
zabbix[proxy,Proxyname,lastaccess]
and trigger in case the proxy is slow, i. e. using more than 4 minutes to connect to the server:
zabbix[proxy,Proxyname,lastaccess].last(0)}>240
if an interval of 3 minutes is configured.
If the proxy is down we use trigger

=0&

=0
Works fine for us.

(7) Please review my changes in r43720

sasha Thanks! CLOSED

Frontend ready in r.43901

hello, since you're closing the ticket and planned the removal of old style DM in 2.4 roadmap (https://www.zabbix.org/wiki/Docs/roadmap#Planned), do you have any other information for your users (except the draft that only lists what you're going to remove) of how the "next generation" DM will be? it will be quite useful to know ahead what to do with DM in general. Thank you.

Unfortunately there are no decisions currently on what will the future DM look like and when will it appear. It's only known that it neither will be available in 2.4 nor in 2.6 .

ok, just to get this correctly, since you planned and, from what I see, removed the old style DM support, this means that upgrading to the future 2.4 will fully remove master-slave setup and capability, if in place on the upgraded installation, while leaving the information of other nodes on the database (but not viewable on the frontend)?

I'm not arguing nor complaining, I just want to be sure on what will happen, if I can rely or not on DM support for the near future.

thanks again

FYI - there is ZBXNEXT-2099 (no option to clean up database from orphaned node from DM)

(8) Strings removed:

• Cannot add node
• Cannot delete nodes
• Cannot update node
• Child
• CONFIGURATION OF NODES
• Configuration of nodes
• Create node
• Delete selected node?
• DM
• Incorrect characters used for Node name.
• Incorrect node type.
• Incorrect user data in "get_accessible_groups_by_user".
• Incorrect user data in "get_accessible_nodes_by_user".
• Local
• Master
• Master node
• Master node already exists.
• Master node "ID" must be empty.
• Node
• Node added
• Node deleted
• Node updated
• Node with same ID already exists.
• Nodes
• Please be aware that database still contains data related to the deleted node.
• Your setup is not configured for distributed monitoring.
• Unable to remove local node.

jelisejev Some more strings that have been removed:

• Connected as \'%1$s\' from \'%2$s\'
• All nodes
• Current node
• Select Nodes

sasha CLOSED

Upgrade path isn't done. Reopening.

This issue should be considered in upcoming Webinars as well for the same reason previously mentioned.

(9) [F] In CTrigger::getObjects() the "expression" key is unset from an unexisting variable $options.

Eduards RESOLVED r.44077

jelisejev CLOSED.

(10)

1. The limit for the maximum ID generated by the DB class for standalone setups must remain.
2. The ZBX_DM_MAX_HISTORY_IDS and ZBX_DM_MAX_CONFIG_IDS constants must be removed.
3. The ZBX_STANDALONE_MAX_IDS should be renamed to ZBX_MAX_IDS.

Eduards RESOLVED r.44100

jelisejev
1. The limit problem has not been resolved.

Eduards RESOLVED r.44190

2. Please have someone from the C side review your changes to the C code.

sasha C side successfully reviewed and tested. CLOSED

jelisejev Currently in trunk, when we reach the maximum ID, we try to refresh them to check if any IDs have been freed. Please restore this feature.

Eduards RESOLVED r.44363

jelisejev Still not resolved.

Eduards RESOLVED r.44393

jelisejev CLOSED.

(11) [F] The name of the server defined in $ZBX_SERVER_NAME is no longer displayed.

Eduards RESOLVED r.44077

jelisejev The class "serverName" does not match our CSS naming conventions:

Class names, IDs and data attributes should be written with a dash, e.g. .item-form or data-item-id.

Eduards RESOLVED r.44190

jelisejev CLOSED.

(12) [F] I've made a small change in r44045, please review.

Eduards CLOSED

jelisejev I've also restored the comment in CHostBase.php in r44058. It talks about nodes of a graph, not DM nodes.

Eduards CLOSED

(13) I removed unused alias from SQL statement in r44046. Please review.

Eduards CLOSED

(14) Seems that some of the node related code remains in idens.inc.php:

	if (!isset($ident['node'])) {
		return reset($searchedImages);
	}
	elseif (isset($searchedImages[$ident['node']])) {
		return $searchedImages[$ident['node']];
	}
	else {
		return 0;
	}

Eduards RESOLVED r.44100

jelisejev CLOSED.

(15) The name of the "DM" menu link must be changed to "Proxies". Also please fix the old (3) issue.

Eduards RESOLVED r.44077

jelisejev CLOSED.

(16) There are a bunch of places where we use the CMultiSelect class and passed the name of the node in the "prefix" parameter. In some places, like configuration.screen.constructor.edit.php:289 the node has been removed, but now an empty "prefix" parameter remains. It should be removed as well.

Eduards RESOLVED r.44077

jelisejev CLOSED.

Upgrade patches are ready for testing.

(17) I've updated to the latest /trunk in r44286 and there have been several conflicts on the PHP side, please review.

Eduards CLOSED

(18) [S] graphs_theme table is not synchronized between nodes, so we don't need to process graph_theme.description fields.

sasha RESOLVED in r44341

wiper CLOSED

Frontend TESTED.

Server TESTED

Old style node-based distributed monitoring was removed in pre-2.3.0 (trunk) r44485.

(20) The upgrade patch stopped with the following error

20331:20140416:094918.315 Duplicate data "123123" for field "name" is found in table "services". Remove it manually and restart the process.

But we allow to have IT services with the same names.

sasha Fixed in pre-2.3.0 (trunk) r44490.

CLOSED

(21) I've removed all node-related parameters from the API docs from all of the get, exists and getobjects methods and the reference commentary.

<richlv> looks like https://www.zabbix.com/documentation/2.4/manual/api/reference/hostinterface/exists still has it, or have i misunderstood something ?

<richlv> removed it. also removed node related info from :
https://www.zabbix.com/documentation/2.4/manual/api/reference/action/object
https://www.zabbix.com/documentation/2.4/manual/api/reference/user/login

jelisejev Thanks. CLOSED.

(22) node related parameters have not been removed from zabbix_server.conf

• conf/zabbix_server.conf
• tests/templates/zabbix_server.conf

<richlv> in r44604 removed NodeID, NodeNoEvents, NodeNoHistory parameters and node reference from StartTrappers. the config file in tests is a bit outdated, but let's handle it separately

sasha Thank you! CLOSED

(23) "node watcher" busy rate item has not been removed from the default zabbix server template

sasha RESOLVED in the development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-1343 r44606.

jelisejev CLOSED.

(24) frontends/php/include/menu.inc.php has
'hide_node_selection' => 1,

i suspect that this might not be needed anymore

sasha RESOLVED in the development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-1343 r44607.

jelisejev Seems that the "node_perm" and "force_disable_all_nodes" parameters are unused as well. I've removed them in r44689. Please review.

sasha CLOSED

(25) frontends/php/include/defines.inc.php has :
define('PERM_RES_IDS_ARRAY', 1); // return array of nodes id - array(1,2,3,4)

this does not seem to be used anywhere

sasha RESOLVED in the development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-1343 r44635.

jelisejev CLOSED.

(26) Updated documentation:

• https://www.zabbix.com/documentation/2.4/manual/introduction/whatsnew240#node-based_distributed_monitoring_removed
• https://www.zabbix.com/documentation/2.4/manual/installation/upgrade_notes_240

• https://www.zabbix.com/documentation/2.4/manual/distributed_monitoring
• https://www.zabbix.com/documentation/2.4/manual/web_interface/frontend_sections/administration/proxies
• https://www.zabbix.com/documentation/2.4/manual/config/notifications/action/conditions ('node' condition removed)
• https://www.zabbix.com/documentation/2.4/manual/config/items/itemtypes/internal
• https://www.zabbix.com/documentation/2.4/manual/appendix/config/zabbix_server ('node' related parameters removed)
• https://www.zabbix.com/documentation/2.4/manual/appendix/macros/supported_by_location ('node' macros removed)
• https://www.zabbix.com/documentation/2.4/manual/appendix/faq

<sasha> thanks! CLOSED

TESTED,

but please review (21) before merging.

sasha (20), (21) and (22) are available in pre-2.3.0 (trunk) r44806.

(27) i removed node references from the server manpage directly in trunk in r45000 and regenerated https://www.zabbix.com/documentation/2.4/manpages/zabbix_server

please review

sasha CLOSED

(28) removed node reference from code comment in r45001, please review (function names and other things in there still reference nodes, but i guess we can ignore that for now )

sasha Function and module names will renamed later. CLOSED

(29) looks like template changes are missing from these documentation pages :

• https://www.zabbix.com/documentation/2.4/manual/installation/template_changes
• https://www.zabbix.com/documentation/2.4/manual/installation/upgrade_notes_240

sasha RESOLVED

<richlv> changed for -> from and in the upgrade notes added info on how to fix the affected template after the upgrade. please review these changes -> again RESOLVED

martins-v I added some formatting for better readability plus some minor grammar changes. As far as I'm concerned, this can be CLOSED.

(30) once subissue 29 is closed, changed templates should be uploaded to the official template page

sasha Updated Zabbix Templates/Official Templates

RESOLVED

<richlv> minor change to the heading level, otherwise looks great -> CLOSED

subissues still open : 8, 19, 26, 27, 28, 29, 30