Ubuntu 12.04

------

I agree, it must be supported by Zabbix out of the box.

ZBXNEXT-1679 asks for valuemap xml import/export

XML import/export would be nice as well, but that also requires user interaction via the GUI (unless there's an API method like xml.import, which would be amazing). Admittedly, this would go a long way, but would not resolve all cases where API access is needed.

API access to the value mappings is not just about configuration. In fact, XML import is likely to be a better way to accomplish configuration. However, If I query Event history for an Item that uses a value mapping, there's no good way using the API to query that mapping for proper interpretation. The extra bit of labelling that gives context to the raw data is hidden.

I would say that the request for API access to the value mappings is much more about reading what's there and proper interpretation of the Event data than anything else. Of course, once there's a "valuemap.*" set of methods, adding .create, .update, and .delete methods is probably not too much of a stretch. But the .get method is probably the most crucial.

In my humble opinion...

I'd say that depends on massively on why your using the API in the first place. If implementing a configuration management of Zabbix using something like Puppet via the API, then the ability to create and update Value Mappings is essential, XML import just won't cut it in that circumstance.

offtopic, but xml import/export via the api is possible already : https://www.zabbix.com/documentation/2.0/manual/appendix/api/configuration

The configuration.import and configuration.export methods do not allow for import/export of valuemaps. If it did, this would be a crude, but effective substitute for a set of valuemap.X methods.

oh, sure - just noted that having xml import/export would indirectly expose partial functionality over the api, too

I think is also useful to have an API to query a Value Mapping for a specific Item.
Thanks

This request is open for 2 1/2 years - is there any plan to implement this soon?
Sorry, but what use is an API if I cannot even modify all aspects of standard items?

unfortunately, it is not on the roadmap yet. it likely will wait for ZBXNEXT-2519

ZBXNEXT-2787 has a patch for 2.2

ZBXNEXT-2789 has a patch for 2.4

Frontend Class of API ValueMapping. Use README to install.

(1)
Translation strings added:

• At least one mapping should be given for value map "%1$s".
• Duplicate "name" value "%1$s" for value map.
• Duplicate mapping value "%1$s" for value map "%2$s".
• Empty new value in value map "%1$s".
• Empty value map ID.
• Incorrect value map ID.
• Mapping is missing parameters: %1$s for value map "%2$s".
• No "%1$s" given for value map.
• Only super admins can create value maps.
• Only super admins can delete value maps.
• Only super admins can update value maps.
• Value map is missing parameters: %1$s
• Value map name cannot be empty.

Translation strings removed:

• Mapping value "%1$s" is not unique.
• Value cannot be mapped to empty string.
• Value map "%1$s" "%2$s".
• Value map "%1$s".
• Value map with valuemapid "%1$s" does not exist.
• Value mapping must have at least one mapping.

sasha Updated list of strings. Please check.

iivs CLOSED

RESOLVED in svn://svn.zabbix.com/branches/dev/ZBXNEXT-1424

(2) it must be written easier

if (self::$userData['type'] == USER_TYPE_SUPER_ADMIN) {
}
elseif ($options['editable'] === null && self::$userData['type'] == USER_TYPE_ZABBIX_ADMIN) {
}
elseif ($options['editable'] !== null || self::$userData['type'] != USER_TYPE_SUPER_ADMIN) {
    return [];
}

Maybe so:

if ($options['editable'] !== null && self::$userData['type'] != USER_TYPE_SUPER_ADMIN) {
    return [];
}

iivs Indeed so. RESOLVED in r56239

sasha CLOSED

(3) Take a look at my minor changes in r56131, r56132, r56141, r56142.

iivs CLOSED

(4) check for the duplicated names in validateCreate() is not effective

sasha RESOLVED in r56143

iivs Thanks!
CLOSED

(5) SQL request must be removed from valuemap.create().

sasha RESOLVED in r56145

iivs Thanks!
CLOSED

(6) check for the duplicated names in validateUpdate() is not effective

sasha RESOLVED in r56156

iivs Thanks!
CLOSED

(7) selectMappings option must support "count"

iivs RESOLVED in r56236

sasha Custom SQL request should be created in this case:

SELECT valuemapid,COUNT(*) AS cnt FROM mappings GROUP BY valuemapid

REOPENED

iivs RESOLVED in r56264

sasha Good! But take a look at my changes in r56269.

iivs Thanks!
CLOSED

(8) Too many SQL requests with selectMappings option.

SELECT t.mappingid,t.valuemapid FROM mappings t WHERE t.valuemapid IN ('24','25','26','27')
SELECT m.* FROM mappings m WHERE m.mappingid BETWEEN '180' AND '187'

Only one request will be enough to get mappings.

SELECT m.* FROM mappings m WHERE m.valuemapid IN ('24','25','26','27')

iivs RESOLVED in r56235

sasha Using of array_key_exists() in the filter options is useless. 'valuemapids' is always present in $options array.

'filter' => array_key_exists('valuemapids', $options)
    ? ...
    : ...

REOPENED

iivs RESOLVED in r56264

sasha CLOSED

(9) valuemap.get() returns an empty array instead of number of the valuemaps for non super-admins

• Request

  {
      "countOutput" : true,
      "editable" : true
  }
  

• Response

  Logged as superadmin:
  {
      "jsonrpc": "2.0",
      "result": "27",
      "id": 7
  }
  
  Logged as admin or regular user:
  {
      "jsonrpc": "2.0",
      "result": [],
      "id": 9
  }
  

iivs For me this happened only for regular users. RESOLVED in r56239

sasha Still reproducible. REOPENED

iivs RESOLVED in r56268

sasha CLOSED

(10) Possible "Undefined index" in valuemap.update()

• Request:

  {
      {
          "valuemapid" => 24,
          "name" => "test"
      },
      {
          "valuemapid" => 25
      }
  }
  

Undefined index: name [CFrontendApiWrapper->update() → CApiWrapper->__call() → CFrontendApiWrapper->callMethod() → CApiWrapper->callMethod() → CFrontendApiWrapper->callClientMethod() → CLocalApiClient->callMethod() → call_user_func_array() → CValueMap->update() in include/classes/api/services/CValueMap.php:196]

sasha RESOLVED in r56184

iivs Possibly fixed and then broken again. Found it again and fixed.
RESOLVED in r56226

sasha Thanks! Take a look at my changes in r56256.

iivs CLOSED

(11) valuemap.update() can be work faster

sasha RESOLVED in r56184

iivs Thanks!
CLOSED

(12) valuemap.delete() can be work faster

sasha RESOLVED in r56186

iivs Thanks!
CLOSED

(13) caching in function getMappedValue() is not effective

getMappedValue('100', 17);

SELECT  vm.valuemapid FROM valuemaps vm WHERE vm.valuemapid='17'
SELECT  t.mappingid,t.valuemapid FROM mappings t WHERE t.valuemapid='17'
SELECT m.mappingid,m.value,m.newvalue FROM mappings m WHERE m.mappingid BETWEEN '89' AND '165'          <= here we can cache all mappings

getMappedValue('101', 17);

SELECT  vm.valuemapid FROM valuemaps vm WHERE vm.valuemapid='17'
SELECT  t.mappingid,t.valuemapid FROM mappings t WHERE t.valuemapid='17'
SELECT m.mappingid,m.value,m.newvalue FROM mappings m WHERE m.mappingid BETWEEN '89' AND '165'

sasha RESOLVED in r56190.

iivs Thanks!
CLOSED

(14) Confirmation messages must be located in the view

frontends/php/adm.valuemapping.php:124:133

if ($valuemap_count['cnt'] == 0) {
    $data['confirmMessage'] = _('Delete selected value mapping?');
}
else {
    $data['confirmMessage'] = _n(
        'Delete selected value mapping? It is used for %d item!',
        'Delete selected value mapping? It is used for %d items!',
        $valuemap_count['cnt']
    );
}

iivs RESOLVED in r56240

sasha CLOSED

(15) nonexistent fields are used in the API calls

frontends/php/adm.valuemapping.php:107,136 'selectMappings' => ['mappingid', 'value', 'newvalue']

sasha RESOLVED in r56253

iivs Thanks!
CLOSED

(16) Direct SQL requests must be replaced by API calls.

frontends/php/adm.valuemapping.php:120

sasha RESOLVED in r56255

iivs Thanks!
CLOSED

(17) Templates must be written by using our html classes

sasha RESOLVED in r56260.

iivs Minor coding style fix in r56266, please review.

sasha CLOSED

(18) Added [Clone] button for value mappings. It will be more consistent with other forms.

sasha RESOLVED in r56261.

iivs Thanks! jQuery code simplified in r56267, please review.

sasha Thanks! CLOSED

(19) Unused form name "valuemap_form"; unused class "row_mappings"

sasha RESOLVED in r56262.

iivs

Undefined variable: tab [adm.valuemapping.php:152 → CView->render() → include() in include\views\administration.general.valuemapping.edit.php:109]

RESOLVED in r56265

sasha Many thanks! CLOSED

(20) "sortfield" argument must support "name". Specification is updated accordingly.

iivs RESOLVED in r56263

sasha CLOSED

Implemented in pre-3.0.0alpha4 (trunk) r56276

(21) API documentation updated:

• https://www.zabbix.com/documentation/3.0/manual/api/changes_2.4_-_3.0
• https://www.zabbix.com/documentation/3.0/manual/api/reference/valuemap
• https://www.zabbix.com/documentation/3.0/manual/api/reference/valuemap/object
• https://www.zabbix.com/documentation/3.0/manual/api/reference/valuemap/create
• https://www.zabbix.com/documentation/3.0/manual/api/reference/valuemap/get
• https://www.zabbix.com/documentation/3.0/manual/api/reference/valuemap/update

sasha Very good! But, "mappings" property is not described on > Value map object

REOPENED

iivs RESOLVED

sasha Many thanks! CLOSED

(22) User documentation:

• What's new in Zabbix 3.0.0 #API improvements
• Value mapping: screenshot with [Clone] button

sasha

• What's new in Zabbix 3.0.0 #API improvements RESOLVED

martins-v Reviewed. looks good.

martins-v

• Value mapping: screenshot with [Clone] button RESOLVED

sasha Looks good. CLOSED