[ZBXNEXT-1493] get rid of action dropdowns Created: 2012 Oct 31  Updated: 2015 Jan 23  Resolved: 2015 Jan 23

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 2.5.0

Type: Change Request Priority: Blocker
Reporter: richlv Assignee: Unassigned
Resolution: Fixed Votes: 8
Labels: usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

couldn't find an existing issue... maybe i'm creating duplicates myself here

at some point (1.8) zabbix changed from individual buttons for actions (below entity lists) to a dropdown & "go" button.

this is much worse for usability, as opening a dropdown and then choosing the action is :

a) more clicks;
b) slower, as one has to click the dropdown first, then scan the available entries and find the correct one
c) looks like crap when there's only single action

suggestion is to change back to buttons, maybe providing icons on buttons for even faster access

spec at https://www.zabbix.org/wiki/Docs/specs/ZBXNEXT-1493

rationale at https://www.zabbix.org/wiki/Death_to_the_dropdowns



 Comments   
Comment by Pavels Jelisejevs (Inactive) [ 2014 Oct 14 ]

This should be done after we're finished with ZBX-8896.

Comment by Krists Krigers (Inactive) [ 2014 Nov 26 ]

RESOLVED in r50869, branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-1493 (copy of trunk).

Comment by richlv [ 2014 Nov 26 ]

(1) counter does not accommodate 4 digits - selecting larger amount of entities shifts the buttons

kristsk
Problem exists because both proportional font is used and string "selected" is translatable and it's length may be different.
As far as I can see, following options exist:
1) Leave it as it is now. Buttons may shift during selection.
2) Reserve a "safe" chunk (100px) for "9999 selected" message and center the message in it. May look odd.
3) Put number in separate span with fixed width and align it to the right. This results in gap on left side if number is small.

Need input on how to proceed.

<richlv> i'd probably go with 3, although maybe aim for '999' not to shift - having more selected entities is not common. if this is accepted, spec should be changed as well

sasha CLOSED

Comment by Krists Krigers (Inactive) [ 2014 Nov 26 ]

(2) Translation string changes:
New strings:

  • "Clear history"
  • "Disable hosts"
  • "Enable hosts"
  • "Export"
  • "Unblock"
  • "selected"

Removed strings:

  • "Clear history for selected"
  • "Copy selected to ..."
  • "Delete selected with linked elements"
  • "Disable selected"
  • "Enable selected"
  • "Export selected"
  • "Go"
  • "Unblock selected"

sasha CLOSED

Comment by richlv [ 2014 Dec 31 ]

update priority as discussed with iivs & oleg

Comment by Oleg Egorov (Inactive) [ 2015 Jan 15 ]

(3) Improved fix in r51629

sasha CLOSED

Comment by Alexander Vladishev [ 2015 Jan 17 ]

(4) No confirmations on FireFox. Please re-test confirmations on all supported browsers.

oleg.egorov RESOLVED IN r51708

sasha CLOSED

Comment by Alexander Vladishev [ 2015 Jan 19 ]

(5) CActionButtonList::__construct arguments should be more strict:

  1. $buttonsData['name'] - this argument should be mandatory
  2. $buttonsData['confirm'] - this argument should accept only strings

oleg.egorov RESOLVED IN r51708

sasha REOPENED $buttonData['name'] still optional

oleg.egorov RESOLVED IN r51709

sasha CLOSED

Comment by Alexander Vladishev [ 2015 Jan 19 ]

(6) administration.general.regularexpressions.list.php - CActionButtonList should be an element of form as in other views

oleg.egorov RESOLVED IN r51730

sasha CLOSED

Comment by Alexander Vladishev [ 2015 Jan 19 ]

(7) frontends/php/js/chkbxrange.js:263 useless code

jQuery('#action').prop('disabled', count == 0);

oleg.egorov RESOLVED IN r51708

sasha CLOSED

Comment by Oleg Egorov (Inactive) [ 2015 Jan 19 ]

See also code refactoring in r51711

sasha CLOSED

Comment by Alexander Vladishev [ 2015 Jan 19 ]

Take a look at my minor changes in r51710, 51712

oleg.egorov Thanks. CLOSED

Comment by Alexander Vladishev [ 2015 Jan 20 ]

(8) Please review my changes in r51735.

oleg.egorov REVIEWED. CLOSED

Comment by Oleg Egorov (Inactive) [ 2015 Jan 20 ]

Implemented in 2.5.0(trunk) r51737

Comment by Oleg Egorov (Inactive) [ 2015 Jan 20 ]

(9) Added min-width for #selectedCount, removed unnecessary code in chkbxrange.js.
Please review r51745

sasha CLOSED

Comment by Oleg Egorov (Inactive) [ 2015 Jan 21 ]

Fixed in 2.5.0(trunk) r51748

Comment by Martins Valkovskis [ 2015 Jan 22 ]

(10) Updated documentation:

This change affects a lot of screenshots (and their descriptions), but they will be updated at a later time when all screenshots for 3.0 are updated. RESOLVED.

<richlv> content changes seem to be necessary, too - some examples :

martins-v Descriptions updated. RESOLVED.

<richlv> i changed the description for "delete" to plural in 3.0, 2.4, 2.2 and 2.0 hostgroup pages to be consistent with other pages. if that is ok, this subissue can be closed

martins-v Looks good to me.

oleg.egorov CLOSED

Generated at Thu Mar 28 20:04:45 EET 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.