[ZBXNEXT-1506] vfs.dev.read and vfs.dev.write implementation for AIX Created: 2012 Nov 09 Updated: 2014 Oct 18 Resolved: 2014 Apr 17 |
|
| Status: | Closed |
| Project: | ZABBIX FEATURE REQUESTS |
| Component/s: | Agent (G) |
| Affects Version/s: | 2.0.3 |
| Fix Version/s: | 2.3.0 |
| Type: | New Feature Request | Priority: | Major |
| Reporter: | Jairo Eduardo Lopez Fuentes Nacarino | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | agent, aix, diskio, patch | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
AIX 6.1 |
||
| Attachments: |
zabbix-2.0.3-aix-agent-diskio-07.patch
zabbix-2.x-TRUNK-r44251-aix-agent-diskio-08.patch
zabbix-2.x-TRUNK-r44251-aix-agent-diskio-09.patch
|
||||
| Issue Links: |
|
||||
| Description |
|
I am Jairo Lopez and am currently working with Miracle Linux in Japan. We have been working on getting the vfs.dev.read and vfs.dev.write agent keys working for AIX 6.1. We have implemented the number of bytes read and written to all the disks on an AIX machine and on particular hdiskX devices. The implementation relies on libperfstat to obtain the data. Attached is our working patch the Zabbix 2.0.3 agent on AIX 6.1 We thank you for your time and would like to receive comments. |
| Comments |
| Comment by Boris Manojlovic [ 2014 Apr 10 ] |
|
patch applies to trunk relase r44251 |
| Comment by Boris Manojlovic [ 2014 Apr 10 ] |
|
patch is applying but very wrong because of changes to function prototype |
| Comment by Boris Manojlovic [ 2014 Apr 12 ] |
|
vfs.disk. {read|write}[hdisk0,bytes] working,vfs.disk.{read|write} [,operations] working, [hdisk0,operations] working |
| Comment by Aleksandrs Saveljevs [ 2014 Apr 17 ] |
|
Available in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-1506 . |
| Comment by Aleksandrs Saveljevs [ 2014 Apr 17 ] |
|
Note that "vfs.dev.(read|write)[,bps]" and "vfs.dev.(read|write)[,ops]" are not available. However, a similar goal (without making the distinction between reads and writes) can be accomplished using "system.stat[disk,bps]" and "system.stat[disk,tps]" (see https://www.zabbix.com/documentation/2.2/manual/config/items/itemtypes/zabbix_agent). dimir Also sectors type is not available on AIX. |
| Comment by dimir [ 2014 Apr 30 ] |
|
(1) [G] We have discussed the cases when items become unsupported with sasha. As we will soon have the new feature to address error with every unsupported case it would be great to set an error message for the new unsupported cases in the code. E. g. src/libs/zbxsysinfo/aix/diskio.c:59 return SYSINFO_RET_FAIL; /* error: can be retrieved from errno */ src/libs/zbxsysinfo/aix/diskio.c:78 return SYSINFO_RET_FAIL; /* error: zabbix agent was compiled without libperfstat support */ asaveljevs It might be better to do it in dimir OK, let's just not forget it. CLOSED |
| Comment by dimir [ 2014 Apr 30 ] |
|
Successfully tested! Please review my changes in r45037. I suggest to use type for second parameter to be consistent with documentation. asaveljevs Good idea. I have replaced ZBX_DEV_PFX_LEN with "sizeof(ZBX_DEV_PFX) - 1" in r45047 for consistency with FreeBSD and Linux. |
| Comment by Aleksandrs Saveljevs [ 2014 Apr 30 ] |
|
Available in pre-2.3.0 (trunk) r45052. |
| Comment by Aleksandrs Saveljevs [ 2014 May 06 ] |
|
(2) Updated documentation at:
I have also updated the following, because vfs.dev.read[] and vfs.dev.write[] on OpenBSD used to say that "avgX" parameter is ignored. It is the case with 2.0, but not with 2.2 and trunk:
The following link was already updated by martins-v: dimir looks good, CLOSED |
