Proof of concept patch for 2.0.3

Yeah, wanted to report the same some time ago
Will be very useful !

Now, I add some short unique text (let's say action's name) in every action message body to be able later distinct which exactly action sent particular alert.
This is not very nice, but it helpful.

I often suggest to do the same for zabbix users when they cannot figure out what's going on with alerts.

Voted !

ZBXNEXT-1636 is similar (showing action in event details for alerts)

just a note - we expect to get new macros

,

for notifications. See ZBXNEXT-384

Forward-ported patch for 2.2.0

FIXED IN svn://svn.zabbix.com/branches/dev/ZBXNEXT-1533 r42663

(1) while we change this area, let's rename "Actions" in the dropdown to "Alerts"

oleg.egorov RESOLVED IN r42695

jelisejev After some discussion, we've decided to rename "Logs" to "Audit log" and "Actions" to "Action log".

jelisejev The page titles are still incorrect.

oleg.egorov RESOLVED IN r42814

jelisejev I've made a minor correction in r42828.

jelisejev CLOSED.

(2) Actions should only be retrieved for alerts displayed on the selected page.

oleg.egorov FIXED IN r42698

jelisejev The $actionids variables is not required, since if we have alerts, we'll always have action IDs.

oleg.egorov RESOLVED IN r42814

jelisejev CLOSED.

(3) It's better to name the column just "Action".

oleg.egorov FIXED IN r42699

jelisejev CLOSED.

(4) Let's make some more improvements in this branch:

1. Replace the text in the error column with an icon, the same way as other lists;
2. Move the "Status" column before the "Error" column;
3. Merge the "Retries left" column with the "Status" column: when the status is "in progress", retries should be displayed below the status reading "# retries left" or "1 retry left";
4. Correct the name of the statuses to be displayed with a capital letter: "Sent", "Executed", "Not sent".

oleg.egorov RESOLVED IN r42761

jelisejev
1. The "retries left" label must be displayed below the "In progress" status.
2. The title of the error column will be removed in a different ZBX, so please restore it in this one.

oleg.egorov RESOLVED IN r42814

jelisejev I've removed the usages of NAME_DELIMITER in r42829, please review.

jelisejev CLOSED.

TESTED.

Please close (1) and (4) before merging.

FIXED IN 2.3.0(trunk) r42831

CLOSED

(5) Documentation needs to be updated. To summarize, in this ZBX Olegs has:

• added the "Action" column;
• changed the titles of the pages: "Logs" to "Audit log" and "Actions" to "Action log";
• replaced the error text with an icon;
• merged the "Retries left" and the "Status" columns;

Might be worth documenting together with ZBXNEXT-421.

martins-v Updated sections:

• https://www.zabbix.com/documentation/2.4/manual/introduction/whatsnew240#responsible_action_shown_in_action_log (an overview of all changes)
• https://www.zabbix.com/documentation/2.4/manual/web_interface/frontend_sections/administration/audit (changes reflected in the naming, screenshots and column descriptions)
• https://www.zabbix.com/documentation/2.4/manual/config/visualisation/screens#adding_elements (element name changed to 'action log')

RESOLVED.

jelisejev Looks good, CLOSED.

I've changed the messages displayed when a list is empty to "No audit log entries found." and "No action log entries found." in r43040.

(6) The same changes need to be made to the "History of actions" screen elements.

oleg.egorov RESOLVED IN r43215

jelisejev

1. The "Status" column must be moved before the "Info" column;
2. If a user has no media defined, zeroes are displayed in the "Type" column.

oleg.egorov RESOLVED IN r43251

jelisejev I've made some changes in r43286, please review.

oleg.egorov Thanks, CLOSED

(7) Some additional changes to the "History of actions" element:

• Rename "History of actions" to "Action log";
• Correct the sorting label to "Sort entries by";
• Remove the option to sort by retries;
• Change the empty list message to "No action log entries found".

oleg.egorov RESOLVED IN r43215

jelisejev CLOSED.

(8) [S] A database patch is required to changed screen item sort order from retries to status.

jelisejev RESOLVED in svn://svn.zabbix.com/branches/dev/ZBXNEXT-1533.

oleg.egorov CLOSED

jelisejev It needs to be reviewed by one of the C devs. REOPENED.

sasha CLOSED Successfully reviewed end tested. Please review my changes in r43287 before a merge.

String changes:

Removed:
CScreenActions.php:
Retries left

configuration.screen.constructor.edit.php
Retries left (descending)
Retries left (ascending)

Changed:
CScreenActions.php:
No actions found. -> No action log entries found.
sent -> Sent
not sent -> Not sent

configuration.screen.constructor.edit.php
Sort triggers by -> Sort entries by

screens.inc.php
History of actions -> Action log

Added:
CScreenActions.php:
Action

FIXED IN 2.3.0(trunk) r43290

subissues still open : 1, 4, 5

Existing "0001-ZBXNEXT-1533Show-responsible-actions-name-in-audit.patch" may be applied up to 2.2.8

Attached "ZBXNEXT-1533-backported-2.2.10.patch" compatible with 2.2.9+