Available in the development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-1574.

(3) [F] Triggers with value_flags=1 are not shown neither in "Monitoring" -> "Events" nor in "Monitoring" -> "Triggers".

Here is how the trigger looks when status is OK and it's visible in "Monitoring":

 triggerid | expression | description | url | status | value | priority | lastchange | comments |                                               error                                               | templateid | type | value_flags | flags
-----------+------------+-------------+-----+--------+-------+----------+------------+----------+---------------------------------------------------------------------------------------------------+------------+------+-------------+-------
     13546 | {12980}>10 | random>10   |     |      0 |     0 |        2 | 1358929802 |          | Received value [test] is not suitable for value type [Numeric (unsigned)] and data type [Decimal] |            |    0 |           0 |     0

Now it becomes "unknown" and disappears from "Monitoring" (only change is "value_flags"):

 triggerid | expression | description | url | status | value | priority | lastchange | comments |                                              error                                               | templateid | type | value_flags | flags 
-----------+------------+-------------+-----+--------+-------+----------+------------+----------+--------------------------------------------------------------------------------------------------+------------+------+-------------+-------
     13546 | {12980}>10 | random>10   |     |      0 |     0 |        2 | 1358929802 |          | Received value [foo] is not suitable for value type [Numeric (unsigned)] and data type [Decimal] |            |    0 |           1 |     0

Database changes successfully tested.

Perhaps ZBX-6080 should be closed after this issue is implemented.

(4) in events.inc.php
if (bccomp($startEvent['eventid'],$event['eventid']) == 0 && $nextevent = get_next_event($event, $events, true)) {

unnecessary 3rd param in get_next_event()

jelisejev RESOLVED in r33101.

tomtom CLOSED

(5) in CScreenEvents.php
$showUnknown = CProfile::get('web.events.filter.showUnknown', 0);

should be removed

jelisejev RESOLVED in r33101.

tomtom CLOSED

(6) in triggers.inc.php line:1456

statement: if ($state == -1) {

never executes now

jelisejev RESOLVED in r33109.

tomtom CLOSED

(7) in triggers.inc.php in calculate_availability()

if ($total_time == 0) {
	$ret['true_time'] = 0;
	$ret['false_time'] = 0;
	$ret['true'] = 0;
	$ret['false'] = 0;
}

Maybe $ret['true'] should be 100!?

jelisejev As far as I can see, this code should not be executed at all. But I suggest we leave it as is for now and deal with it in ZBX-5785.

tomtom CLOSED

(8) comments should be rewritten:

"// if disable trigger, unknown event must be created" in triggers.php

" * @param int $triggerValue TRIGGER_VALUE_FALSE, TRIGGER_VALUE_TRUE or TRIGGER_VALUE_UNKNOWN" in triggers.inc.php

"// set element to problem state if it has problem events, ignore unknown events" in maps.inc.php. At 2 places!

jelisejev RESOLVED in r33101. The last one should be removed under ZBX-6172.

tomtom CLOSED

(9) "return _('Unknown');" in trigger_value2str() should be rethought. Seems that it is unnecessary.

jelisejev I've left it as is because that's how all similar functions behave.

tomtom CLOSED

(10) "$hintTable->addRow(array(new CCol(SPACE, 'trigger_unknown'), _('Unknown')));" should be removed in monitoring.overwiew.php

probably associated class 'trigger_unknown' as well.

jelisejev Will be fixed under ZBX-6173. CLOSED.

tomtom CLOSED

(11) "$this->ok('Number of triggers (enabled/disabled)[problem/unknown/ok]');" in testPageStatusOfZabbix.php should be updated.

jelisejev RESOLVED in r33103.

tomtom CLOSED

(12) "$this->ok(array('Host', 'Name', 'Problems', 'Ok', 'Unknown', 'Graph'));" in testPageAvailabilityReport.php should be updated. At 2 places!

jelisejev RESOLVED in r33103.

tomtom CLOSED

DB changes and serverside tested. sasha please see my small changes in r33114 and r33122.

tomtom Frontend successfully TESTED.

There have been conflicts when updating to the latest trunk. Please review r33166.

Available in 2.1.0 r33169.

Updated the API docs:

the property list in https://www.zabbix.com/documentation/2.2/manual/api/reference/event/object
examples in https://www.zabbix.com/documentation/2.2/manual/api/reference/event/get
and the 2.2 changelog https://www.zabbix.com/documentation/2.2/manual/api/changes_2.0_-_2.2

(13) should be documented in whatsnew and upgrade notes, just have to figure out what are the important user-facing changes

(14) If events fro trigger has been deleted and trigger in the PROBLEM state (for example, when trigger is in PROBLEM state very long time), we can see the next errors:

Undefined index: eventid [dashboard.php:97 → make_system_status() → makeTriggersPopup() → getEventAckState() in /var/www/zabbix/trunk-clean/include/events.inc.php:298] 
Undefined index: objectid [dashboard.php:97 → make_system_status() → makeTriggersPopup() → getEventAckState() in /var/www/zabbix/trunk-clean/include/events.inc.php:298] 
Undefined index: acknowledges [dashboard.php:97 → make_system_status() → makeTriggersPopup() → getEventAckState() in /var/www/zabbix/trunk-clean/include/events.inc.php:299] 
Undefined index: acknowledges [dashboard.php:97 → make_system_status() → makeTriggersPopup() → getEventAckState() in /var/www/zabbix/trunk-clean/include/events.inc.php:307]

jelisejev RESOLVED in r33386.

tomtom REOPENED blocks.inc.php line: $triggers[$tnum]['clock'] = isset($trigger['event']) ? $trigger['event']['clock'] : $trigger['lastchange'];
$trigger['lastchange'] could be used always.

jelisejev RESOLVED in r33486.

tomtom CLOSED

Fixed in 2.1.0 r33493.

CLOSED.

Fix Version/s: is not set, REOPENED

Set fix version.

CLOSED.