Agreed; this was confirmed (and was expected to work / principle of least surprise):

{#ALERT.MEMORY.HEAP_SIZE.THRESHOLD.PERCENT} = 10

does not work:

{template_name:memory-usage-heap-percent[{#JMX.PORT}].count(#3,{#ALERT.MEMORY.HEAP_SIZE.THRESHOLD.PERCENT},"gt")}=3

but

works:

{template_name:memory-usage-heap-percent[{#JMX.PORT}].count(#3,10,"gt")}=3

Hi All, is there a workaround for a trigger prototype like this?

{xx:system.run[zabbix_check_script.pl -qn=fakeA -qm=fakeB -qma=fakeB -qmp=fakeC -qc=fakeD -mqu=",wait].count(#3,{#DEFAULT_WARN},"gt")}>2

Workaround. This does not work:

Task_discovery:exit_status.[{#TASK}].nodata([{#PERIOD}])}=1

This works (but ugly as hell):

({Task_discovery:exit_status.[{#TASK}].nodata(300)}=1 & {#PERIOD} = 5) | ({Task_discovery:exit_status.[{#TASK}].nodata(600)}=1 & {#PERIOD} = 10) | ({Task_discovery:exit_status.[{#TASK}].nodata(900)}=1 & {#PERIOD} = 15) | ({Task_discovery:exit_status.[{#TASK}].nodata(1800)}=1 & {#PERIOD} = 30) | ({Task_discovery:exit_status.[{#TASK}].nodata(2700)}=1 & {#PERIOD} = 45) | ({Task_discovery:exit_status.[{#TASK}].nodata(3600)}=1 & {#PERIOD} = 60)

Hm, it seems that in calculated items LLD macros are supported in function parameters...

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-1667

(1) Support LLD macros in function parameters of expression, in trigger prototype.
vso RESOLVED in r63775

wiper CLOSED

(2) Extract different patterns from item values for LLD trigger prototype names, descriptions and tags

Use

 {{ITEM.VALUE}.regsub({#LLD_REGEXP}, {#LLD_PATTERN})} 

or similar expressions in trigger name, description and tags

vso RESOLVED in r63823

wiper CLOSED

(3) Substitute LLD macros in trigger function parameters within simple macros

({host:item[…].func(…)}) 

in fields which support them (graph prototype names)
vso RESOLVED in r63835

wiper CLOSED

Server side fixed in development branch: svn://svn.zabbix.com/branches/dev/branches/dev/ZBXNEXT-1667

(4) [F] Added support for LLD macros in trigger prototypes in r63874

sasha added unit tests in r64048

CLOSED

(5) [S] Unrelated to the new development, but it appears that the check:

	if ('{' != *pr++)
		return FAIL;

In src/libs/zbxserver/expression.c:process_simple_macro_token() is unnecessary. This function is called when a simple macro is found at the token token, so '{' will be always at the left token position.

vso RESOLVED in r63941

wiper CLOSED

(6) [S] The zbx_function_param_parse() function expects null terminated parameter list. When parsing an expression containing mulitple functions the caller has to force null termination, call zbx_function_param_parse() function and then restore the original string. To simplify it the zbx_function_param_parse() function must be changed to use parameter length instead of checking for terminating zero.
vso RESOLVED in r63918

wiper If zbx_function_param_parse() does not return error on validation failure and the expression passed to it is always prevalidated, then we can revert the changes and simply add checking for ')' when parsing unquoted parameter. Something like:

		for (ptr = expr; '\0' != *ptr && ')' != *ptr && ',' != *ptr; ptr++)
			;

However we need to add to function comments, that expression must contain valid parameter list.

REOPENED

vso RESOLVED in r64006

wiper CLOSED

(7) [S] zbx_function_param_parse() function that is used as basis for substitute_function_parameters() expects valid function parameter list. This means we should either validate function parameters in lld_parameter_make() or change zbx_function_param_parse() to return parsing error (this might be done with (6) subissue ).

vso RESOLVED in r63938

wiper CLOSED

(8) [S] If validation is added to zbx_function_param_parse(), then it woud make sense to rewrite function_match_parenthesis() function to reuse zbx_function_param_parse() instead of manually parsing the parameter list.

vso RESOLVED in r63938

wiper As the zbx_function_param_parse() was not reused parenthesis matching, this looks like WONTFIX

(9) [S] Coding style - would be good to change function names to reflect that lld macros are being subtituted. Something like substitute_function_lld_macros, substitute_parameter_lld_macros.

vso RESOLVED in r63940

wiper CLOSED

(10) lld_parameter_make() will not allocate empty parameter strings, resulting in crash later when prototype parameter is compared to existing parameter in lld_function_make@1100:

		if (0 != strcmp(function->parameter, proto_parameter))
		{
			function->parameter_orig = function->parameter;
			function->parameter = proto_parameter;
			proto_parameter = NULL;
			function->flags |= ZBX_FLAG_LLD_FUNCTION_UPDATE_PARAMETER;
		}

vso RESOLVED in r64009

wiper CLOSED

Server side tested, please review fixed/added comments in r64041
vso CLOSED

Fixed in:
3.3.0 (trunk) r64054

(11) [D] Documentation shall be changed to reflect that we added support of LLD macros in function parameters of trigger prototype expression, name, description and tags, and in function parameters of graph prototype name.

wiper Documentation updates must be done in:

• https://www.zabbix.com/documentation/3.4/manual/introduction/whatsnew340
• https://www.zabbix.com/documentation/3.4/manual/config/macros/lld_macros

vso RESOLVED

• https://www.zabbix.com/documentation/3.4/manual/introduction/whatsnew340
• https://www.zabbix.com/documentation/3.4/manual/config/macros/lld_macros
• https://www.zabbix.com/documentation/3.2/manual/config/macros/lld_macros

wiper CLOSED

(12) Update Changelog with a better description of changes

vso RESOLVED

sasha CLOSED with small fix in r64148

(13) Update what's new to similar description as change log.
vso RESOLVED
https://www.zabbix.com/documentation/3.4/manual/introduction/whatsnew340

sasha CLOSED

(14) [D] looks like we forgot to delete a note bottom of this page https://www.zabbix.com/documentation/3.4/manual/discovery/low_level_discovery ?

natalja.cernohajeva : Thank you for finding this. The note is now removed. Please, take a look.
RESOLVED
(Also fixed for 4.0 version)
zalex_ua CLOSED