RESOLVED IN svn://svn.zabbix.com/branches/dev/ZBXNEXT-1763 r38345
(1) In the "Configuration" row the "Application" link should be corrected to "Applications" and "Web scenarios" to "Web".
oleg.egorov RESOLVED IN r38578
jelisejev CLOSED.
(2) In the "Latest data" row:
- the links should be displayed and called the same way as in the main menu;
- the "Graphs" link leads to web monitoring instead of graphs;
- the "Screens" link should lead to the host's screen page, not the general screens;
- opening the "Triggers status" link should not unset the "Show hosts in maintenance" filter.
oleg.egorov RESOLVED IN r38651
- The "Triggers status" link should be renamed to "Triggers";
- A minor correction to the last article: the "Show hosts in maintenance" filter must be set when opening the "Triggers" link.
oleg.egorov RESOLVED IN r38657
jelisejev There is no need for additional spans to contain the links in the "Latest data" row.
oleg.egorov RESOLVED IN r38691
jelisejev CLOSED.
(3) Errors if I open a host with disabled inventory:
Invalid argument supplied for foreach() [hostinventories.php:133 → CView->render() → include() in /opt/lampp/htdocs/zabbix/trunk/frontends/php/include/views/inventory.host.view.php:149]
Invalid argument supplied for foreach() [hostinventories.php:133 → CView->render() → include() in /opt/lampp/htdocs/zabbix/trunk/frontends/php/include/views/inventory.host.view.php:240]
oleg.egorov RESOLVED IN r38578
jelisejev CLOSED.
(4) This change was not implemented: "Existing menu item 'Host inventories' will be renamed to 'Host inventory' and accessible for all hosts even with no inventory enabled. It should be made available also from map icons representing host state."
oleg.egorov RESOLVED IN r38617
jelisejev Still not implemented. Also the "Host inventory" link is not translated in the pop up menu. And lets also change the title of the host inventory page to "Host inventory".
oleg.egorov RESOLVED IN r38786
- Remove the "hasInventory" parameter from the helper comment.
- The "hasInventory" parameter also needs to be removed from the getMenuPopupHost() PHP helper. Also check if there are any places where host inventory is requested exclusively for getMenuPopupHost(). Such requests should be removed.
oleg.egorov RESOLVED IN r38790
jelisejev Please finish the work on the second item as we discussed.
oleg.egorov RESOLVED IN r38792
jelisejev This change is not implemented: "The 'Host inventory' menu item should be made available also from map icons representing host state."
oleg.egorov RESOLVED IN r38820
jelisejev Made some changes in r38822, please review.
oleg.egorov CLOSED
(5) The "Change" column in the latest data page is not displayed if the "Show details" filter is enabled.
oleg.egorov RESOLVED IN r38633
jelisejev CLOSED.
(6) The "History" column should have an empty title even if the "Show details" filter is disabled.
oleg.egorov RESOLVED IN r38633
jelisejev CLOSED.
(7) The links in the host inventory page should be correctly aligned with their labels.
oleg.egorov RESOLVED IN r38633
jelisejev They're still misaligned.
oleg.egorov RESOLVED IN r38724
jelisejev CLOSED.
(8) The "Go to's" section should not be displayed in the pop up menu on the host inventory page.
oleg.egorov RESOLVED IN r38578
jelisejev The "Go to" section is no longer displayed anywhere.
oleg.egorov RESOLVED IN r38687
jelisejev CLOSED.
(9) The "Error" column should be moved to the end of the table in the latest data page.
oleg.egorov RESOLVED IN r38617
jelisejev CLOSED.
(10) If the history and trend intervals are overriden in the global housekeeper settings, the global values should be displayed instead of the ones from the item.
oleg.egorov RESOLVED IN r38617
jelisejev Not working for items in the "Other" section.
oleg.egorov RESOLVED IN r38657
jelisejev CLOSED.
(11) Macros should be expanded in the item keys on the latest data page.
oleg.egorov RESOLVED IN r38633
jelisejev Macros are not expanded for items in the "Other" section.
oleg.egorov RESOLVED IN r38657
jelisejev CLOSED.
(12) In the latest data page:
- the lifetime indicator for discovered items should not be displayed;
- the interval value should not be displayed for SNMP trap and Zabbix trapper items;
- the trends period should not be displayed for text items.
oleg.egorov RESOLVED IN r38651
- If a value is not displayed, the table cell should not be empty but contain a dash "-";
- The trends period should also not be displayed for character and log items.
oleg.egorov RESOLVED IN r38657, r38658
jelisejev CLOSED.
(13) The new files must have the "svn:eol-style" property set to "native".
oleg.egorov RESOLVED IN r38578
jelisejev CLOSED.
(14) In latest.php:
- You shouldn't modify the value of $_REQUEST['show_details'];
- The following syntax "reset($db_item['applications'])['applicationid']" is not supported in PHP 5.3.
oleg.egorov RESOLVED IN r38578
- Item 1 also applies to line 132;
- There are extra parentheses on lines 510-515;
- Restore the translation context to the "Change" string.
oleg.egorov RESOLVED IN r38724
jelisejev CLOSED.
(15) We use dashes ("my-element-class") for HTML eleme class and ID naming, not camel case or underscores.
oleg.egorov RESOLVED IN r38617
jelisejev CLOSED.
(16) In inventory.host.view.php:
- Please don't set inline element style values (for instance line 90);
- Don't use "isset($snmpInterfaceRow)" to check if SNMP interfaces exist. The variables need to be defined before, and then you should just check if they are empty or not;
- Don't use multiple spaces to create spacing between links on line 157, use styles instead;
- On line 150 you can't select fields by title since titles are translatable. Use the "db_field" value instead;
- All of the page specific styles should be added using a class for the widget element, just like in other pages, not using #hostinventoriesOverviewFormList. Also the "hostinventoriesDetailsFormList" ID seems to be unused.
oleg.egorov RESOLVED IN r38651
- The "*InterfaceRow" variables are arrays and should be named in plural;
- On line 153 instead of iterating through the whole inventory object, it's better to just request specific inventory fields;
- The "host-inventories-overview" ID should be a class and should be assigned to the CWidget element. It's also better to rename it to "inventory-host" or something like that, so it wouldn't get mixed up with the Inventory->Overview section;
- Missing units in the "overview-link" style.
oleg.egorov RESOLVED IN r38724
jelisejev The "inventory-host-form" and "hostinventoriesDetailsFormList" IDs are not used anywhere.
oleg.egorov RESOLVED IN r38786
jelisejev If no ID is given for the CFormList element it shouldn't render an empty ID attribute.
oleg.egorov RESOLVED IN r38790
jelisejev CLOSED.
(17) In hostinventories.php:
- Line 147 don'r rely on the $config variable being defined in page_header.php. Define it explicitly in this file;
- There's no need to pass the host under the "overview" key;
- This code seems to be unused: "$data['overview']['host']['status'] = null;";
- Don't use $data['rwHost'] to store intermediate values, use a separate variable instead;
- On line 120 instead of checking for a specific host ID you can just check if at least one host was returned.
- There's no need for a separate SQL query to retrieve host inventory data, it can be done via the API;
oleg.egorov RESOLVED IN r38633
jelisejev CLOSED.
(18) In inventory.host.list.php:
- the filter handling logic should remain in hostinventories.php.
oleg.egorov RESOLVED IN r38617
jelisejev The filtering itself should be done in hostinventories.php.
oleg.egorov RESOLVED IN r38724
- If you set the "Dropdown first entry" option to "none" in Administration->General, the hosts inventory page is not displayed at all;
- The paging line is calculated twice: on lines 152 and 218.
oleg.egorov RESOLVED IN r38786
jelisejev CLOSED.
(19) In default.css:
- the .textElement class is too ambiquious, it should be refactored into something more meaningful.
oleg.egorov RESOLVED IN r38578
jelisejev If it's only used for form list elements, it should be placed under the corresponding CSS selector.
jelisejev CLOSED.
(20) In CTabView
- the new method and property should be documented;
- for consistency, the "disabled" property should also be supported by the constructor.
oleg.egorov RESOLVED IN r38651
- The $disabledTabs property needs to be documented as well;
- Describe the $disabled parameter in CTabView::setDisabled();
- zbx_jsvalue() is deprecated, use CJs::encodeJson() instead;
oleg.egorov RESOLVED IN r38724
jelisejev CLOSED.
Please review a minor change in r38451.
oleg.egorov CLOSED
(21) Links in host inventory fields are no longer clickable.
oleg.egorov RESOLVED IN r38694
jelisejev CLOSED.
TESTED.
Please close (4) before merging.
Available in pre-2.1.6 (trunk) r38824.
(22) i might have missed something... if so, sorry. i don't see it being documented & docs reviewed.
if so... please, please guys - don't do this, you do some job and then for some weird reason make sure users do not find out about it.
<richlv> part this was reported as a bug by now - ZBX-7380. partially documented in that issue, but proper docs still missing (that page should be changed to be structured better, provide more info and use less of the word "overview")
martins-v Updated documentation:
- https://www.zabbix.com/documentation/2.2/manual/introduction/whatsnew220#latest_data_section
- https://www.zabbix.com/documentation/2.2/manual/web_interface/frontend_sections/monitoring/latest_data
- https://www.zabbix.com/documentation/2.2/manual/config/hosts/inventory#inventory_overview
- https://www.zabbix.com/documentation/2.2/manual/web_interface/frontend_sections/inventory/hosts#inventory_details
RESOLVED.
jelisejev A correction needs to be made in ZBX-8053, otherwise good. CLOSED.
This caused a regression - ZBX-7126.
Another regression - ZBX-7189.
(23) it was not easy enough to figure out which issue added inventory links in some popup menus - i added changelog entries in revisions 40321 and 40322. please check that it's correct.
jelisejev We didn't add the menu links, we just changed them to be displayed even if host inventory is disabled.
<richlv> ok, clarified a bit more in the changelog entry - hopefully now it's correct enough 
jelisejev Yep, that's correct. CLOSED.
(24) please check that link to latest data was indeed added in this issue. if so, specification must be updated.
<richlv> it's been some time... i think i meant link to host inventory from latest data here
jelisejev Then it's already mentioned in the spec: "Existing menu item 'Host inventories' will be renamed to 'Host inventory' and accessible for all hosts even with no inventory enabled."
https://www.zabbix.org/wiki/Docs/specs/ZBXNEXT-1763#Host_menu
<richlv> i guess my problem was lack of a list of places where this would change - essentially, places where host popup menu is used. this would also complicate things for testing - how would one know where to check for this link ?
let's find or document that list somewhere
martins-v Added in 2.4 documentation branch (seeing the work that was done in unifying these menus more for 2.4):
RESOLVED.
jelisejev Made a minor correction https://www.zabbix.com/documentation/2.4/manual/web_interface/frontend_sections/monitoring/dashboard?rev=1397223334&do=diff
CLOSED.
r38824 introduced a different behavior on Latest data. If an item is assigned multiple applications, it used to show up for each of them. Now an item only shows up beneath the first application found in the application array. This is not documented. Was it intended?
I'd appreciate to keep the origin behavior of showing an item in latest data for every application it is member of.
I am not sure why you believe an item is displayed for one application only. Have a look at the latest trunk to ensure that an item shows up for all applications it belongs to.
That was obviously solved at some point. It's fine in 2.2.5 and I think it was fine in 2.2.1 already.
subissues still open : 22, 24
ZBXNEXT-3710 asks for a link to item config from individual graph/value pages