hmm. what is this issue about, why is it a bug ?

Discussed with Eduard. It is about adding a new user agent in the default selection of user agent. It will be useful for filtering out requests coming from Zabbix in web server access log files. Anyway, it is a feature request not a bug.

<richlv> ah, ok. updated summary accordingly. the string should be carefully chosen, as it probably should contain mozilla etc references

Related issue: ZBX-8836

To distinguish zabbix just a "Zabbix" user agent will be enough.

As for other user agents, I suggest to offer the following user agents:

Explorer:

• IE 11
• IE 10
• IE 9
• IE 8
• IE 7
• IE 6
  Firefox
• Latest version on Windows
• Latest version on Linux
• Latest version on Mac
  Chrome
• Latest version on Windows
• Latest version on Mac
  Chromium
• Latest version on Linux
  Opera
• Latest version on Windows
• Latest version on Linux
• Latest version on Mac
  Safari
• Latest version on Mac
• Latest version on Windows
  Other
• Latest version of iPhone browser
• Latest version of iPad browser
• Latest version of Android browser
• Google bot

(1) The API should also set the default user agent when it's omitted.

iivs RESOLVED in svn://svn.zabbix.com/branches/dev/ZBXNEXT-1821 r50071

oleg.egorov CLOSED

(2) No translation string changes.

oleg.egorov CLOSED

iivs Added translation string:
'User agent string'

RESOLVED

oleg.egorov CLOSED

RESOLVED in svn://svn.zabbix.com/branches/dev/ZBXNEXT-1821

(3)

httptest.create

{
    "name": "t4",
    "hostid": 32309,
    "steps": [
        {
            "name": "blablabla",
            "url": "blablabla",
            "agent": "blablabla"
        }
    ]
}

• As result, Agent: Zabbix
• And please check agent value = 0
• I try set user agent "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0" (used by frontend), but again it set Zabbix
  And in DB agent value is Zabbix

iivs "agent" is property of httptest, not httpstep. Zero in combobox is fixed, however.
And value "-1" will remain as is for now.
Additional problems and validation with httptest.create method is described in https://support.zabbix.com/browse/ZBX-8996
RESOLVED in r50452

oleg.egorov Via frontend, set agent " " <- spaces. After page saving, agent displaying as IE11

iivs RESOLVED in r50919

oleg.egorov As discussed, please add new define for Zabbix user agent. And fix $fields array.

iivs Reverted changes made to $fields because it was getting too ugly, and added constant ZBX_DEFAULT_AGENT.
RESOLVED in r50925

oleg.egorov CLOSED

(4) Merge foreach
In CHttpTest.php:265-295

		foreach ($httpTests as &$httpTest) {
			unset($httpTest['templateid']);

			if (empty($httpTest['hostid']) && !empty($httpTest['applicationid'])) {
				$dbHostId = DBfetch(DBselect('SELECT a.hostid'.
						' FROM applications a'.
						' WHERE a.applicationid='.zbx_dbstr($httpTest['applicationid'])));
				$httpTest['hostid'] = $dbHostId['hostid'];
			}
		}
		unset($httpTest);

		foreach($httpTests as &$httpTest) {
			$defaultValues = array(
				'verify_peer' => HTTPTEST_VERIFY_PEER_OFF,
				'verify_host' => HTTPTEST_VERIFY_HOST_OFF
			);

			check_db_fields($defaultValues, $httpTest);
		}
		unset($httpTest);

		$this->validateCreate($httpTests);

		// set default user agent "Zabbix"
		foreach ($httpTests as &$httpTest) {
			if (!isset($httpTest['agent'])) {
				$httpTest['agent'] = 'Zabbix';
			}
		}
		unset($httpTest);

iivs RESOLVED in r50456

oleg.egorov CLOSED

Just for reference: If you are monitoring the login page of Exchange webmail, be aware that you may be treated differently with a string it doesn't recognize (-> 401).

(5) Browser list changes

• Move iPhone and iPad Safari under Safari tab
• Add Konqueror 4.14.2 (other tab)
• Add Lynx 2.8.8 (other tab)
• Add Opera Mini (Opera tab)
• Add Opera Mobile (Opera tab)

And update latest version for Chrome and other browsers

iivs RESOLVED in r50953, r50966

oleg.egorov CLOSED

TESTED

Implemented in pre-2.5.0 (trunk) r50979

(6) API documentation updated:

• https://www.zabbix.com/documentation/3.0/manual/api/reference/httptest/object
• https://www.zabbix.com/documentation/3.0/manual/api/changes_2.4_-_3.0

oleg.egorov CLOSED

(7) looks like this should be mentioned in whatsnew, too

martins-v Added to:

• https://www.zabbix.com/documentation/3.0/manual/introduction/whatsnew300#user_agent_options_in_web_monitoring

Please review. RESOLVED.

iivs Looks good.

CLOSED.

(9) Was discussed with sasha and iivs
If selected "other" user agent, should be able enter other user agent in to new input field.

iivs RESOLVED in r51137, r51139

oleg.egorov Please review my minor changes in r51189

iivs Thanks!
CLOSED.

TESTED

Implemented in pre-2.5.0 (trunk) r51216

(10) [AI] Default value for "agent" should be in database not in the API.

sasha RESOLVED in r51271, r51273.

oleg.egorov CLOSED

(11) Updated documentation:

• https://www.zabbix.com/documentation/3.0/manual/api/reference/httptest/create?parameters
• https://www.zabbix.com/documentation/3.0/manual/api/changes_2.4_-_3.0

oleg.egorov CLOSED

(12) API Request:

{
    "templateid": 32344,
    "hostid": 32344,
    "name": "API",
    "steps": [
        {
            "name": "Homepage",
            "url": "http://mycompany.com",
            "status_codes": 200,
            "no": 1
        }
    ]
}

Response:

SQL ERROR:
SQL statement execution has failed \"INSERT INTO httptest (templateid,hostid,name,verify_peer,verify_host,variables,headers,httptestid) VALUES ('10106','10106','API2','0','0','','','12')

In r51271 was removed:

unset($httpTest['templateid']);

From CHttpTest.php>create

sasha It is true, but httptest.create() method does not have any checks for read only parameters. I deleted an incorrect code. Strong validation will be implemented on server side API.

oleg.egorov I agree. CLOSED

TESTED

Default value for "agent" field was added in pre-2.5.0 (trunk) r51392.

no rationale was provided why user agent "Zabbix" was chosen (specifically, why no version was included).

while adding the version would be easy, the problem is that zabbix inserts that as a fixed string, thus each scenario would use the version in which it was created, not the current version of zabbix. a separate feature request could handle an agent string that would automatically use the current version of zabbix. then the question would be - frontend or server

server might be preferred, and then what if a scenario is monitored by a proxy ?

A magic string like "Zabbix {VERSION}" could be inserted into the database, in which case server or proxy would automatically use the correct value in place of "{VERSION}".

<richlv> created a new feature request - ZBXNEXT-2805

(13) Leading and trailing whitespaces in the custom useragent field should be trimmed

sasha RESOLVED directly in trunk r53483.

oleg.egorov CLOSED