[ZBXNEXT-2069] Support of {HOST.PORT} macro in the notifications Created: 2013 Dec 12  Updated: 2014 Oct 27  Resolved: 2014 Feb 03

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Server (S)
Affects Version/s: 2.2.0
Fix Version/s: 2.2.2, 2.3.0

Type: New Feature Request Priority: Major
Reporter: Alexander Vladishev Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: macros, notifications
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Now

{HOST.PORT}

macro is supported by auto-registration notifications.

The functionality should be extended. This macro should be supported by trigger-based and internal notifications as well.



 Comments   
Comment by Andris Zeila [ 2013 Dec 13 ]

Documentation update:

Not sure if Daemon Improvements was the best place for whatsnew note.

Comment by Andris Zeila [ 2013 Dec 13 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-2069

Comment by Aleksandrs Saveljevs [ 2013 Dec 13 ]

Tested. Looks wonderful.

Comment by Andris Zeila [ 2013 Dec 14 ]

Released in:
pre-2.2.2rc1 r40967
pre-2.3.0 r40968

Comment by Andris Zeila [ 2014 Jan 09 ]

(1) [S]

{HOST .PORT}

macro should be supported also by trigger name/description

wiper RESOLVED in r41428

asaveljevs Looks good, but please see r41528. Checks for macros where in different order in different places. RESOLVED.

wiper reviewed, CLOSED

Comment by Andris Zeila [ 2014 Jan 09 ]

(2) [F]

{HOST.PORT} macro should be supported also by trigger name/description

oleg.egorov RESOLVED IN r41462

asaveljevs (a) {HOST.PORT}

is expanded in trigger name in "Monitoring" -> "Triggers", but is not expanded in "Monitoring" -> "Events" or "Last 20 issues" in the dashboard.

oleg.egorov RESOLVED IN r41566

asaveljevs CLOSED

asaveljevs (b) I am not sure separating cases into "interfaceWithPriorities" and "interfaceWithPrioritiesPort" performance-wise is worth code complication that it introduces. Maybe just add

{HOST.PORT}

to PATTERN_INTERFACE_FUNCTION?

oleg.egorov CLOSED

asaveljevs (c) There is a typo in variable name $paternInterfaceFunction. REOPENED.

oleg.egorov RESOLVED IN r41566

oleg.egorov As discussed, should be renamed from -> to
interfaceWithPriorities -> interfaceWithoutPort
interface -> agentInterface
interfaceWithPrioritiesPort -> interface

asaveljevs It was $paternInterfaceFunction, now it became $paterntInterfaceFunction, which is even worse. The correct spelling is $patternInterfaceFunction. Fixed that in r41604. RESOLVED.

oleg.egorov Thanks! CLOSED

asaveljevs Tested

Comment by Oleg Egorov (Inactive) [ 2014 Jan 17 ]

FIXED IN 2.2.2rc1 r41605, 2.3.0 r41606
CLOSED

Comment by richlv [ 2014 Jan 30 ]

(3) according to (2),

{HOST.PORT}

support was also added in trigger name/description, but there is no changelog entry on that

Documentation also should be updated

wiper updated changelog in pre-2.2.2rc1 r42007 and pre-2.3.0 r42008

wiper marked as supported in overview and added 'supported since' note https://www.zabbix.com/documentation/2.2/manual/appendix/macros/supported_by_location?&#overview

wiper and updated whatsnew https://www.zabbix.com/documentation/2.2/manual/introduction/whatsnew222?&#daemon_improvements

Please review

asaveljevs Fixed typo in changelog entry in r42090.

asaveljevs In https://www.zabbix.com/documentation/2.2/manual/appendix/macros/supported_by_location , I think that "internal and trigger" is a more suitable style for official documentation than "internal/trigger". Simiarly for "names/descriptions".

asaveljevs In "What's new", the change is only listed as a daemon improvement, but it also an improvement in the frontend. REOPENED.

wiper Removed '/' from HOST.PORT macro description. Similar style was already used there, so I though it's acceptable. Regarding frontend documentation - I'm passing that to Oleg.

oleg.egorov RESOLVED

<richlv> now we have footnote "Supported since 2.2.2." and in the description "Supported in trigger names and descriptions since 2.2.2.".
other entries have various combinations of this, too. let's agree on some guidelines and unify this.

martins-v I'd propose the general rule as this - 'supported since' comments go in the Description (as done originally). However, when 'supported since' comments include a long listing (or would have to be repeated in too many cells), it is acceptable to add them in the footnotes and link to them.

martins-v Also, reviewed and removed the 'supported since' duplication in this particular case. And, for 'what's new', reviewed and improved the wording a bit and split it out into 'macro improvements' separately, rather than in 'daemon improvements'. Seeing that developer review of doc content has already taken place, I will set this as CLOSED.

Generated at Thu Apr 25 11:18:36 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.