[ZBXNEXT-2107] Improve navigation to triggers and hosts a trigger depends on Created: 2014 Jan 10  Updated: 2014 Apr 10  Resolved: 2014 Apr 04

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: 2.2.1
Fix Version/s: 2.3.0

Type: Change Request Priority: Trivial
Reporter: Volker Fröhlich Assignee: Ivo Kurzemnieks
Resolution: Fixed Votes: 0
Labels: dependencies, navigation, squashable, usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File navigate_dependencies.png    

 Description   

The list of triggers indicates all triggers a trigger depends on. The dependencies are stated as plain text though. They could well be hyperlinks to access the host or trigger configuration, like in the screenshot I attached.

The one that is still plain text is an LLD trigger and I found no easy way to gather the data necessary in an efficient way; that is without having various loops or ample calls to trigger.get(). I could attach a patch, but it is trivial, since I left out the aforementioned and it doesn't work properly for templates either.

Furthermore, the sorting order seems to be by triggerid or something. This is not a useful order for people to read.

 Comments   
Comment by Volker Fröhlich [ 2014 Jan 13 ]

Related to ZBX-7361, when it comes to sorting

Comment by Ivo Kurzemnieks [ 2014 Mar 28 ]

(1) No translatable strings changed.

jelisejev CLOSED.

Comment by Ivo Kurzemnieks [ 2014 Mar 28 ]

Added links on dependent triggers in configuration triggers list and edit pages.

RESOLVED in svn://svn.zabbix.com/branches/dev/ZBXNEXT-2107

Comment by Pavels Jelisejevs (Inactive) [ 2014 Mar 28 ]

(2) The links in the form must be opened in a new tab.

iivs RESOLVED in r43832

jelisejev CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2014 Mar 28 ]

(3) In the current trunk, if the dependency trigger belongs to multiple hosts, the host were separated by a comma. Now the comma is missing. Also, in the configuration form, all of the hosts must be displayed, the same way as in the list.

iivs Sorry about that. Forgot about they belong to multiple hosts. I added it back and added comma separated hosts in trigger dependency edit form. Note that only first host ID will be in the link, since we decided to display only one link for entire description.

RESOLVED in r43838

jelisejev

  1. I have a trigger that depends on trigger " {common1:item.last()}

    =0|

    {common2:item.last()}

    =0". The link in the configuration form points to host "common1", in the list - to "common2";

  2. Hosts in the trigger list must also be sorted.

iivs RESOLVED in r43887

jelisejev

  1. There shouldn't be a separate API request for each dependency trigger.
  2. I've made a minor change in r44025, please review.

iivs Change REVIEWED.
RESOLVED in r44085

jelisejev I've made some changes in r44098, please review.

iivs REVIEWED. Thanks! CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2014 Mar 28 ]

(4) The sorting issue has not been resolved.

iivs Trigger dependency list is now sorted by description just like in edit form.

RESOLVED in r43839

jelisejev CLOSED.

Comment by Ivo Kurzemnieks [ 2014 Mar 28 ]

(5) Remove links from LLD triggers

iivs RESOLVED in r43843

jelisejev CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2014 Mar 31 ]

(6) Forgot about the trigger mass update form. The links must also be added there.

iivs RESOLVED in r43892

jelisejev CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2014 Mar 31 ]

(7) Another minor improvement: let's add an indentation for the dependencies in the triggers list. After "Depends on".

iivs RESOLVED in r43888

jelisejev Please review my changes in r44023.

iivs Thanks! CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2014 Apr 03 ]

(8) Please remove the unnecessary spans around discovered trigger names.

iivs RESOLVED in r44082

jelisejev CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2014 Apr 07 ]

TESTED.

Please review and close (3) before merging.

Comment by Ivo Kurzemnieks [ 2014 Apr 07 ]

In triggers list, if trigger has dependency triggers, they will now have colored links (green or red depending on dependency trigger status).

In edit and massupdate forms a comma separated host list has been added if trigger belongs to multiple hosts. Also links to dependency triggers have been added there.

Implemented in pre-2.3.0 (trunk) r44106

Comment by Martins Valkovskis [ 2014 Apr 10 ]

(9) Documentation updated:

RESOLVED.

iivs REVIEWED.

CLOSED.

Generated at Sat Apr 05 15:08:09 EEST 2025 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.