[ZBXNEXT-2123] Monitoring->Triggers application and host inventory filter Created: 2014 Jan 23  Updated: 2014 Jul 03  Resolved: 2014 Mar 17

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: API (A), Frontend (F)
Affects Version/s: None
Fix Version/s: 2.3.0

Type: New Feature Request Priority: Major
Reporter: Pavels Jelisejevs (Inactive) Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: api, applications, filters, frontend, inventory, triggers, usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate

 Description   

Two additional filters will be implemented on the Monitoring -> Triggers page: filtering by application name and by host inventory data.



 Comments   
Comment by Pavels Jelisejevs (Inactive) [ 2014 Jan 23 ]

A more detailed specification is available here https://www.zabbix.org/wiki/Docs/specs/ZBXNEXT-2123.

Comment by Pavels Jelisejevs (Inactive) [ 2014 Jan 24 ]

RESOLVED in svn://svn.zabbix.com/branches/dev/ZBXNEXT-2123.

Comment by Alexander Vladishev [ 2014 Jan 29 ]

(1) Impossible to search by an inventory field with multiple values.

For example, I want to receive triggers from Linux hosts with 64-bit architecture.

OS = Linux
OS = x64

jelisejev RESOLVED in r41841. Updated the spec.

sasha CLOSED

Comment by Alexander Vladishev [ 2014 Jan 29 ]

(2) Reset button produces ~70 SQL statements like:

DELETE FROM profiles WHERE idx='web.tr_status.filter.inventory.type' AND idx2='0'

Only existing records should be deleted.

jelisejev RESOLVED in r41841.

sasha CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2014 Jan 29 ]

(3) [trunk] Consider using the same filter on the host inventory page.

jelisejev RESOLVED in r42859 and r42867. I've also changed the "Reset" button to submit the filter instead of just resetting the form.

jelisejev We've decided to revert the changes to the host inventory page, since the history overview page is using exact filtering. Reverted in r43361. CLOSED.

Comment by Alexander Vladishev [ 2014 Jan 29 ]

(4) inconsistency in cleaning of filters

Applications:

CProfile::update('web.tr_status.filter.application', getRequest('application'), PROFILE_TYPE_STR);

Inventory:

CProfile::delete('web.tr_status.filter.inventory.'.$field['db_field']);

jelisejev RESOLVED in r41850.

sasha CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2014 Jan 30 ]

(6) [2.4] Update the documentation.

martins-v Updated:

RESOLVED.

jelisejev The host inventory filter fields are a bit off on the screenshot.

Comment by Alexander Vladishev [ 2014 Jan 31 ]

(7) [trunk] CProfile::delete() method shouldn't delete nonexistent records.

jelisejev RESOLVED in r42872.

sasha REOPENED

  • Unneeded code:
      // remove from cache
    - if (!is_null(self::$profiles)) {
          foreach ($idx2 as $v) {
              unset(self::$profiles[$idx][$v]);
          }
    - }
    
  • $profile[$idx] should be removed from a cache when it is empty.
  • delete() method should check existence of $idx2

jelisejev RESOLVED in r43433.

sasha CLOSED

Comment by Alexander Vladishev [ 2014 Jan 31 ]

(8) Please review my changes in r42031.

jelisejev The application filter must be applied after the inventory filter. It allows to achieve a minor performance improvement. I've reverted the commit. CLOSED.

Comment by Eduards Samersovs (Inactive) [ 2014 Jan 31 ]

(9) Is better looks without .trigger-mon #inventory-filter td

{ height: 21px; }

jelisejev Agreed. RESOLVED in r42040.
Eduards CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2014 Jan 31 ]

Available in svn://svn.zabbix.com/branches/2.2.filter r42057.

Comment by richlv [ 2014 Feb 05 ]

(10) spec now says "The 'web.hostinventories.filter_field', 'web.hostinventories.filter_field_value' and 'web.hostinventories.filter_exact' profile key will no longer be used." (thanks), but that means that dbpatch should remove such values

jelisejev Yes, we'll add a patch as well.

jelisejev RESOLVED in r42869.

jelisejev I've reverted the patch due to reasons described in (3). CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2014 Feb 21 ]

(11) Unused code in tr_status.php:

/*
 * Play sound
 */
$mute = CProfile::get('web.tr_status.mute', 0);
if (isset($audio) && !$mute) {
	play_sound($audio);
}

jelisejev RESOLVED in r42895.

sasha CLOSED

Comment by Alexander Vladishev [ 2014 Mar 12 ]

(12) CProfile.delete() method supports arrays in the second parameter. We can use it in deleting web.tr_status.filter.inventory.* indexes

jelisejev RESOLVED in r43437.

sasha CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2014 Mar 17 ]

Available in 2.3.0 r43522.

Comment by Oleg Egorov (Inactive) [ 2014 Jun 20 ]

(14) In ZBX-7714 (1)

This filter will be replaced in ZBXNEXT-2123. The issue can be closed.

But problem still exist

oleg.egorov In Google Chrome, IE, FireFox is OK, in Opera is not so perfect, but CLOSED

Generated at Sat Apr 27 07:28:57 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.