[ZBXNEXT-2222] Port the trigger status filter to the trigger overview page Created: 2014 Mar 24  Updated: 2017 May 31  Resolved: 2014 Jun 19

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: 2.3.0
Fix Version/s: 2.3.2

Type: Change Request Priority: Major
Reporter: Pavels Jelisejevs (Inactive) Assignee: Unassigned
Resolution: Fixed Votes: 1
Labels: filters, frontend, overview, trigger
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by ZBX-8075 Overview page not displaying data/tri... Closed

 Description   

The Monitoring -> Overview page will have the same filter as the Monitoring -> Triggers page.



 Comments   
Comment by Pavels Jelisejevs (Inactive) [ 2014 Mar 25 ]

(1) [trunk] Changed the "Events" filters select labels to be single translatable strings.

jelisejev RESOLVED in r46171.

sasha CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2014 Mar 26 ]

Specification available at https://www.zabbix.org/wiki/Docs/specs/ZBXNEXT-2222.

Comment by Pavels Jelisejevs (Inactive) [ 2014 Mar 26 ]

(2) [trunk] Move the "Show details" checkbox to the bottom of the filter.

jelisejev RESOVLED in r46150.

sasha CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2014 Mar 26 ]

(3) [trunk] Split trigger and data overview view files into separate files.

jelisejev RESOLVED in r45916.

sasha CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2014 Mar 27 ]

(4) [trunk] Another bug that will be fixed in this issue: currently, if a trigger belongs to multiple hosts, it will be displayed only under one of them.

jelisejev RESOLVED in r46154.

sasha CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2014 Mar 27 ]

RESOLVED in svn://svn.zabbix.com/branches/2.2.filter.

Comment by Alexander Vladishev [ 2014 Mar 27 ]

(5) frontends/php/overview.php:205 useless code

'applications' => array('templated' => false)

sasha RESOLVED in r43845.

jelisejev CLOSED.

Comment by Eduards Samersovs (Inactive) [ 2014 Apr 07 ]

(6) Application ids getting code CScreenDataOverview.php:44 can be optimized, if we call API with "preservekeys" and when use array_keys().
Same in CScreenTriggersOverview()

jelisejev I don't agree that "preservekeys" should be used for retrieving IDs. It should be used when we require an associative array. WON'T FIX.

Comment by Eduards Samersovs (Inactive) [ 2014 Apr 07 ]

(7) CScreenTriggersOverview.php

  • duplicate code usage zbx_objectValues($hosts, 'hostid'), also this can be replaced on array_keys()
  • $applications = array() must be renamed to $applicationIds

jelisejev The first problem is resolved in r46158. I don't agree about renaming $applications since it contains applications, not their IDs. RESOLVED.

sasha RESOLVED in r46711.

jelisejev CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2014 Jun 03 ]

(8) If no triggers are found, the "No items found." text is displayed. I've corrected it to "No triggers found."

RESOLVED in r46143.

sasha CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2014 Jun 03 ]

(9) Translatable string changes:

Removed strings:

  • Show all
  • Show unacknowledged

Added strings:

  • Show all (%1$s day)
  • Show all (%1$s days)
  • Show unacknowledged (%1$s day)
  • Show unacknowledged (%1$s days)

sasha CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2014 Jun 04 ]

(10) I've changed the alignment of labels in old filter to right in 46180. RESOLVED.

sasha CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2014 Jun 04 ]

RESOLVED for 2.4 in svn://svn.zabbix.com/branches/dev/ZBXNEXT-2222.

Comment by Alexander Vladishev [ 2014 Jun 19 ]

Successfully tested! Please close (5), (7) and (11) before a merge.

Comment by Alexander Vladishev [ 2014 Jun 20 ]

Available in pre-2.3.2 r46759.

Comment by richlv [ 2014 Aug 22 ]

(31) documentation

martins-v Updated documentaton, please review:

jelisejev Looks good, CLOSED.

Comment by richlv [ 2014 Aug 22 ]

subissues still open : 11, 31

Generated at Wed Apr 24 00:22:25 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.