Zabbix agent 2.0.6, Zabbix agent 2.2.2 x64.
Windows server 2008 R2 x64.

It's already documented. Zabbix does not support system.swap.size[pfree/pused] under Windows. Moved to ZBXNEXT.

Implemented in svn://svn.zabbix.com/branches/dev/ZBXNEXT-2225

Successfully tested

Implemented in 2.3.0 (trunk) r44094

(1) The ChangeLog entry should probably mention Windows. Otherwise, it implies that the change applies to all platforms. The entry should also not include "P" and "S" components, because the change is agent-only.

jurism Will change upon remerging into upstream.

(2) The change introduces bad formatting into variable declaration.

jurism
Corrected. RESOLVED.

asaveljevs CLOSED.

(3) In "pfree" calculation, it divides integer by integer, yielding either 0 or 100.

jurism
Added typecasts to correct this. RESOLVED.

asaveljevs Good, but please see r44395 before merging. CLOSED.

(4) It might be useful to clarify in swap.c comments what exactly the problems with Windows functions are.

For instance, the second paragraph talks about "free memory size". Which API functions does it refer to? The functions we use (see documentation below) do not use the term "free". They talk about paging file, physical memory, and virtual memory.

• GlobalMemoryStatus: http://msdn.microsoft.com/en-us/library/windows/desktop/aa366586(v=vs.85).aspx
• GlobalMemoryStatusEx: http://msdn.microsoft.com/en-us/library/windows/desktop/aa366589(v=vs.85).aspx

• MEMORYSTATUS: http://msdn.microsoft.com/en-us/library/windows/desktop/aa366772(v=vs.85).aspx
• MEMORYSTATUSEX: http://msdn.microsoft.com/en-us/library/windows/desktop/aa366770(v=vs.85).aspx

The comment also talks about "special circumstances" and says "depending on the system and the environment". What are those circumstances and dependencies?

jurism
Commentary expanded. RESOLVED.

asaveljevs Andris Z. helped to improve the comment in r44422 (e.g., by clarifying that negative values do not come from Windows API functions, but arise as results of calculations). CLOSED.

(5) According to the documentation on MEMORYSTATUSEX (see http://msdn.microsoft.com/en-us/library/windows/desktop/aa366770(v=vs.85).aspx), field "ullAvailPageFile" refers to the limit for the current process and suggests the use of GetPerformanceInfo() to get the system-wide limit. Why did we decide to use the process limit instead?

wiper GetPerformanceInfo() is not available on Win2K, plus it returned 0 total physical memory on my virtual machine.

asaveljevs CLOSED.

Implemented in 2.3.0 (trunk) r44444