[ZBXNEXT-2760] Per host count of unsupported items Created: 2015 Apr 01  Updated: 2015 Sep 16  Resolved: 2015 Aug 17

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Server (S)
Affects Version/s: 2.4.4
Fix Version/s: 2.5.0

Type: New Feature Request Priority: Major
Reporter: Francesco Paolo Barile Assignee: Unassigned
Resolution: Fixed Votes: 2
Labels: internalmonitoring, items, newitemkey, notsupported, patch
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Centos 7

Attachments: Text File zabbix_unsupported_per_host-2.5.0.patch     File zabbix_unsupported_per_host.patch     File zabbix_unsupported_per_host_v2.patch     File zabbix_unsupported_per_host_v3.patch    

 Description   

Sometimes when a monitored host fails its items can't trigger anything, they simply go in unsupported state (think for example to simple checks like vmware ones).
In some cases when a VMWare hypervisor failed nothing was notified. So the idea was to have an item that would count the unsupported items for that host.
Now Zabbix has zabbix[items_unsupported] as internal check to count unsupported items, but it only count them on a whole system level.
I wrote a patch that I'm proposing in attachment to add a second parameter "host" to the internal check, so that it will count only the unsupported items of the host where it was applied.
I'm currently testing it on Centos7 and Zabbix 2.4.4 and it seems to work as expected.

 Comments   
Comment by Francesco Paolo Barile [ 2015 Apr 01 ]

Note that the second parameter I'm proposing is optional, so the default behaviour of zabbix[items_unsupported] would be the same as it is now.

Comment by richlv [ 2015 Apr 01 ]

this was first requested at ZBXNEXT-1478 but never got implemented

Comment by Stefan [ 2015 Apr 02 ]

it would be nice if zabbix sia add this patch to the next 2.4.x release and also to 3.0

Comment by Francesco Paolo Barile [ 2015 Apr 08 ]

Same patch, but cleaner.

Comment by Tomasz Kłoczko [ 2015 May 26 ]

v3 patch: small cleanup to removed patching @@ -6350,7 +6353,7 @@ src/libs/zbxdbcache/dbconfig.c (add empty line with two tabs

Comment by Tomasz Kłoczko [ 2015 Jul 28 ]

I've updated patch providing unsupported items counter per host for 2.5.0 trunk branch.

Comment by Andris Zeila [ 2015 Jul 28 ]

Instead of adding another parameter to zabbix[items/items_unsupported] keys we decided it would be more logical to add new parameters to zabbix[host,...] key - zabbix[host,,items] and zabbix[host,,items_unsupported].

The specification is available at https://www.zabbix.org/wiki/Docs/specs/ZBXNEXT-2760

Comment by Tomasz Kłoczko [ 2015 Jul 28 ]

OK. It make (IMO) sense.

Comment by Andris Zeila [ 2015 Jul 28 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-2760

Comment by dimir [ 2015 Aug 12 ]

Please review my small changes in r54881.

wiper Thanks

Comment by Andris Zeila [ 2015 Aug 14 ]

Released in:

  • pre-2.5.0 r54966
Comment by Andris Zeila [ 2015 Aug 14 ]

(1) Documentation:

sasha CLOSED

Comment by Tomasz Kłoczko [ 2015 Aug 14 ]

Yesterday I found some issue with zabbix_unsupported_per_host_v3.patch which is against 2.4.

I've started adding in our monitoring unsupported items counter on dummy hosts which holds only aggregated items.
Problem was that by some issues in whole data used in those aggregations all items placed on such dummy hosts we had all aggereated items in unsupported state. Strangely item with counter of unsupported items is reporting zero items in unsupported state (when 100% of all items are in this state).

Maybe this issue is present only on 2.4 (will try to investigate this).
I'm only suggesting to make some tests on 2.5/3.0 with this new item on dummy hosts and/or when 100% already present items are in unsupported state because maybe one of those scenarios is causing that this new new key is giving wrong (zero) values.

Comment by richlv [ 2015 Aug 15 ]

(2) string changes

wiper Added translation strings:

  • Number of enabled items on the host.
  • Number of unsupported items on the host.

sasha Thanks! CLOSED

Comment by Andris Zeila [ 2015 Aug 17 ]

The proposed patches were slightly different than the applied implementation. However the base idea was the same, so hard to tell whhy it would not work. Did you check if the zabbix[items_unsupported] worked correctly?

Generated at Thu Apr 18 22:49:13 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.