[ZBXNEXT-2877] Add {#DATACENTER.NAME} to vSphere monitoring discovery key fields Created: 2015 Jul 10 Updated: 2022 Apr 05 Resolved: 2016 Sep 04 |
|
Status: | Closed |
Project: | ZABBIX FEATURE REQUESTS |
Component/s: | Server (S) |
Affects Version/s: | None |
Fix Version/s: | 3.2.0beta1 |
Type: | New Feature Request | Priority: | Major |
Reporter: | Yuya Kusakabe | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 1 |
Labels: | macros, newmacro, vmware | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified |
Issue Links: |
|
Description |
I want to use datacenter name for grouping VMs, Hypervisors, or Clusters. |
Comments |
Comment by Andris Zeila [ 2016 Aug 12 ] |
Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-2877 |
Comment by Andris Zeila [ 2016 Aug 12 ] |
Datacenter name was added to hypervisor and virtual machine hosts:
Also {#DATACENTER.NAME} field was added to hypervisor and virtual machine discovery keys vmware.hm.discovery and vmware.vm.discovery. |
Comment by Andris Zeila [ 2016 Aug 25 ] |
Released in: |
Comment by Glebs Ivanovskis (Inactive) [ 2016 Aug 26 ] |
(1) [D] Changes to be documented in:
wiper RESOLVED glebs.ivanovskis Thanks! Documentation is Ok, but official templates seem to be same as old ones. REOPENED wiper RESOLVED glebs.ivanovskis CLOSED |
Comment by Glebs Ivanovskis (Inactive) [ 2016 Aug 26 ] |
Successfully tested! Everything looks fine except this new line which, I guess, can be removed directly in trunk: Index: src/zabbix_server/vmware/vmware.c =================================================================== --- src/zabbix_server/vmware/vmware.c (revision 61995) +++ src/zabbix_server/vmware/vmware.c (working copy) @@ -1921,7 +1921,6 @@ if (NULL == (hv->datacenter_name = zbx_xml_read_value(page.data, "/*/*/*/*/*/*[local-name()='val']"))) hv->datacenter_name = zbx_strdup(NULL, ""); - ret = SUCCEED; out: zabbix_log(LOG_LEVEL_DEBUG, "End of %s():%s", __function_name, zbx_result_string(ret)); sasha Thanks! RESOLVED directly in trunk r62251. CLOSED |
Comment by Aleksandrs Saveljevs [ 2016 Sep 27 ] |
(2) There is the following warning when compiling r62811 of 3.2 branch: checks_simple_vmware.c:1818:8: warning: unused variable 'i' [-Wunused-variable] int i, ret = SYSINFO_RET_FAIL; ^ 1 warning generated. wiper It's fixed in /branches/dev/ asaveljevs Looks good. CLOSED. |