[ZBXNEXT-3066] Validate time stamps when receiving data from active agent/proxy, sender Created: 2015 Dec 08  Updated: 2015 Dec 08

Status: Open
Project: ZABBIX FEATURE REQUESTS
Component/s: Agent (G), Proxy (P), Server (S)
Affects Version/s: None
Fix Version/s: None

Type: Change Request Priority: Trivial
Reporter: Glebs Ivanovskis (Inactive) Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: proxy, sender, server, trapper, usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Sending in item values and their collection times via Zabbix sender is a cool feature. But Unix time stamp format is a bit tricky for human beings and it is easy to get it all wrong.

Currently Zabbix server uses standard atoi() function to convert received time stamp strings to int. This function does not check for any kind of error.

My suggestion is to validate received time stamps stricter. At least we may want to assure that received clock

  • is a valid numeric value,
  • is not negative,
  • does not overflow int type we use in zbx_timestamp_t,
  • does not correspond to a time moment from (distant) future.

Maybe we should make validation rules even stricter (let say, server should reject items from distant past) but user should be able to override these extra checks with a special flag to Zabbix sender.



 Comments   
Comment by Oleksii Zagorskyi [ 2015 Dec 08 ]

Initially it was discussed in ZBXNEXT-3055.

Generated at Fri Apr 26 23:03:18 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.