[ZBXNEXT-3082] Private slide shows Created: 2016 Jan 04  Updated: 2016 Jan 28  Resolved: 2016 Jan 28

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: API (A), Frontend (F)
Affects Version/s: None
Fix Version/s: 3.0.0beta1

Type: Change Request Priority: Blocker
Reporter: Ivo Kurzemnieks Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: slideshows
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

It would be nice to support private slide shows with ability of sharing it with other users and user groups.



 Comments   
Comment by Oleg Egorov (Inactive) [ 2016 Jan 12 ]

Specification at https://www.zabbix.org/wiki/Docs/specs/ZBXNEXT-3082

Comment by Oleg Egorov (Inactive) [ 2016 Jan 12 ]

(1) Translation strings added:*

  • All slide shows
  • Only administrators can set slide show owner.
  • Slide show "%1$s" is public and read-only sharing is disallowed.
  • Slide show owner cannot be empty.
  • User "%1$s" is slide show "%2$s" owner.

iivs CLOSED

Comment by Oleg Egorov (Inactive) [ 2016 Jan 14 ]

(2) [I] Please review schema changes and database upgrade patch in r57638

iivs Looks good.
CLOSED

Comment by Ivo Kurzemnieks [ 2016 Jan 18 ]

(3) We agreed not to make a new menu section Monitoring -> Slideshows. Slideshows will remain under the already existing dropdown.

oleg.egorov RESOLVED IN r57746

iivs r57746 adds a sub navigation, but that was not the case. Please, read this subissue again.

REOPENED.

oleg.egorov RESOLVED IN r57746

iivs CLOSED

Comment by Ivo Kurzemnieks [ 2016 Jan 18 ]

(4) Create form currently broken.

Error in query [INSERT INTO slideshows (slideshowid,name,delay) VALUES ('1','ZBXsrvr','30')] [Cannot add or update a child row: a foreign key constraint fails (`ivo_zbxnext_3082/slideshows`, CONSTRAINT `c_slideshows_3` FOREIGN KEY (`userid`) REFERENCES `users` (`userid`))]
Error in query [INSERT INTO slides (slideid,slideshowid,screenid,step,delay) VALUES ('1','1','16',0,'0')] [Cannot add or update a child row: a foreign key constraint fails (`ivo_zbxnext_3082/slides`, CONSTRAINT `c_slides_1` FOREIGN KEY (`slideshowid`) REFERENCES `slideshows` (`slideshowid`) ON DELETE CASCADE)]

oleg.egorov RESOLVED IN r57779

iivs Slideshow can be created with success message, but with minor errors:

Undefined variable: shared_users [slideconf.php:123 → add_slideshow() in include\screens.inc.php:228]
Undefined variable: shared_user_groups [slideconf.php:123 → add_slideshow() in include\screens.inc.php:239]

REOPENED

oleg.egorov RESOLVED IN r57780

iivs CLOSED

Comment by Ivo Kurzemnieks [ 2016 Jan 18 ]

(5) User is able to see read-only screens, but cannot added them to slideshows.

oleg.egorov RESOLVED IN r57785 and r57786

iivs CLOSED

Comment by Ivo Kurzemnieks [ 2016 Jan 18 ]

(6) Superadmin has shared a slideshow with regular users with read permissions, they do not appear in the list. Also not possible to open that slideshow in view mode.

oleg.egorov RESOLVED IN r57785 and r57786

iivs Regular users from group 1 and able to see private slideshows from regular users group 2

REOPENED

oleg.egorov RESOLVED IN r57846

iivs Create form is broken again.

Undefined index: userid [ in slideconf.php:300]

Also there is no user selection. It says "Inaccessible user".

REOPENED

oleg.egorov RESOLVED in r57848 and r57849

iivs CLOSED

Comment by Ivo Kurzemnieks [ 2016 Jan 18 ]

(7) Public slideshow and read-only mode should not be allowed at the same time.

oleg.egorov RESOLVED IN r57782

iivs CLOSED

Comment by Ivo Kurzemnieks [ 2016 Jan 19 ]

(8) Slideshow update form: Open a slide show that belongs to another user. The sharing is broken and there are errors.

Undefined offset: 30 [slideconf.php:298 → CView->render() → include() in include\views\monitoring.slideconf.edit.php:199]
Undefined offset: 20 [slideconf.php:298 → CView->render() → include() in include\views\monitoring.slideconf.edit.php:229]
Undefined offset: 21 [slideconf.php:298 → CView->render() → include() in include\views\monitoring.slideconf.edit.php:229]
Undefined offset: 22 [slideconf.php:298 → CView->render() → include() in include\views\monitoring.slideconf.edit.php:229]

oleg.egorov RESOLVED IN r57822

iivs Having owner from other group, the user name is inaccessible, but that form cannot be updated any more. It says: "Slide show owner cannot be empty."

REOPENED

oleg.egorov RESOLVED IN r57836

iivs CLOSED

Comment by Ivo Kurzemnieks [ 2016 Jan 19 ]

(9) Please, review my changes in r57802, r57820, r57831

oleg.egorov Thank you! CLOSED

Comment by Ivo Kurzemnieks [ 2016 Jan 19 ]

(10) Having a non-existing slide shows or inaccessible slideshow saved in user profile, user gets stuck in slides.php with error. Also same problem with screens.

oleg.egorov RESOLVED IN r57847

iivs CLOSED

Comment by Ivo Kurzemnieks [ 2016 Jan 19 ]

(11) Read-only and publicly shared slideshows should not have link to properties and should have a disabled checkbox. Also that slideshow should not be accessible in form when ID entered manually in URL.

oleg.egorov RESOLVED IN r57846

iivs CLOSED

Comment by Oleg Egorov (Inactive) [ 2016 Jan 19 ]

Available in pre-3.0.0beta1 (trunk) r57850.

Comment by Oleg Egorov (Inactive) [ 2016 Jan 20 ]

(12) API documentation

Updated documentation:

martins-v Looks good to me. If iivs approves it, can be closed.

iivs There is no API for slide shows. Only user.delete that validates deletion of user.

REOPENED

oleg.egorov RESOLVED

iivs CLOSED

Comment by Martins Valkovskis [ 2016 Jan 21 ]

(13) General documentation updates:

RESOLVED.

iivs Let's add that note about required read-write change to read-only permissions to elements.

REOPENED

martins-v Added to https://www.zabbix.com/documentation/3.0/manual/introduction/whatsnew300#private_maps_screens_and_slide_shows

Also access rights better described in https://www.zabbix.com/documentation/3.0/manual/config/visualisation/slides

RESOLVED

iivs Looks good (to me). Thanks!

CLOSED

Generated at Sat Apr 20 07:29:51 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.