Worth to mention related discussion, to make the topic more clear - ZBX-9918
I could support this request. It should affect only agent and documentation components.
Question is - should we remove the "skip" from all related keys in database by upgrade patches - I'm not sure here as zabbix agents in network may be upgraded randomly and much later after server upgrade.
If we will be ready to go for such changes (major release only I suppose), what I'd also suggest is to add one more mode - "skipold".
Taking into account the ZBX-9918 discussion I mentioned, it should always skip existing log parsing on agent start.
Some zabbix users really want to have such a mode for log* items.
kodai I think new skip logic seems bug for users. Probably they worry about Zabbix miss to detect error messages by restarting agent. "skipold" parameter is bit confusing for me, for example it's hard to understand "what is OLD behaviour" for new users. so I think it's better to back to old logic.
zalex_ua name for the new additional parameter cold be different. Initially I thought about "skipalways".
I'm not sure you correctly understand how "skip" is working currently - agent restart does't skip existing log messages if the item collected values earlier.
|