Server: performance improvements (ZBXNEXT-318)

[ZBXNEXT-313] store strings in an intern pool Created: 2010 Apr 20  Updated: 2017 May 31  Resolved: 2010 Jun 18

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Proxy (P), Server (S)
Affects Version/s: None
Fix Version/s: None

Type: Change Request (Sub-task) Priority: Major
Reporter: Aleksandrs Saveljevs Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File zabbix_server.log    

 Description   

Only a single instance of a string should be stored.

 Comments   
Comment by Alexander Vladishev [ 2010 May 11 ]

Красотища!

Comment by Aleksandrs Saveljevs [ 2010 May 11 ]

Available in pre-1.8.3 in r11913.

Comment by Alexander Vladishev [ 2010 Jun 17 ]

Crash on BSD platforms:

25915:20100617:141732.608 In zbx_strpool_intern() str[system.run[{$CMD}>/dev/null,nowait]]
25915:20100617:141732.608 zbx_strpool_intern() str:0x82d8c000
25915:20100617:141732.608 zbx_strpool_intern() str - REFCOUNT_FIELD_SIZE:0x82d8bffc
25915:20100617:141732.608 In zbx_hashset_search()
25915:20100617:141732.609 End of zbx_hashset_search()
25915:20100617:141732.609 zbx_strpool_intern() str:0x82d8c000
25915:20100617:141732.609 zbx_strpool_intern() str - REFCOUNT_FIELD_SIZE:0x82d8bffc
25915:20100617:141732.609 In zbx_hashset_insert()
25915:20100617:141732.610 zbx_hashset_insert() data:0x82d8bffc size:40
25915:20100617:141732.610 In zbx_mem_malloc(): size[12]
25915:20100617:141732.610 End of zbx_mem_malloc()
25915:20100617:141732.610 zbx_hashset_insert() entry:0x7d644060
25915:20100617:141732.610 In zbx_mem_malloc(): size[40]
25915:20100617:141732.611 End of zbx_mem_malloc()
25915:20100617:141732.611 zbx_hashset_insert() entry->data:0x7d644080
25915:20100617:141732.611 zbx_hashset_insert() data:0x82d8bffc size:40
25915:20100617:141732.611 Got signal [signal:11(SIGSEGV),reason:1,refaddr:0x82d8bffc]. Crashing ...
25915:20100617:141732.611 ====== Fatal information: ======
25915:20100617:141732.612 === Backtrace: ===
25915:20100617:141732.612 backtrace not available for this platform
25915:20100617:141732.612 === Memory map: ===
25915:20100617:141732.612 memory map not available for this platform
25915:20100617:141732.612 ================================
25915:20100617:141732.611 zbx_hashset_insert

Comment by Aleksandrs Saveljevs [ 2010 Jun 19 ]

Hack-free version available in pre-1.8.3 in r12934.

Generated at Fri Apr 26 08:25:34 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.