[ZBXNEXT-317] implement ability to show disabled hosts in Monitoring->Latest Created: 2010 Apr 22  Updated: 2013 Sep 26  Resolved: 2013 Sep 10

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 2.1.3

Type: Change Request Priority: Major
Reporter: Igor Danoshaites (Inactive) Assignee: Martins Valkovskis
Resolution: Fixed Votes: 6
Labels: latestdata
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by ZBX-6405 Viewing latest data for a host isn't ... Closed
is duplicated by ZBX-6528 Hide or mark disabled hosts in Invent... Closed

 Description   

Will be nice if in the Monitoring->Latest data report could be implemented the possibility to show data also for the disabled hosts.
At this moment disabled hosts are not shown at all in the Monitoring->Latest data.

Specification: https://www.zabbix.org/wiki/Docs/specs/ZBXNEXT-317



 Comments   
Comment by richlv [ 2011 Sep 02 ]

ZBX-3498 asks for a similar thing in configuration section

Comment by richlv [ 2013 Apr 19 ]

when implementing this, don't forget report section (ZBX-6528)
...and monitoring -> web

Comment by Nicola Canepa [ 2013 May 09 ]

I need to see historical data even for disabled hosts.
Is it possible?
Same happens in the "Screen" section of "Monitoring"

Comment by Volker Fröhlich [ 2013 May 11 ]

Being able to click "Latest data", after searching for a disabled host, is another glitch.

Comment by Guntis Zarins (Inactive) [ 2013 Aug 12 ]

RESOLVED in [svn://svn.zabbix.com/branches/dev/ZBXNEXT-317] r37732.

Comment by Guntis Zarins (Inactive) [ 2013 Aug 12 ]

(1) Need to highlight disabled hosts in PageFilter.

guntis.zarins RESOLVED in r37748.

iivs REOPEN
Unmonitored hosts without items must not be in page filter. Unmonitored hosts with items are allowed.

iivs RESOLVED in r37876
Eduards CLOSED

Comment by Guntis Zarins (Inactive) [ 2013 Aug 13 ]

(2) Finded some style problems, that selected option does not take affect of defined css style.

guntis.zarins
Added javascript function for adding or removing css classes to specified dropdown.
RESOLVED in r37766.

Eduards REOPEN, See (8) for addition info

iivs RESOLVED in r37897

Eduards CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Aug 14 ]

(3) Please use "#DC0000" color

iivs RESOLVED in r37881
Eduards CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Aug 14 ]

(4) variable name 'cssStyles' is misleading because css class and style is the different concept. Commonly we use "class". For example class.ccol.php

iivs RESOLVED in r37883

Eduards REOPEN, please rename $cssClass to $class as discussed.
class.ccombobox.php:64
class.ceditablecombobox.php:31

iivs RESOLVED in r37992
Eduards CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Aug 14 ]

(5) class.cpagefilter.php:769 must be formatted like:

$styles[$key] = ($value['status'] == HOST_STATUS_NOT_MONITORED) ? 'not-monitored' : null;

iivs RESOLVED in r37878
Eduards CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Aug 14 ]

(6) In CPageFilter->_getCB() isset($options['cssStyles']) checks twice

iivs RESOLVED in r37882
Eduards CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Aug 14 ]

(7) Undefined index in dashboard, also is possible in others places where popup menus is used.

Undefined index: status [dashboard.php:142 → make_latest_issues() → hostMenuData() in /home/zabbix/www/testing-ZBXNEXT-317/frontends/php/include/hosts.inc.php:772]

iivs Found another undefined index when in Monitoring > Events selecting "all" in filter. And more (some might be unrelated):

Undefined index: status [events.php:714 → hostMenuData() in C:\Development\ZBXNEXT-317\frontends\php\include\hosts.inc.php:772]
Declaration of CEditableComboBox::addItem() should be compatible with CComboBox::addItem($value, $caption = '', $selected = NULL, $enabled = 'yes', $cssClass = NULL) [httpconf.php:414 → CView->render() → include() → spl_autoload_call() → CAutoloader->loadClass() → CAutoloader->loadClass() in C:\Development\ZBXNEXT-317\frontends\php\include\classes\core\CAutoloader.php:59]
Undefined index: hostid [ in C:\Development\ZBXNEXT-317\frontends\php\httpconf.php:287]

iivs RESOLVED in r37888
Eduards CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Aug 14 ]

(8) Init.js is not the right place for jQuery.fn.changeDropdownStyle() Also is not good idea to globally check #hostid and make js for it.

iivs RESOLVED in r37897
Eduards REOPEN selectDropdownBox() can be optimized as discussed

iivs RESOLVED in r37999

Eduards Init.js was right place, my mistake, please review my changes in r.38000
iivs REVIEWED.
Looks good. Thanks!
CLOSED.

Comment by Eduards Samersovs (Inactive) [ 2013 Aug 14 ]

(9) Please find better line to move new css in default.css

iivs RESOLVED in r37881
Eduards CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Aug 14 ]

(10) httpmon.php

  • httpmon.php:111 if we use reset array variable name must be without "s" at the end
  • httpmon.php:150-153 this code must be carefully formatted, require addition spaces and brackets. Also maybe be better to move this code in separate variable?

iivs RESOLVED in r37888
Eduards REOPEN Will be good to unset $httpTest['hosts'] array after it was reset into $httpTest['host']

iivs RESOLVED in r37993
Eduards CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Aug 14 ]

(11) latest.php:413,536 also must be carefully formatted, require addition spaces

iivs RESOLVED in r37877
Eduards CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Aug 20 ]

(12) In spec not mentioned what host without data will be colored in popups. For example in items filter for application field popup

iivs After discussion decided that hosts will be highlited also in pop-ups. Documentation will be updated accordingly.

Eduards OK, CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Aug 21 ]

Tested, but please review r.38000

jelisejev Reviewed, everything OK.

Comment by Pavels Jelisejevs (Inactive) [ 2013 Aug 23 ]

(13) Some issues regarding the changes in CPageFilter:

1. CPageFilter::$data['hosts'] now contains an array of host, but other keys in CPageFilter::$data contain names. To be consistent, they should all contain the same value types.
2. The "class" option for CPageFilter::_getCB() is not documented. Plus, it contains an array of classes and should be named "classes" in plural.

jelisejev RESOLVED in r38073, 38074 and 38075.
Eduards REOPEN class.cpagefilter.php:769 - $class also must be renamed to $classes

jelisejev RESOLVED in r38076.
Eduards CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Aug 23 ]

Tested

Comment by Pavels Jelisejevs (Inactive) [ 2013 Aug 23 ]

Available in 2.1.3 r38080.

Comment by Pavels Jelisejevs (Inactive) [ 2013 Aug 23 ]

(14) Documentation must be updated.

martins-v Updated:

martins-v CLOSED.

Comment by Alexander Vladishev [ 2013 Sep 03 ]

(15) Broken displaying of disabled elements in drop-down lists. For example, languages in the user profile form.

iivs RESOLVED in svn://svn.zabbix.com/branches/dev/ZBXNEXT-317 r38314

oleg.egorov Please change color for disabled element, from red (#DC0000) to grey (#808080)

REOPEN

iivs RESOLVED in r38376

oleg.egorov CLOSED

Comment by Oleg Egorov (Inactive) [ 2013 Sep 10 ]

TESTED

Comment by Ivo Kurzemnieks [ 2013 Sep 10 ]

Fixed in pre-2.1.5 (trunk) r38386

Comment by Eduards Samersovs (Inactive) [ 2013 Sep 11 ]

(16) Graph name is broken in Monitoring->Graphs

iivs RESOLVED in svn://svn.zabbix.com/branches/dev/ZBXNEXT-317 r38474
Eduards CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Sep 13 ]

Tested

Comment by Ivo Kurzemnieks [ 2013 Sep 13 ]

Fixed in pre-2.1.5 (trunk) r38485

Generated at Wed Jan 08 00:57:54 EET 2025 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.