[ZBXNEXT-3210] Replace user macro cache with caching expanded trigger expressions Created: 2016 Mar 22  Updated: 2018 Jun 27  Resolved: 2016 Mar 29

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Server (S)
Affects Version/s: 3.0.1
Fix Version/s: 3.0.2, 3.2.0alpha1

Type: Change Request Priority: Minor
Reporter: Andris Zeila Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File trigger_expression_eval_v3.diff    
Issue Links:
Causes
causes ZBX-14500 zabbix_server crash on macro expansio... Closed

 Description   

To reduce configuration cache locking a user macro cache (zbx_umc_*) was added to Zabbix 3.0. However this cache turned out overly complex, as it had to support batch operations for mutiple triggers.

Another workaround was found (and tested) for 2.2 - cache trigger expression with expanded user macros and reuse it for trigger calculations until next configuration cache sync. This achieves the targeted improvement (reduced configuration cache locking when processing trigger expressions) with much less code complexity.

It was decided to remove user macro cache and implement trigger expression caching.

In future similar improvements could be made to item processing for some fields. For example vmware items almost always will have user macros in 3 item fields, resulting in additional 3 configuration cache locks during each item processing.



 Comments   
Comment by Andris Zeila [ 2016 Mar 23 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-3210

Comment by Alexander Vladishev [ 2016 Mar 24 ]

(1) take a look at my changes in r59105:59127

wiper CLOSED

Comment by Andris Zeila [ 2016 Mar 29 ]

Released in:

  • pre-3.0.2rc1 r59141
  • pre-3.1.0 r59142
Comment by Glebs Ivanovskis (Inactive) [ 2016 May 06 ]

Caused ZBX-10692.

Comment by Glebs Ivanovskis [ 2018 Jun 27 ]

Looks like it also caused ZBX-14500.

Generated at Fri Apr 19 11:11:41 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.