[ZBXNEXT-370] Enhance Dropdown first entry to allow ALL, even when None Selected is chosen Created: 2010 May 22  Updated: 2021 Oct 14  Resolved: 2021 Oct 14

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: None

Type: Change Request Priority: Minor
Reporter: Steve mushero Assignee: Unassigned
Resolution: Won't fix Votes: 27
Labels: dropdown, patch, usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

All


Attachments: File ZBXNEXT-370-2.0.9-6-NoneAll.patch     File ZBXNEXT-370-2.0.9-NoneAll-ConfigurationAll.patch     File ZBXNEXT-370-2.2.2-2.patch     PNG File ZBXNEXT-370-2.2.2-combobox.png     PNG File ZBXNEXT-370-2.2.2-configuration.png     File ZBXNEXT-370-2.2.2-events.patch     File ZBXNEXT-370-2.2.2-overview-app-only.patch     File zbxNext370-light.patch    
Issue Links:
Duplicate
is duplicated by ZBXNEXT-1707 add posibility Dropdown second entry Closed
is duplicated by ZBX-2405 No way to select 'All' hosts or hostg... Closed
is duplicated by ZBX-6780 Zabbix UI performance navigation impr... Closed
is duplicated by ZBX-7527 Monitoring -> Overview default to gro... Closed
is duplicated by ZBX-15492 maintenance.php - lost ability to sea... Closed

 Description   

The new option to not have ALL on drop downs is a HUGE HELP as loading pages with ALL set was killing us. But would like to have All option for some things. Now when we set option to "None" the default is Not Selected which is perfect, but then I can't select ALL when I want to, such as when searching for triggers or events, where ALL might make sense.

Ideally this is an option, such as:

Deafult: None, All, 1.6 Comp Mode
Include All: Y/N

Then when we are even larger, we'll turn off All for safety

There are also places in groups we want to select All, such as Monitor - Events; I want to select a group and then have ALL for hosts, but even the above is not granular enough - ideally some day can choose where "All" can appear, by screen or at least drop down (e.g. ALL in hosts, but not in groups).



 Comments   
Comment by richlv [ 2010 Aug 25 ]

pretty much the same as ZBX-2405

Comment by Andy Goldschmidt [ 2011 Sep 13 ]

yes, Please add the ALL option to the dropdown list - so we can select it.

Making this option available for each page would be great - So I have ALL selected by default for some pages (e.g. Monitoring -> Triggers) , but other pages have NONE selected by default (e.g. Monitoring -> Latest Data).

I am using Zabbix 1.8.

Comment by Pavol Kobylan [ 2013 Apr 12 ]

in some pages there will be good select ALL (trigers)
in others will be good select NONE - (latest data, events) - because of loading page takes too long

Best solution will be to have in dropdown menu both entry, ALL and also NONE, - I'm thinking - the best will be add new configuration value -
Administration - > General- > GUI - > Dropdown second entry and there will be the same values like in first dropdown, mayby with posibility not show - to have posibility show only first entry

Comment by Andrey Melnikov [ 2013 Apr 18 ]

Make this options configurable in user profile (or override system default).

Comment by Marc [ 2013 Oct 23 ]

Attached patch:
ZBXNEXT-370-2.0.9-4-NoneAll.patch

is a quick and dirty modification that adds an additional option to the 'Dropdown first entry' combobox.
The new option behaves like 'None' but offers 'All' for selection as well.

As a side effect hosts in host field are sorted by name if trigger belongs to multiple hosts.

Personally I like to keep the 'All' option for configuration sites. This can optionally achieved by:
ZBXNEXT-370-2.0.9-NoneAll-ConfigurationAll.patch

The setting can individually be overwritten easily.
E.g. enforcing 'None' in Monitoring->Overview can be achieved by:

--- /usr/share/zabbix/overview.php.orig 2013-10-12 15:51:53.000000000 +0200
+++ /usr/share/zabbix/overview.php      2013-10-23 17:34:10.000000000 +0200
@@ -66,7 +66,8 @@
                ($data['type'] == SHOW_TRIGGERS ? 'with_monitored_triggers' : 'with_monitored_items') => true
        ),
        'hostid' => get_request('hostid', null),
-       'groupid' => get_request('groupid', null)
+       'groupid' => get_request('groupid', null),
+       'config' => array('deny_all' => 1)
 ));
Comment by Marc [ 2013 Oct 27 ]

makes much more fun in connection with ZBXNEXT-1986

Comment by Marc [ 2013 Nov 13 ]

There was a visual flaw in ZBXNEXT-370-2.0.9-4-NoneAll.patch.
Hosts weren't sorted as expected and commas for separating hosts weren't always placed.

Attached patch ZBXNEXT-370-2.0.9-5-NoneAll.patch resolves that issue.

Edit:
Previously mentioned flaw exists in latest data as well.
The visual flaw is not the previous mentioned one. Instead it's the same as ZBX-7375. I'm looking forward to provide an updated version today.
Should be fixed in ZBXNEXT-370-2.0.9-6-NoneAll.patch

Comment by Marc [ 2013 Dec 22 ]

ZBXNEXT-1986-2.0.9-NoneAll-ConfigurationAll.patch should actually by named ZBXNEXT-370-2.0.9-NoneAll-ConfigurationAll.patch

Comment by Marc [ 2014 Apr 05 ]

Attached patch ZBXNEXT-370-2.2.2-2.patch ports "None/All" functionality to Zabbix 2.2.2.

This patch:

  • adds "None/All" functionality
  • implements support for "None/All" in Monitoring views
  • enforces "All" in Inventory and Configuration views when "None/All" is used
  • enforces "None" in Overview view

This patch is not tested very well yet and should be reviewed.

Some improvements included in patch for 2.0 are not considered yet.
E.g. behavior of 'None' (implicitly 'None/All') in connection with selective event hyperlinks. (for 'None/All' covered by ZBXNEXT-370-2.2.2-events.patch, see ZBX-6985 for related issue)

Attached patch ZBXNEXT-370-2.2.2-overview-app-only.patch prevents to show items from all applications when no application is set.

Comment by Marc [ 2014 Aug 23 ]

Attached patch zbxNext370-light.patch has nothing to do with the previous ZBXNEXT-370 patches but it addresses the same issue.

Recent versions of Zabbix became fast enough in all places except latest data and overview (at least for my environment).

This patch enforces dropdown first entry to 'None' in latest data and overview pages.
Additionally it gathers no data in overview page when no application is selected.
Having latest data combo-boxes enforced to 'None' can lead to issues when getting there by following hyper-links from other sites. This issues is addressed in the patch too.

Btw, the last mentioned issues is a general issue when using 'None' for combo-boxes and is not introduced by this patch.

Comment by Filipe Paternot [ 2017 Feb 02 ]

Hello,

anyone have a updated patch for this issue?

Comment by Nathan Little [ 2017 Oct 06 ]

Likewise, any update or solution to this for the current LTS version 3.0?

Comment by Stanislav [ 2019 Apr 01 ]

We are using global 'All' dropdown first entry and this patch to disable 'All' groups for overview page:

--- zabbix-4.0.5/frontends/php/overview.php     2019-02-25 12:36:40.000000000 +0300
+++ zabbix-4.0.5_/frontends/php/overview.php    2019-03-06 12:02:12.575566758 +0300
@@ -132,6 +132,9 @@
  * Display
  */
 $page_filter = new CPageFilter([
+       'config' => [
+               'deny_all' => true
+       ],
        'groups' => [
                ($type == SHOW_TRIGGERS ? 'with_monitored_triggers' : 'with_monitored_items') => true
        ],
Comment by Alexei Vladishev [ 2021 Oct 14 ]

I am closing this issue, Zabbix does not use drop-downs in latest 5.x releases anymore. Feel free to re-open if I missed something.

Generated at Sat Apr 20 16:34:50 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.