[ZBXNEXT-3926] Misleading {TRIGGER.STATUS} value in notifications Created: 2017 Jun 07  Updated: 2024 Apr 10  Resolved: 2017 Aug 30

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F), Server (S)
Affects Version/s: 3.2.5
Fix Version/s: 3.4.0rc2, 3.4 (plan)

Type: Change Request Priority: Minor
Reporter: Andris Zeila Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Sub-task
part of ZBXNEXT-18 Send an alert after trigger being ack... Closed
Team: Team A
Sprint: Sprint 9, Sprint 10, Sprint 11, Sprint 12, Sprint 13, Sprint 14, Sprint 15
Story Points: 3

 Description   

The {TRIGGER.STATUS} macro is used in default notifications to display the current status of the problem (trigger). This can be misleading in the case of multiple problem events and event correlation - the corresponding event might have been already resolved while trigger still having problem status.

To solve this we must:

  • change {EVENT.VALUE}, {EVENT.STATUS} macros to return problem value if the original event is still in problem state, and ok value if the original event has been resolved (this must work for trigger and internal events).
  • replace {TRIGGER.STATUS} with {EVENT.STATUS} in notifications

The {EVENT.RECOVERY.VALUE}, {EVENT.RECOVERY.STATUS} macros are pointless - they always returns OK value, so they can be marked as deprecated.

 Comments   
Comment by Viktors Tjarve [ 2017 Jul 18 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-3926

Comment by Viktors Tjarve [ 2017 Jul 26 ]

(3) [S] Structure DB_TRIGGER member value should be of type unsigned char very much like member type.

viktors.tjarve RESOLVED in r70625.

wiper CLOSED

Comment by Sergejs Paskevics [ 2017 Jul 31 ]

(4) [S] Please, check my change after merge r70728, r70732.

viktors.tjarve Commit r70728 is only done into ZBXNEXT-18 dev branch. No changes with that commit where made for this dev branch. Was that intended this way?

s.paskevics It is mistake not a r70728, but r70729

wiper CLOSED

Comment by Sergejs Paskevics [ 2017 Jul 31 ]

(5) [S] Please fix EVENT.STATUS in ack messages.
Steps:
1. Add acknowledgement configuration with sending mails;
2. Select problem with status ‘RESOLVED’ at Problem page;
3. Click ‘Bulk acknowledge’ button;
4. Add some message and click ‘Acknowledge’
5. Check ‘Action log’
Result: Message contain text: ‘Current trigger status is PROBLEM’
Expected: Message contain text: ‘Current trigger status is RESOLVED’

viktors.tjarve RESOLVED in r70913.

s.paskevics REOPENED. EVENT.* macros incorrectly substituted in ack messages and
ack commands.

s.paskevics RESOLVED in r70935.

wiper CLOSED

Comment by Alexander Vladishev [ 2017 Aug 11 ]

Frontend has been successfully tested with minor formatting in r71138 and Selenium tests fixes in r71145. Have a look.

Comment by Sergejs Paskevics [ 2017 Aug 17 ]

Implemented in 3.4.0rc2 (trunk) in r71362.

Generated at Fri Apr 26 09:00:56 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.