[ZBXNEXT-4127] Remake popup.php lists into overlayDialogue. Created: 2017 Sep 27  Updated: 2024 Apr 10  Resolved: 2017 Dec 19

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 4.0.0alpha1, 4.0 (plan)

Type: Change Request Priority: Trivial
Reporter: Valdis Murzins Assignee: Miks Kronkalns
Resolution: Fixed Votes: 0
Labels: overlay, popups
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Selection_061.png     PNG File Selection_078.png     PNG File Selection_080.png     PNG File Selection_082.png     PNG File Selection_083.png     PNG File Selection_085.png     PNG File Selection_156.png     PNG File Selection_157.png     PNG File Selection_158.png     PNG File Selection_177.png     PNG File media_encode.png     PNG File overlay-with-page-filter.png     PNG File overlay-without-page-filter.png    
Issue Links:
Causes
causes ZBX-13321 Improve overlay dialogue performace Open
causes ZBX-13221 Missed input trim for overlay forms Closed
causes ZBX-13240 Overlapping HTML id's on pages with p... Closed
Sub-task
depends on ZBX-12809 Blured overlay dialogues Closed
part of ZBXNEXT-4149 Keyboard popup interaction (Z4beta1) Closed
Epic Link: DEV-648
Team: Team A
Sprint: Sprint 18, Sprint 19, Sprint 20, Sprint 21, Sprint 22, Sprint 23
Story Points: 5

 Description   

Remake "Select" lists, that are opened in popup.php window to be opened in JS overlayDialogue() dialogue.



 Comments   
Comment by Miks Kronkalns [ 2017 Oct 10 ]

Acceptance criteria

  • in all places where popups was used in previous versions, now they are replaced by overlay dialog.
  • popups are limited in space using a scrollbar for content part. Overlay dialog resizes according to the actual amount of visible content.
  • requests are made and processed according Zabbix MVC principles.
  • popups are centered.

Decisions made

  • overlay dialogs are displayed one on the top of other if there are more than one visible dialog on the screen.
  • in scope of this task popup php files must be rewritten according to Zabbix MVC principles.

What's affected

  • Frontend

UI
Javascript function PopUp() should be rewritten in such a way that instead of opening requested URL in a new popup window, the request should be made by AJAX and response should be used as a content of overlay dialogue.

Popup filters are realized by whole content reload. This must be changed in this task - content changes must be loaded by AJAX only.

Currently we do not open popups from other popups. After changes, there will be multiple places (widget configuration dialogs, map elements etc) where overlay dialogs will be opened from other overlay dialogs. Here the second dialogs will be displayed on the top of the first dialog (this is an initial concept which could be changed later if looks bad).

jQuery.Deferred() must be implemented to deal with delayed responses. Dialog resizes once the content is loaded.

Translation strings
Translation strings should not be changed.

Documentation changes
No changes in documentation needed. Printscreens in documentation are made in such a way that only popup content without window attributes is visible. Popups are consequently called "popups" and reflects also to modal windows.

Comment by Miks Kronkalns [ 2017 Nov 03 ]

In same way as context menus and hint boxes, page refresh closing also overlay dialog (popup) window. Must decide how to fix that.

Comment by Miks Kronkalns [ 2017 Nov 08 ]

(1) When executing scripts (Ping, Traceroute etc), overlay dialog is opened just few seconds later because dialogues are opened only after ajax response is received, but since script execution can take several seconds, user is forced to wait without any indicator, that something is actually happening. There should be some preloader or some other indicator that activity is started.

Miks.Kronkalns RESOLVED in r74541

vmurzins CLOSED

Comment by Miks Kronkalns [ 2017 Nov 08 ]

(2) Check all checkbox is not working after overlay dialog content is reloaded (for example, if filter is used).

Miks.Kronkalns RESOLVED in main commit (r74525).

vmurzins CLOSED

Comment by Miks Kronkalns [ 2017 Nov 08 ]

(3) If text in overlay dialogue is very long, it is not wrapped into multiple lines, but continues as a single string. E.g., a text in item name column in key selection window (Configure -> Hosts -> Create item -> Key).

Miks.Kronkalns RESOLVED in r74542.

vmurzins CLOSED

Comment by Miks Kronkalns [ 2017 Nov 13 ]

RESOLVED in ^/branches/dev/ZBXNEXT-4127 r74525

Comment by Valdis Murzins [ 2017 Dec 19 ]

Fixed:

  • 4.0.0alpha1 (trunk) r76172
Generated at Thu Apr 25 19:35:21 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.