[#ZBXNEXT-4144] Mark required fields in form

[ZBXNEXT-4144] Mark required fields in form Created: 2017 Oct 03 Updated: 2024 Apr 10 Resolved: 2018 Jan 28
Status:	Closed
Project:	ZABBIX FEATURE REQUESTS
Component/s:	Frontend (F)
Affects Version/s:	None
Fix Version/s:	4.0.0alpha2, 4.0 (plan)

Type:

Change Request

Priority:

Trivial

Reporter:

Valdis Murzins

Assignee:

Gregory Chalenko

Resolution:

Fixed

Votes:

Labels:

forms, required

Remaining Estimate:

Not Specified

Time Spent:

Not Specified

Original Estimate:

Not Specified

Attachments:

MissleadingComment.PNG

Selection_144.png

Selection_145.png

Selection_146.png

Selection_148.png

Selection_150.png

Selection_155.png

Selection_159.png

Selection_162.png

Selection_164.png

Selection_165.png

Selection_166.png

Selection_167.png

Selection_168.png

Selection_169.png

Selection_170.png

Selection_171.png

Selection_172.png

Selection_173.png

Selection_174.png

Selection_176.png

Selection_184.png

Selection_192.png

Selection_193.png

Selection_194.png

media_password.png

missing-border.png

required_fields.png

Issue Links:

Sub-task
part of	~~ZBXNEXT-4152~~	Replace double box select field with ...	Closed

Epic Link:

DEV-648

Team:

Team B

Sprint:

Sprint 18, Sprint 19, Sprint 20, Sprint 21, Sprint 22, Sprint 23, Sprint 24, Sprint 25, Sprint 26

Story Points:

Description

All required fields in forms should have * symbol at it's label.
All required fields should be marked with aria-required="true".

Comments

Comment by Gregory Chalenko [ 2017 Oct 25 ]

(1) Translation strings changes
Strings added:

At least one %1$s must be selected.
At least one %1$s must exist.
host or host group
interface
operation, recovery operation or acknowledge operation
user or user group

iivs I don't think it's a good idea to pass another translation string as parameter. It's not a field name like in other places. The resulting sentence could end up sounding strange in another language.

REOPENED

gcalenko RESOLVED
Strings added:

At least one host or host group must be selected.
At least one interface must exist.
At least one operation must exist.
At least one operation or recovery operation must exist.
At least one operation, recovery operation or acknowledge operation must exist.
At least one user or user group must be selected.

iivs CLOSED

Comment by Gregory Chalenko [ 2018 Jan 04 ]

Implemented in:

4.0.0alpha2 trunk r76586

Comment by Marc [ 2018 Jan 09 ]

The comment seems not suitable for the Action tab:

Further, what is the rule to whether or not a comment referring to the asterisk is deposited?

gcalenko Comment is shown for "Action" tab to inform that there are no possibility to add action without operations. Asterisk is placed before comment to visually highlight requirement that at least one operation should be added.

Mostly this comment was added to allow users with screen reader software to have additional clue what should be done to be able to create/update action.

Comment by Gregory Chalenko [ 2018 Jan 23 ]

Updated API changes page.

Comment by Gregory Chalenko [ 2018 Jan 23 ]

Fixed in:

4.0.0alpha3 (trunk) r77120

Generated at Tue Apr 23 23:30:45 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.

[ZBXNEXT-4144] Mark required fields in form Created: 2017 Oct 03 Updated: 2024 Apr 10 Resolved: 2018 Jan 28