[ZBXNEXT-4458] Make Zabbix Java Gateway logs more human-friendly Created: 2018 Mar 29  Updated: 2024 Apr 10  Resolved: 2018 Jul 11

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Java gateway (J)
Affects Version/s: 4.0.0alpha3
Fix Version/s: 4.0.0alpha6, 4.0 (plan)

Type: Change Request Priority: Trivial
Reporter: Aleksejs Petrovs Assignee: Vjaceslavs Bogdanovs
Resolution: Fixed Votes: 0
Labels: javagateway, logging
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by ZBXNEXT-2399 Catch exceptions in Zabbix java gatew... Closed
is duplicated by ZBX-13675 errors log for Zabbix Java Gateway co... Closed
Team: Team C
Sprint: Sprint 31, Sprint 32, Sprint 38
Story Points: 1

 Description   

Please make Zabbix Java Gateway logs more human-friendly(debug level: info) because right now Zabbix Java Gateway provides a lot of unnecessary information making it hard to troubleshoot.

Examples:
invalid username and password nullness combination

2018-03-29 05:42:46.551 [pool-1-thread-3] WARN  com.zabbix.gateway.SocketProcessor - error processing request
com.zabbix.gateway.ZabbixException: java.lang.IllegalArgumentException: invalid username and password nullness combination
        at com.zabbix.gateway.JMXItemChecker.<init>(JMXItemChecker.java:71) ~[zabbix-java-gateway-4.0.0alpha3.jar:na]
        at com.zabbix.gateway.SocketProcessor.run(SocketProcessor.java:58) ~[zabbix-java-gateway-4.0.0alpha3.jar:na]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [na:1.8.0_161]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [na:1.8.0_161]
        at java.lang.Thread.run(Thread.java:748) [na:1.8.0_161]
Caused by: java.lang.IllegalArgumentException: invalid username and password nullness combination
        at com.zabbix.gateway.JMXItemChecker.<init>(JMXItemChecker.java:67) ~[zabbix-java-gateway-4.0.0alpha3.jar:na]
        ... 4 common frames omitted

Connection refused

2018-03-29 05:52:21.924 [pool-1-thread-1] WARN  com.zabbix.gateway.SocketProcessor - error processing request
com.zabbix.gateway.ZabbixException: java.net.ConnectException: Connection refused
        at com.zabbix.gateway.JMXItemChecker.getValues(JMXItemChecker.java:98) ~[zabbix-java-gateway-4.0.0alpha3.jar:na]
        at com.zabbix.gateway.SocketProcessor.run(SocketProcessor.java:63) ~[zabbix-java-gateway-4.0.0alpha3.jar:na]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [na:1.8.0_161]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [na:1.8.0_161]
        at java.lang.Thread.run(Thread.java:748) [na:1.8.0_161]
Caused by: java.net.ConnectException: Connection refused
        at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) ~[na:1.8.0_161]
        at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) ~[na:1.8.0_161]
        at org.xnio.nio.WorkerThread$ConnectHandle.handleReady(WorkerThread.java:327) ~[jboss-client.jar:11.0.0.Final]
        at org.xnio.nio.WorkerThread.run(WorkerThread.java:591) ~[jboss-client.jar:11.0.0.Final]
        at ...asynchronous invocation...(Unknown Source) ~[na:na]
        at org.jboss.remoting3.EndpointImpl.connect(EndpointImpl.java:570) ~[jboss-client.jar:11.0.0.Final]
        at org.jboss.remoting3.EndpointImpl.connect(EndpointImpl.java:532) ~[jboss-client.jar:11.0.0.Final]
        at org.jboss.remoting3.EndpointImpl.connect(EndpointImpl.java:520) ~[jboss-client.jar:11.0.0.Final]
        at org.jboss.remotingjmx.RemotingConnector.internalRemotingConnect(RemotingConnector.java:268) ~[jboss-client.jar:11.0.0.Final]
        at org.jboss.remotingjmx.RemotingConnector.internalConnect(RemotingConnector.java:156) ~[jboss-client.jar:11.0.0.Final]
        at org.jboss.remotingjmx.RemotingConnector.connect(RemotingConnector.java:103) ~[jboss-client.jar:11.0.0.Final]
        at javax.management.remote.JMXConnectorFactory.connect(JMXConnectorFactory.java:270) ~[na:1.8.0_161]
        at com.zabbix.gateway.ZabbixJMXConnectorFactory$1.run(ZabbixJMXConnectorFactory.java:76) ~[zabbix-java-gateway-4.0.0alpha3.jar:na]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[na:1.8.0_161]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[na:1.8.0_161]
        ... 3 common frames omitted
 


 Comments   
Comment by Marc [ 2018 Apr 04 ]

Similar to ZBXNEXT-2399

Comment by richlv [ 2018 Apr 09 ]

Marc, indeed - could be even considered a duplicate

Comment by Vjaceslavs Bogdanovs [ 2018 Apr 16 ]

Available in:

4.0.0alpha6 (trunk) r79731

Comment by richlv [ 2018 Jun 18 ]

This was closed as fixed without a single comment - is it safe to assume that the changes went in 4.0.0alpha6 as per the "fix version" field?

palivoda: Yes. Published dev comment for your safety. 7 watchers and 0 votes. 

Comment by richlv [ 2018 Jun 18 ]

(1) Looks like the change has been mentioned in the upgrade notes, which is great.

Given that the logs are much more readable now, that is worth mentioning in what's new.

martins-v Added to what's new.

Generated at Sat Apr 27 05:25:19 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.