[ZBXNEXT-4696] Optimize history cache processing by performing trigger locking outside history cache lock Created: 2018 Aug 23 Updated: 2024 Apr 10 Resolved: 2018 Sep 03 |
|
Status: | Closed |
Project: | ZABBIX FEATURE REQUESTS |
Component/s: | Server (S) |
Affects Version/s: | None |
Fix Version/s: | 4.0.0beta2, 4.0 (plan) |
Type: | Change Request | Priority: | Trivial |
Reporter: | Andris Zeila | Assignee: | Andris Zeila |
Resolution: | Fixed | Votes: | 0 |
Labels: | None | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified |
Attachments: | dbcache.diff dbsyncer_perf.diff |
Team: | Team A |
Sprint: | Sprint 41 |
Story Points: | 1 |
Description |
During history cache synchrinization server locks configuration cache within history cache lock. The processing is like:
It's possible to get rid of lock nesting by moving trigger locking outside history cache lock, somthing like:
Testing showed ~21% throughput (values per second) increase in data processing. The test patch is attached however it can be improved (hc_push_busy_items and hc_push_processed_items could be merged in one function). |
Comments |
Comment by Andris Zeila [ 2018 Aug 28 ] |
Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-4696 |
Comment by Andris Zeila [ 2018 Aug 31 ] |
Released in:
|
Comment by richlv [ 2018 Aug 31 ] |
The target version comment seems to be missing, as this has been merged already. BTW, is Zabbix team still following the convention to put that comment in issues? |
Comment by Andris Zeila [ 2018 Sep 03 ] |
Sorry, speaking about myself - I keep forgetting to make 'released' comment public :/ |
Comment by richlv [ 2018 Sep 14 ] |
Andri, thank you for the useful comments - when they are seen by anybody (community still mourning open communication). |