Final fix for {ITEM.LASTVALUE1} in Monitoring–>Problems as a live view (ZBXNEXT-4942)

[ZBXNEXT-5482] Merge problems and opdata column in problems widget (patch) Created: 2019 Oct 03  Updated: 2021 Aug 20  Resolved: 2019 Oct 28

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 4.4.0rc1, 4.4 (plan)

Type: Change Request (Sub-task) Priority: Trivial
Reporter: Rostislav Palivoda Assignee: Alexander Shubin
Resolution: Fixed Votes: 7
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File opdat_1.png     PNG File opdat_code.png     PNG File opdata_2.png    
Team: Team D
Team: Team D
Sprint: Sprint 56 (Sep 2019), Sprint 55 (Aug 2019), Sprint 54 (Jul 2019), Sprint 57 (Oct 2019)
Story Points: 0.5

 Description   

 

"Show operational data" will be extended to radio button "None | Separately | With problem name"

  1. None: no opdata is displayed anywhere
  2. Separately: in a separate column as it is implemented now
  3. Next to problem name: non-empty opdata will be added to problem name like "<problem name> (<opdata>)".

Here is a patch for inspiration: 

https://gist.github.com/CHERTS/4fa1fa47c8caab68e52c4de2216d4c84

 



 Comments   
Comment by richlv [ 2019 Oct 03 ]

Rostislav, sorry if I'm misunderstanding something here - but this seems to be nearly useless, and totally not what users have been asking for a year.
Is there a miscommunication here, perhaps?

palivoda Please check settings option 3.

Comment by Alexander Shubin [ 2019 Oct 03 ]

Available in:

Comment by alix [ 2019 Oct 03 ]

It's interesting indeed how ability to replace the dashboard's problems list problem column with opdata column transformed into appending opdata to problem name.
Sorry for possibly breaking the commenting rules but this is not good.

Comment by bunkzilla [ 2019 Oct 03 ]

I just looked at this and I like the change!  Thank you!

 

Comment by dimir [ 2019 Oct 04 ]

Yes, 4.4.0rc1 packages are available, feel free to try.

Comment by Craig Hopkins [ 2019 Oct 04 ]

Where has this been integrated and how do I set it?

Comment by Mikhail Grigorev [ 2019 Oct 04 ]

It turns out that you rigidly indicated in the code that opdata will be in brackets (hardcoded -> ' (', $opdata, ')' ), I would prefer the user to decide how he wants to see Opdata (in () or in [] or without brackets at all)

Comment by Mikhail Grigorev [ 2019 Oct 04 ]

Please remove the brackets, let the user decide what the display format for opdata will be.

or

Comment by Frater [ 2019 Oct 04 ]

I didn't notice this immediately because I often use brackets myself around the live data.

Indeed...

I agree with Mikhael that it's not Zabbix's task to put brackets around them or not.

 

Comment by Jim [ 2019 Oct 04 ]

I agree with Frater and Mikhail, the user should be able to choose the formating.

And also, as alix said, a fourth option to choose to display op. data only instead of the problem name should be added to the UI if possible.

Thank you again for listening to the community users!

Comment by Frater [ 2019 Oct 06 ]

Hi Jim...

Why would you want the latter (only live data)?
I'm guessing you then want to keep the "problem name" empty and have complete freedom to format the sentence displayed starting it with live data.

I don't mind the division really. I keep the first part short and elaborate in the 2nd part.

Comment by dimir [ 2019 Oct 07 ]

frater, you can't have empty Trigger name, it's mandatory field.

Comment by Alexander Shubin [ 2019 Oct 08 ]

Updated documentation:

  • What's new
  • Problems (updated column description, new section on op data, updated filter option and filter screenshot)
  • Problem widget (updated config option and config screenshot)
Comment by Jim [ 2019 Oct 10 ]

Hi Frater,

I would want only live data for the ease of use, and the ease of writing triggers, and because the dashboard is designed for that in my mind.

It may be complicated when rewriting triggers to every time "compose" the static field and op. data field, but if only op. data can be displayed, It's easier because you only have to write up new op. data field and not do a composite of both
 

Comment by richlv [ 2019 Oct 12 ]

Rostislav, thank you for the clarification.
The confusing thing is the inability to choose which field to display (without combining them in an arbitrary way).
Reading through the comments in ZBXNEXT-4792 and ZBXNEXT-4942 , it seemed obvious that users wanted to have a choice between those two options. Perhaps I misread that.

Comment by Jim [ 2019 Oct 12 ]

@richlv It's exactly that. Both (like it is now) /Only Name / Only op. data / Merge if not empty
 

Comment by Mikhail Grigorev [ 2019 Oct 14 ]

Hi all,
i created a small patch for 4.4.0 removing the brackets from the operational data

cd zabbix-4.4.0
wget https://gist.githubusercontent.com/CHERTS/62b8ab8d5f87b7056595766efb5c53a4/raw/zbx_440_opdata_remove_bracket.patch
patch -p0 < zbx_440_opdata_remove_bracket.patch
Comment by richlv [ 2019 Oct 14 ]

Jim, "only op data" does not seem to be possible.

Comment by Ronald Schaten [ 2019 Oct 14 ]

I upgraded a test environment to 4.4, and so far I like what I see.

Just one small question (may be stupid): can I preselect my choice of "Show operational data"? I'd like it to be always "Separately". Everytime I reset the problem view it switches back to "None". I reset the view after extensive filter operations, and now I always have to chose "Separately" Everytime.

I feel like there must be some kind of configurable default setting, but I can't find anything...?

Comment by Frater [ 2019 Oct 18 ]

@Jim

I just had to change a trigger where it indeeds becomes awkward if you are obliged to use both fields for display.

It becomes hard to explain.
In short I agree that there should be the possibility to "only display opdata"

@richlv

I haven't looked at the code, but it strikes me as strange if that's not possible.

Comment by user185953 [ 2021 Aug 20 ]

Retrospectively I am glad there is no "only display opdata" option.

Being forced to split my problem names into separate static a and live parts was really annoying... but:

Originally I used to have triggers just like "tank level is 300". Now have triggers like "tank level too high: 300".

 

And I really like this clean separation.

Not just because there is search for when a lot goes wrong at the same time,

but also for forcing motivating good practice in problem names. Thank you!

Generated at Fri Apr 19 07:33:59 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.