trunk@5238, ZBX-251 applied

patch file

Added specification: https://www.zabbix.org/wiki/Docs/specs/ZBXNEXT-734

RESOLVED in svn://svn.zabbix.com/branches/dev/ZBXNEXT-734

(1) frontends/php/include/classes/screens/CScreenUrl.php

In this place $this->hostid variable can be null.

$url = CMacrosResolverHelper::resolveScreenElementURL(array(
    $this->hostid => array(
        'url' => $this->screenitem['url']
    )
));

iivs To avoid this problem, I made so $this->hostid is 0 by default.
RESOLVED in r45595

sasha CLOSED

(2) SQL errors when screen doesn't have dynamic elements

• Monitoring -> Screens:

  pg_query(): Query failed: ERROR:  invalid input syntax for integer: ""
  LINE 1: SELECT h.hostid,h.name,h.host FROM hosts h WHERE h.hostid=''
                                                                    ^ [screens.php:176 → CView->render() → include() → CScreenBuilder->show() → CScreenUrl->get() → CMacrosResolverHelper::resolveScreenElementURL() → CMacrosResolver->resolve() → CMacrosResolver->resolveTexts() → DBselect() → pg_query() in include/db.inc.php:384]
  Error in query [SELECT h.hostid,h.name,h.host FROM hosts h WHERE h.hostid=''] [ERROR:  invalid input syntax for integer: ""
  LINE 1: SELECT h.hostid,h.name,h.host FROM hosts h WHERE h.hostid=''
                                                                    ^]
  pg_query(): Query failed: ERROR:  invalid input syntax for integer: ""
  LINE 1: ...type FROM interface i WHERE i.main=1 AND i.hostid='' AND i.t...
                                                               ^ [screens.php:176 → CView->render() → include() → CScreenBuilder->show() → CScreenUrl->get() → CMacrosResolverHelper::resolveScreenElementURL() → CMacrosResolver->resolve() → CMacrosResolver->resolveTexts() → DBselect() → pg_query() in include/db.inc.php:384]
  Error in query [SELECT i.hostid,i.ip,i.dns,i.useip,i.type FROM interface i WHERE i.main=1 AND i.hostid='' AND i.type IN ('1','2','3','4')] [ERROR:  invalid input syntax for integer: ""
  LINE 1: ...type FROM interface i WHERE i.main=1 AND i.hostid='' AND i.t...
                                                               ^]
  pg_query(): Query failed: ERROR:  invalid input syntax for integer: ""
  LINE 1: ... FROM hosts h WHERE h.flags IN (0,4) AND h.hostid='' AND h.s...
                                                               ^ [screens.php:176 → CView->render() → include() → CScreenBuilder->show() → CScreenUrl->get() → CMacrosResolverHelper::resolveScreenElementURL() → CMacrosResolver->resolve() → CMacrosResolver->resolveTexts() → CMacrosResolverGeneral->getUserMacros() → CFrontendApiWrapper->get() → CApiWrapper->__call() → CFrontendApiWrapper->callMethod() → CApiWrapper->callMethod() → CFrontendApiWrapper->callClientMethod() → CLocalApiClient->callMethod() → call_user_func_array() → CHost->get() → DBselect() → pg_query() in include/db.inc.php:384]
  Error in query [SELECT   h.hostid FROM hosts h WHERE h.flags IN (0,4) AND h.hostid='' AND h.status IN (0,1,3)] [ERROR:  invalid input syntax for integer: ""
  LINE 1: ... FROM hosts h WHERE h.flags IN (0,4) AND h.hostid='' AND h.s...
                                                               ^]
  

• Monitoring -> Screens (Slide shows):

  pg_query(): Query failed: ERROR:  invalid input syntax for integer: ""
  LINE 1: SELECT h.hostid,h.name,h.host FROM hosts h WHERE h.hostid=''
                                                                    ^ [slides.php:110 → CScreenBuilder->show() → CScreenUrl->get() → CMacrosResolverHelper::resolveScreenElementURL() → CMacrosResolver->resolve() → CMacrosResolver->resolveTexts() → DBselect() → pg_query() in include/db.inc.php:384]
  Error in query [SELECT h.hostid,h.name,h.host FROM hosts h WHERE h.hostid=''] [ERROR:  invalid input syntax for integer: ""
  LINE 1: SELECT h.hostid,h.name,h.host FROM hosts h WHERE h.hostid=''
                                                                    ^]
  pg_query(): Query failed: ERROR:  invalid input syntax for integer: ""
  LINE 1: ...type FROM interface i WHERE i.main=1 AND i.hostid='' AND i.t...
                                                               ^ [slides.php:110 → CScreenBuilder->show() → CScreenUrl->get() → CMacrosResolverHelper::resolveScreenElementURL() → CMacrosResolver->resolve() → CMacrosResolver->resolveTexts() → DBselect() → pg_query() in include/db.inc.php:384]
  Error in query [SELECT i.hostid,i.ip,i.dns,i.useip,i.type FROM interface i WHERE i.main=1 AND i.hostid='' AND i.type IN ('1','2','3','4')] [ERROR:  invalid input syntax for integer: ""
  LINE 1: ...type FROM interface i WHERE i.main=1 AND i.hostid='' AND i.t...
                                                               ^]
  pg_query(): Query failed: ERROR:  invalid input syntax for integer: ""
  LINE 1: ... FROM hosts h WHERE h.flags IN (0,4) AND h.hostid='' AND h.s...
                                                               ^ [slides.php:110 → CScreenBuilder->show() → CScreenUrl->get() → CMacrosResolverHelper::resolveScreenElementURL() → CMacrosResolver->resolve() → CMacrosResolver->resolveTexts() → CMacrosResolverGeneral->getUserMacros() → CFrontendApiWrapper->get() → CApiWrapper->__call() → CFrontendApiWrapper->callMethod() → CApiWrapper->callMethod() → CFrontendApiWrapper->callClientMethod() → CLocalApiClient->callMethod() → call_user_func_array() → CHost->get() → DBselect() → pg_query() in include/db.inc.php:384]
  Error in query [SELECT   h.hostid FROM hosts h WHERE h.flags IN (0,4) AND h.hostid='' AND h.status IN (0,1,3)] [ERROR:  invalid input syntax for integer: ""
  LINE 1: ... FROM hosts h WHERE h.flags IN (0,4) AND h.hostid='' AND h.s...
                                                               ^]
  

iivs MySQL was working, but I observed this on PostgreSQL and it's related to (1) when $this->hostid is null.
RESOLVED in r45595

sasha CLOSED

(3) If "Dynamic item" was not selected, only global macros should be expanded.

iivs RESOLVED in r45595

sasha CLOSED

(4) Invalid pattern: '

'. The dot should be escaped.

iivs RESOLVED in r45595

sasha CLOSED

Implemented in pre-2.3.0 (trunk) r45640

(5) Documentation needs to be updated.

martins-v Updated:

• https://www.zabbix.com/documentation/2.4/manual/introduction/whatsnew240#url_as_dynamic_screen_element
• https://www.zabbix.com/documentation/2.4/manual/config/visualisation/screens#dynamic_elements
• https://www.zabbix.com/documentation/2.4/manual/appendix/macros/supported_by_location

RESOLVED.

iivs REVIEWED.
Thanks!
CLOSED.

(6) "Undefined index" on history screen:

Undefined index: screenid [ in /home/sasha/zabbix-svn/trunk/frontends/php/jsrpc.php:208]
array_flip(): Can only flip STRING and INTEGER values! [jsrpc.php:210 → CFrontendApiWrapper->get() → CApiWrapper->__call() → CFrontendApiWrapper->callMethod() → CApiWrapper->callMethod() → CFrontendApiWrapper->callClientMethod() → CLocalApiClient->callMethod() → call_user_func_array() → CTemplateScreen->get() → dbConditionInt() → array_flip() in /home/sasha/zabbix-svn/trunk/frontends/php/include/db.inc.php:850]
pg_query(): Query failed: ERROR:  syntax error at end of input
LINE 1: ...emplateid FROM screens s WHERE s.templateid IS NOT NULL AND 
                                                                       ^ [jsrpc.php:210 → CFrontendApiWrapper->get() → CApiWrapper->__call() → CFrontendApiWrapper->callMethod() → CApiWrapper->callMethod() → CFrontendApiWrapper->callClientMethod() → CLocalApiClient->callMethod() → call_user_func_array() → CTemplateScreen->get() → DBselect() → pg_query() in /home/sasha/zabbix-svn/trunk/frontends/php/include/db.inc.php:384]
Error in query [SELECT   s.screenid,s.templateid FROM screens s WHERE s.templateid IS NOT NULL AND ] [ERROR:  syntax error at end of input
LINE 1: ...emplateid FROM screens s WHERE s.templateid IS NOT NULL AND 
                                                                       ^]

iivs RESOLVED in svn://svn.zabbix.com/branches/dev/ZBXNEXT-734 r45700

sasha CLOSED

(7) As discussed, I moved templated screen request for URL elements from jsrpc to screenBuilder::getScreen()

see r45773

sasha CLOSED

Fixed undefined indexes, SQL errors and moved screen.get out of jsrpc.

Fixed in pre-2.3.0 (trunk) r45801