Related forum thread: http://www.zabbix.com/forum/showthread.php?t=13047

Currently the dsn, user, password and sql are stored in items table params field (Additional parameters field in frontend).

It was decided to change how the ODBC data (dsn,user,password,sql) are stored:

1. store dsn in item key as the second parameter: db.odbc.select[<unique short description>,<dsn>]
2. store user,password in items table username,password fields
3. store sql in items table params field

(1) [S] server changes

1. assemble ODBC query from the key_, user, password and params fields
2. create database patch to convert old database monitoring items to the new format

wiper RESOLVED in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-817 r37633

sasha CLOSED

(2) [F] frontend changes

Add the required fields (username,password) to database monitor item form, rename the 'Additional parameters' field to 'SQL query' and read/store the field data in respective items table fields.

jelisejev Fields username and password must be optional.

iivs RESOLVED in svn://svn.zabbix.com/branches/dev/ZBXNEXT-817 r37750

sasha CLOSED

(3) Documentation update

1. https://www.zabbix.com/documentation/2.2/manual/introduction/whatsnew220
2. https://www.zabbix.com/documentation/2.2/manual/installation/upgrade_notes_220
3. https://www.zabbix.com/documentation/2.2/manual/config/items/itemtypes/odbc_checks

wiper updated upgrade notes, please review.

<richlv> let's also have an example of the error message that would be written in the logfile

wiper added, ugly ones though

<richlv> example messages are there, CLOSED

wiper not sure if something should be added to whatsnew, as the database monitoring was unofficial feature and the upgrade procedure is covered in upgrade notes, but the database monitoring item documentation must be updated with new example.

wiper updated also whatsnew, database monitoring item description. Please review

<richlv> thanks, seems ok to me -> CLOSED

please consider removing iodbc support at the same time, see ZBX-6852

wiper i don't think we have iodbc specific support in code, only in makefiles to link appropriate library. Then it's better handled separately.

(4) src/zabbix_server/poller/poller.c:664

• substutute_simple_macros() function is called twice for SSH and TELNET items.
• should be set 5th argument (hostid) for MACRO_TYPE_COMMON macros

wiper RESOLVED in r37696

sasha CLOSED

(5) src/zabbix_server/poller/checks_db.c:66

• it would be better to use the new parse_item_key() and free_request() functions

wiper RESOLVED in r37701

sasha REVIEWED.

Please review my changes in r37712:37713.

wiper CLOSED

(6) parse_db_monitor_item_params() function

• "pnext = strchr(params, '\n');" - better use "pvalue" as first parameter
• function doesn't properly handle lines like "=" or "<key>=" or "=<value>"

wiper RESOLVED in r37699

sasha CLOSED

(7) DBpatch_2010094() function

• The second parameter (DSN) should be quoted if it contains the special symbols. You can use quote_key_param() function.
• Initially, item key can contain more than one parameter. All this shall be quoted if needed.

wiper RESOLVED in r37715

sasha REVIEWED

Please review my changes in r37726 and r37852.

wiper CLOSED

(8) [A] Documentation update:

• https://www.zabbix.com/documentation/2.2/manual/api/reference/item/object
• https://www.zabbix.com/documentation/2.2/manual/api/reference/itemprototype/object
• https://www.zabbix.com/documentation/2.2/manual/api/reference/discoveryrule/object
• https://www.zabbix.com/documentation/2.2/manual/api/changes_2.0_-_2.2

iivs RESOLVED

sasha CLOSED

(10) [F] please review my changes in r37854.

iivs REVIEWED.
CLOSED.

(11) [F] please add support of DB Monitor lld-rules

iivs RESOLVED in r37865

sasha REOPENED "Warning. Incorrect value for field "type"." when trying to save "Database monitor" discovery rule.

iivs RESOLVED in r37869

sasha CLOSED

(12) [A] Documentation update (support of item types):

• https://www.zabbix.com/documentation/2.2/manual/api/changes_2.0_-_2.2#discoveryrule
• https://www.zabbix.com/documentation/2.2/manual/api/reference/item/object
• https://www.zabbix.com/documentation/2.2/manual/api/reference/itemprototype/object
• https://www.zabbix.com/documentation/2.2/manual/api/reference/discoveryrule/object

sasha RESOLVED

iivs CLOSED

Frontend is successfully tested!

Relased in:
pre-2.1.3 r37916

Reopening to finish documentation update