Redesign forms to MVC rails and migrate javascript from Prototype to jQuery (ZBXNEXT-870)

[ZBXNEXT-904] Redesign Configuration->Screens Created: 2011 Aug 24  Updated: 2017 May 31  Resolved: 2012 Mar 13

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 2.0.0

Type: Change Request (Sub-task) Priority: Minor
Reporter: Eduards Samersovs (Inactive) Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: screens
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File history_not_visible.png     PNG File history_visible.png     PNG File screen_element_selection.png    
Issue Links:
Duplicate
is duplicated by ZBX-1204 screen deletion not registered on the... Closed
is duplicated by ZBX-4702 Dynamic item missing in the exported ... Closed
is duplicated by ZBX-1841 screen and slideshow editing problems 2 Closed
is duplicated by ZBX-1946 row and column span in screens exceed... Closed
is duplicated by ZBX-2725 polish editing of screens Closed
is duplicated by ZBX-4604 Cannot add screen on screen Closed
is duplicated by ZBX-4649 Editing screen doesn't work properly ... Closed
is duplicated by ZBX-1213 column span for screen element lower ... Closed

 Description   

Edit form and screen visual constructor



 Comments   
Comment by Eduards Samersovs (Inactive) [ 2012 Feb 24 ]

Implemented in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-904

Comment by Alexey Fukalov [ 2012 Mar 01 ]

(1) [GUI]
Js error In ie8 after any element drag.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Mar 01 ]

(2) [GUI]
Have one element in row, edit it, move it to another row, try to delete now empty row, alert appears with warning that row is not empty.
Probably that caused because element moving is done with ajax, but alerts are attached on page refresh.

<Eduard> CLOSED. Moved to ZBXNEXT-1140

Comment by Alexey Fukalov [ 2012 Mar 01 ]

(3) [GUI]
Now rowspan and colspan cannot be 0, but it was allowed before, so now it show errors when update element on old screens. Maybe db patch should be added.

also even if we set rowspan/colspan to 1, but then move element to another empty cell, they are set to 0.

<Eduard> RESOLVED, Reverted validation on rowspan and colspan.. allow 0 values.

<richlv> dev branch rev 25776. attempting to save screen element with 0/0 colspans still fails :

Warning. Incorrect value for field "colspan".
Warning. Incorrect value for field "rowspan".

also the mentioned reseting of span from 1 to 0 is still there

<Eduard> Retry Now

<Vedmak> rowspan/colspan still resets to 0 if we move element with rowspan/colspan 1.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Mar 01 ]

(4) [GUI]
Cannot switch screen elements places if they have aligned not to center/middle.

<Eduard> RESOLVED

<Vedmak> now when you switch element with places, alignment is not switched.

<Eduard> CLOSED. Moved to ZBXNEXT-1140

Comment by Alexey Fukalov [ 2012 Mar 01 ]

(5) [GUI]
In screen element "Server info" remove row with "refresh now" link, and make link to zabbix server status to be shown only for super admins.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Mar 01 ]

(6) [GUI]
Now we cannot switch screen elements coordinates via API.

<Eduard> RESOLVED

<Vedmak> let's better separate validation to methods instead of long additional options to one method

<Vedmak> CLOSED

Comment by richlv [ 2012 Mar 03 ]

(7) server info element doesn't seem to have "Vertical align" options styled like the other screen elements

hmm, this seems to depend either on other elements/their layout or editing sequence, can't reproduce reliably... CLOSED for now

Comment by richlv [ 2012 Mar 03 ]

(8)

[03/03/2012 05:57:58 AM] JavaScript - http://localhost:8883/dev/ZBXNEXT-904/screenedit.php?screenid=5&sid=96e83c42e664b647
Event thread: DOMContentLoaded
Uncaught exception: TypeError: 'jqBlink.init' is not a function
Error thrown at line 6, column 0 in <anonymous function>() in http://localhost:8883/dev/ZBXNEXT-904/screenedit.php?screenid=5&sid=96e83c42e664b647:
jqBlink.init();
called via Function.prototype.apply() from line 4978, column 29466 in <anonymous function: f.Callbacks>(b, f) in http://localhost:8883/dev/ZBXNEXT-904/jsLoader.php?ver=1.9.10&lang=en_GB:
if(c[l].apply(b,f)===!1&&a.stopOnFalse)
called from line 4978, column 31004 in <anonymous function: fireWith>(b, c) in http://localhost:8883/dev/ZBXNEXT-904/jsLoader.php?ver=1.9.10&lang=en_GB:
d&&(i?a.once||d.push([b,c])!a.once||!e)&&n(b,c));
called from line 4978, column 19394 in <anonymous function: ready>(a) in http://localhost:8883/dev/ZBXNEXT-904/jsLoader.php?ver=1.9.10&lang=en_GB:
A.fireWith(c,[e]),e.fn.trigger&&e(c).trigger("ready").off("ready")
called from line 4978, column 28585 in <anonymous function: B>() in http://localhost:8883/dev/ZBXNEXT-904/jsLoader.php?ver=1.9.10&lang=en_GB:
c.removeEventListener("DOMContentLoaded",B,!1),e.ready()

<Eduard> It's a different issue, after merging from upstream problem resolves.

Comment by richlv [ 2012 Mar 03 ]

(9) adding history of events seems to break screen configuration.
a) it is not possible to drag any cell contents anymore;
b) other elements (in this case, graphs) do not appear at all

see the screenshot. while event history element is being edited (thus history itself is not visible), elements can be seen and dragged.
when history is visible, other elements disappear and history or empty cells can't be dragged anymore

https://support.zabbix.com/secure/attachment/18293/history_not_visible.png
https://support.zabbix.com/secure/attachment/18294/history_visible.png

<Eduard> Same es (8) It's a different issue, move to ZBX-4730

Comment by richlv [ 2012 Mar 03 ]

(10) if screen does not fit horizontally in the browser window, 'select' button for the element (while editing it) is wrapped and the input field bleeds over other columns

https://support.zabbix.com/secure/attachment/18295/screen_element_selection.png

<Eduard> CLOSED. Moved to ZBXNEXT-1140

Comment by Eduards Samersovs (Inactive) [ 2012 Mar 05 ]

trunk r.25808 version pre-1.9.10

Comment by richlv [ 2012 Mar 12 ]

(11)
$ svn diff -c 25808 frontends/php/include/locales/en_gb.inc.php | grep S_ALREADY_EXISTS_SMALL

  • 'S_ALREADY_EXISTS_SMALL'=> _('already exists'),

$ svn up
At revision 25957.
$ grep S_ALREADY_EXISTS_SMALL frontends/php/api/classes/CTriggerPrototype.php
self::exception(ZBX_API_ERROR_PARAMETERS, S_TRIGGER.' ['.$trigger['description'].'] '.S_ALREADY_EXISTS_SMALL);

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Eduards Samersovs (Inactive) [ 2012 Mar 14 ]

trunk r.26075 version 2.0.0rc2

Generated at Thu Apr 25 04:33:36 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.