Implemented in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-908

(1)
Sorting by graphtype seems working only for graphs on current page.

<Eduard> RESOLVED

<Vedmak> CLOSED

(2) let's enable "Show working time" and "Show triggers" checkboxes by default for new graphs

<Eduard> RESOLVED

<richlv> dev branch rev 26651 - they still seem to be disabled by default

<Eduard> Rich, you test code faster rather than I can commit to in svn ))

<richlv> hey, "resolved" means "committed"
CLOSED

(3) in graph elements, colour codes now use lowercase (uppercase everywhere else and before)
this seems to happen only when adding new items, modifying colour sets them to uppercase again

<Eduard> RESOLVED

<richlv> CLOSED

(4) apparently, new graph elements now use randomised colour.
4.1. this isn't documented anywhere;
4.2. sometimes, this can generate broken colour code, for example, i got : e0498

<Eduard> RESOLVED

<richlv> totally broken colours aren't generated anymore, but some quick colour choosing algorithm description would be still needed.
additional idea... if the generated colour matches "graphcolor", maybe we can skip that and generate next colour ?

<Eduard> RESOLVED

<richlv> i meant some description here that we could later adapt for the zabbix manual

<richlv> i believe https://zabbix.org/wiki/Docs/specs/ZBXNEXT-908 is a good place to describe the algo

<Eduard> RESOLVED

(5) open a graph, save it (without changing anything).
we do update query with all fields in the graphs table. even worse, we delete all graph items, then create them one by one, doing select from ids/update ids for every one of them.
5.1. if possible, we shouldn't do update in this case;
5.2. we shouldn't delete all items & recreate them;
5.3. when creating items (for a new graph, for example), maybe it's possible to increase ids only once and insert all graph items in one go ?

<Eduards> 5.2 - It's hard to simple resolve because in graph item array we can receive NEW items and DELETED items.. so easy way is delete and recreate all ))
We can register new ZBXNEXT but it's is so global and so big work..

<richlv> for anything that won't be fixed here, please, create new issues (although they should be ZBX, not ZBXNEXT )

<richlv> won't be fixed here, split out as ZBX-4861 - CLOSED

(6) currently it is possible to add all kind of mixed items from templates and hosts to a single custom graph.
same limits as before should be returned - only items from a single template or from any number of hosts.

or, to put it otherwise, if the first item to be added to a graph is from from a template, subsequent items can only be added from the same template (group & host dropdowns are disabled and provide a helpful tooltip)
if the first item is added from a host, further item adding should not display templates (and their items) when adding more graph items

<Eduard> RESOLVED

<Vedmak> now i cannot change item, "Critical error. Incorrect value "host_templateid" for "srcfld3" field." in opened popup. And still can create graphs with mixed items.

<Eduard> RESOLVED

<Vedmak> items from mixed sources can be added by updating already added items.

<Eduard> RESOLVED

<Vedmak> it is still possible
Open new graph form, add template item, click save, get error that name is missing for graph, now you can add host items.

Also, when graph created with lld created items, these items cannot be updated error in popup.

<Eduard> RESOLVED

<Vedmak> problem with lld created items still exists.

Also, open new graph form, add template item, click save, get empty name error, remove that item, try to add another, only items from template can be added.

Also, if for axis item we selected host item, we can add template items after that.

<Eduard> RESOLVED

<Vedmak> CLSOED

(7) it is possible to add an item twice. this was not possible in 1.8

also reported as (1) in ZBX-3099

<Eduard> Decided allow adding multiple items, because they can be configured with different functions.

<richlv> CLOSED

(8)
In class.CImg.php for random preloader id better use something like timestamp, rand() function can still get same numbers..

<Eduard> RESOLVED

<Vedmak> CLOSED

(9)
In graph prototypes list, graph names are prepended with discovery rule name and have disabled checkboxes.

<Eduard> RESOLVED

<Vedmak> previous was fixed, but now discovered graphs names are clickable and redirect to "ERROR: No permissions to referred object or it does not exist!"
Also prabably all discovered entities should have space after discovery rule name, items and triggers too.

<Eduard> RESOLVED

<Vedmak> CLOSED

(10)
If i set percentile to incorrect value "abc" for example, in preview i get error.

<Eduard> Decided not to fix, because in Preview we see a warning message.

<Vedmak> CLOSED

(11)
Incorrect item colors can be saved.

<Eduard> RESOLVED

<Vedmak> CLOSED

(12)
Sometimes item cannot be removed from graph, or wrong item is removed.

<Eduard> RESOLVED

<Vedmak> Update still happens to wrong item. open graph, remove one item, try to update last item.

<Eduard> RESOLVED

<Vedmak> CLOSED

(13)
Pie and Exploded graph cannot be saved with more than one "Graph sum" items, however it can be previewed. Probably should display error message in place of preview as with other errors.

<Eduard> RESOLVED

<Vedmak> CLOSED

(14)
I think we should allow removing last item.

<Eduard> RESOLVED (12)

<Vedmak> CLOSED

(15)
1. open new graph prototype form
2. add one normal item
3. try to edit that item
4. prototype item popup is open, normal item popup must be opened

<Eduard> RESOLVED

<Vedmak> CLOSED

(16)
Open pie graph, remove all items, try to save, get error "Incorrect value "" for int field "drawtype". [CGraph.update -> CGraph.updateReal -> DB.insert -> DB.checkValueTypes]"

<Eduard> RESOLVED

<Vedmak> CLOSED

(17) set percentile value to "abc", try to save the graph - percentile is removed.
set percentile to "abc123", try to save the graph - percentile is removed.
set percentile to "123abc123", try to save the graph - percentile is changed to 123.

it should always stay the same, never cleared

<Eduard> RESOLVED

<richlv> for numbers, .00 is added - but let's assume that's ok, CLOSED

(18) maybe we should limit percentile field lengths to 5 characters ? that should allow entering strings like :
100.00
99.957

more precision here might not be necessary. api also should limit percentile values to 5 chars, though

<Eduard> RESOLVED, precision maxlenght set to 6 to support "100.00" value.

<richlv> ah, i can't count
but entering "-444" and trying to save changes it to "-444.00", which is 7 characters
maybe .00 should be added only if the number is considered to be valid ?

<Eduard> Decided not to fix.

<richlv> frontend part closed (fix would complicate things a bit too much and it's a really minor problem), but reviewer should verify the api part as well

<Vedmak> There are no API validation for such things, i think we won't implement it in this issue.. CLOSED

(19) try to save percentile as "abc" - frontend complains that it's not "double". maybe we can change that to "decimal number" ?

<Eduard> RESOLVED

<Vedmak> CLOSED

(20)
Now in page source can be found code like:

<span id="items_29_name" class="link" onclick="PopUp('popup.php?writeonly=1&dstfrm=graphForm&dstfld1=items_52_itemid&dstfld2=items_52_name&dstfld3=items_52_host_templateid'
+ '&srctbl=items'
+ ''
+ (hostTemplateId() > 0 ? '&only_hostid=' + hostTemplateId() : '')
+ '&real_hosts=1'
+ ''
+ '&srcfld1=itemid&srcfld2=name&srcfld3=host_templateid', 800, 600)" name="items[29][name]">
Zabbix server:Free swap space in %
</span>

These concatenations should be removed.

<Eduard> RESOLVED

<Vedmak> CLOSED

(21)
If item has long description, takes 2+ lines, it cannot be dragged/sorted properly.

<Eduard> RESOLVED

<Vedmak> not really fixed, but decided not to fix CLOSED

<richlv> probably worth specifying why this won't be fixed

<Vedmak> probably too much investigation is needed.

<richlv> please, split it out in a separate zbx then

<Vedmak> created ZBX-4875

<richlv> CLOSED

(22)
New icon mapping form is broken.

<Eduard> RESOLVED

<Vedmak> CLOSED

(23)
Seems dragging in web steps form broken too.

<Eduard> RESOLVED

<Vedmak> CLOSED

(24) [usability] opened color picker should be moved a bit right.
Now it closes the color I'm trying to change and other colors (located bottom) -> it's bad, I do not see it and them as well.

<Eduard> RESOLVED

<Vedmak> CLOSED

(25)
Links in maps seems broken.
Add 2 elements, create link between them, this link does not appear in elements form.

<Eduard> RESOLVED

<Vedmak> CLOSED

spec draft in https://zabbix.org/wiki/Docs/specs/ZBXNEXT-908
please, populate it with missing detail

(26)
When we add prototype to graph, it's not prefixed with host name.

<Eduard> RESOLVED

<Vedmak> CLOSED

(27)
When graph created with lld created items, these items cannot be updated error in popup.

<Eduard> RESOLVED

<Vedmak> CLOSED

(28) Now we can edit templated graphs. It shouldn't be so

<Eduard> RESOLVED

<Sasha> REOPENED

• items in graph shouldn't look as a link
• sorting arrows should be disabled
• parent graphs should be displayed like in triggers

<Eduard> RESOLVED

<Sasha> CLOSED

(29) The link from the list of graphs opens a form of a template instead of the list of graphs from a template

<Eduard> RESOLVED
<Sasha> CLOSED