Redesign forms to MVC rails and migrate javascript from Prototype to jQuery (ZBXNEXT-870)

[ZBXNEXT-911] Redesign Configuration->WEB Created: 2011 Aug 24  Updated: 2017 May 31  Resolved: 2011 Nov 03

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 1.9.8 (beta)

Type: Change Request (Sub-task) Priority: Minor
Reporter: Eduards Samersovs (Inactive) Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File reordering_web_steps.png    

 Description   

Edit form and popup form



 Comments   
Comment by Eduards Samersovs (Inactive) [ 2011 Oct 26 ]

Implemented in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-911

Comment by richlv [ 2011 Oct 26 ]

(1) if all browser versions are updated, probably worth adding these

"Lynx/2.8.4rel.1 libwww-FM/2.14"
"Lynx/2.8.7rel.1 libwww-FM/2.14 SSL-MM/1.4.1 OpenSSL/0.9.8r"
"Links (2.3pre1; Linux 2.6.35.10 i686; 225x51)"
"Links (2.2; Linux 2.6.37.6-0.7-desktop i686; 225x51)"
"Mozilla/5.0 (compatible; Konqueror/4.6; Linux) KHTML/4.6.0 (like Gecko)"

<Eduard> RESOLVED

<richlv> i reordered lynx entries to make more recent one come first in rev 22765 - please, review (looks ok otherwise)

<Eduard> OK

<Igor> For me this list seems OK

<richlv> added konqueror 4.7 & reordered "other" entries a bit in rev 22793. if that's ok, could be closed

<Eduard> CLOSED

Comment by richlv [ 2011 Oct 26 ]

(2) (other...) has lost the capability to enter custom useragent string (see how it works in trunk)

also, there's one empty entry in the dropdown just below it, probably should be removed

<Eduard> RESOLVED

<richlv> CLOSED

Comment by richlv [ 2011 Oct 26 ]

(3) step removal still uses old approach of checkboxes & "Delete selected" button - should have "Remove" next to each entry instead

<Eduard> RESOLVED

<Igor> CLOSED

Comment by richlv [ 2011 Oct 26 ]

(4) while checkbox is great, it's label "Status" is quite nondescriptive

<Eduard> What you want to write instead of "Status"?

<Igor> I think that there could be written "Enabled" or "Active".

<richlv> "Enabled" makes most sense, i believe

<Eduard> RESOLVED

<Igor> CLOSED, name of this check box now is "Enabled"

Comment by richlv [ 2011 Oct 26 ]

(5) would it be possible to make authentication change not reload the page ?

<Eduard> Now it is impossible

<richlv> split out as ZBXNEXT-1012 - CLOSED

Comment by Igor Danoshaites (Inactive) [ 2011 Oct 27 ]

(6) Cancel button only refreshes the form, but does not exit from the "Configuration->Web->Scenario"

<Eduard> RESOLVED

<richlv> CLOSED

Comment by Igor Danoshaites (Inactive) [ 2011 Oct 27 ]

(7) Record "Enable selected WEB scenarios?", that appears in the confirmation form after selecting "Activate selected" in the drop-down on the left side of the screen should be changed to "Activate selected WEB scenarios?", as it is stated in the action;

<Eduard> RESOLVED

<Igor> CLOSED

Comment by Igor Danoshaites (Inactive) [ 2011 Oct 28 ]

(8) Please add "Firefox 7.0" to the list of supported agents in the "Configuration->Web->Scenario" report

<Eduard> RESOLVED

<Igor> CLOSED

Comment by richlv [ 2011 Oct 28 ]

(9) enter non-numeric status code :
"Warning. Field [status_codes] is not integer range"

missing trailing dot; giving out plain field name isn't very userfriendly, should print out field label instead

i'm also not sure about that "range" reference, as i believe we can specify status codes like "200,404"

<Eduard> At validation step we don't have mapping to field label, at this time we can't fix this.

<richlv> ok, message content note still stands

<Eduard> added dot at the message end. RESOLVED

<richlv> not good enough
200,404 is not a range. also, a status code like 23232323232 can be saved

<Eduard> common check on integer T_ZBX_INT don't allow to enter something like "200,400" so we use T_ZBX_INT_RANGE - what is list of integers.. And why user can't enter 23232323232 if Hi want?

<richlv> as for the first part, we might have to redo it in a more generic way then. 200,404 is not a range, 200-204,404 is something composed... maybe rephrase it "...not a valid integer range or list" ?
as for 23232323232 - that's not a valid http response code
http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html

maybe we should have a specific validation for http response codes then, if it can't be done in a generic way ?

<Eduard> Any way it's a different problem.. Close this and register new!

<richlv> well, if we redesign, fixing validation should be the same issue like with those length checks
anyway, split out as ZBX-4316 -> CLOSED

Comment by richlv [ 2011 Oct 28 ]

(10) in the list, "Status" column is very confusing, as elsewhere it means enabled/disabled. should be renamed to "Status code" or even "Required status code"

<Igor> Agree, it is better to rename it to "Status codes"

<Eduard> RESOLVED
<Sasha> CLOSED

Comment by Eduards Samersovs (Inactive) [ 2011 Nov 03 ]

trunk revision 22931

Comment by richlv [ 2012 Apr 25 ]

this resulted in a minor regression - extra dot that doesn't match the guidelines. filed as ZBX-4912

Generated at Sat Apr 20 14:23:22 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.