Implemented in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-912

(1) [GUI]
Create slide show with two slides, cannot change their order in chrome.

<Eduard> RESOLVED

<Vedmak> CLOSED

(2) [GUI]
Negative value can be entered for individual slide delay.

<Eduard> RESOLVED

<Vedmak> CLOSED

(3) [GUI]
In slide show config, click on one slide, configuration for that slide is open, if you click on another slide, configuration remains open for previous slide.

<Eduard> RESOLVED

<Vedmak> CLOSED

(4) [GUI]
For ".objectgroup" css class you added margin, but now host interfaces layout is broken, margin is needed only for ".objectgroup.footer" elements.

<Eduard> RESOLVED

<Vedmak> CLOSED

(5) [GUI]
Why for textbox width we sometimes use ZBX_TEXTBOX_STANDARD_SIZE (configuration.host.edit.php) and sometimes ZBX_TEXTAREA_STANDARD_SIZE (administration.authentication.edit.php)?

<Eduard> RESOLVED

<Vedmak> CLOSED

(6) [API] multiple slideshows with identical name can be added

<Eduard> RESOLVED

<Vedmak> CLOSED

(6) [GUI]
In Configuration->Slide shows sorting is not natural, (1, 12, 2)

<Eduard> RESOLVED

<Vedmak> CLOSED

(7) GUI. ZBX-3161 could be considered. I don't know, maybe it can be closed already ?

<Eduard> RESOLVED

<Vedmak> CLOSED

(8) [GUI]
Specs were updated for this issue, this leads to small form redesign and usability improvements: http://zabbix.org/wiki/Docs/specs/ZBXNEXT-912

<Vedmak> probably should discuss if slide update is needed.

<Vedmak> CLOSED, if we will need this, we can add in another ZBNEXT

(9) when adding slides, row highlighting is missing (dev branch rev 24195)

<Eduard> RESOLVED
This issue was resolved multiply for different popups in ZBXNEXT-905, but I merged it in ZBXNEXT-912 for you..

<Vedmak> If you select any checkboxes in popup, in next popup these checkboxes will be preselected.

<Eduard> RESOLVED inside ZBXNEXT-905

<Vedmak> CLOSED

(10) create a slide show with 5 slides, save it. edit it again and remove the first slide :

Undefined index: screenid [include/screens.inc.php:265]
Error in query [INSERT INTO slides (slideid,slideshowid,screenid,step,delay) VALUES (270,14,,3,30)] [You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '3,30)' at line 1]

if you do the same as above but before attempting to save second time drag the last slide to be the first one, there's additional error message :

Undefined offset: 0 [include/screens.inc.php:245]

<Eduard> Please re-test in with the last revision, after screen form redesign I cannot repeat this.

<richlv> still there in dev branch rev 24224. using mysql, if that matters, and php 5.3.5

<Eduard> RESOLVED

<richlv> dev branch rev 24297 - CLOSED

(11) [GUI]
In configuration.httpconf.edit.js.php in function "removeStep" global js variable created. Same for "removeSlide" function.

<Eduard> RESOLVED

<Vedmak> CLOSED

(12) [GUI]
In same function from bug (11), do we really need to remove everything separately, isn't it enough to remove row with all other fields? Same for "removeSlide" function.

<Eduard> It's ok ))

<richlv> for external observers, a bit more verbose statement would inspire more confidence

<Vedmak> we discussed this, it's needed, so CLOSED

(13) [GUI]
Open existing slide show with slides, remove all slides then add some new, sorting does not work for new slides.

<Eduard> RESOLVED

<Vedmak> CLOSED

(14) [GUI]
For default sildes delay something other than placeholder should be used as it's not supported in IE8.

<Eduard> RESOLVED

<Vedmak> For new slides default value is shown as "<number>".

<Eduard> RESOLVED

<Vedmak> CLOSED

(15) dev branch rev 24297.

when saving a slideshow with some default values in opera 11.60, it succeeds, but a red error popup is briefly visible that "the entered text is too large. you used 7 letters, max is 5" (or similar, it only appears very briefly )

this might be an opera specific warning

<Eduard> RESOLVED

<Vedmak> CLOSED

(16) [GUI]
In IE9, when we add new slide delay is empty, no "default" placeholder.

<Eduard> RESOLVED

<Vedmak> CLOSED

(17) [GUI]
In class.cwebcheck.php:677 DBcondition function should be used in sql.

<Eduard> RESOLVED

<Vedmak> CLOSED

(18) [GUI]
Open new slide show form.
Add some screens.
Change new screens ordering.
Save, reopen newly created slideshow, ordering is not saved.

<Eduard> RESOLVED

<Vedmak> ordering seems to be correct, but delay saved for screen as they were before reordering..

<Eduard> RESOLVED

<Vedmak> CLOSED

trunk revision 24420

(20) [GUI] SQL errors in Monitoring->Screens->Slide Shows screen
pg_query(): Query failed: ERROR: syntax error at end of input LINE 1: ...p,MAX(s.step) AS max_step FROM slides s WHERE s.slideshowid= ^ [include/db.inc.php:430]
...

<Eduard> RESOLVED in svn://svn.zabbix.com/branches/dev/ZBXNEXT-912

<Vedmak> CLOSED

trunk revision 24797

Sorry, I do not consider (7) as resolved. See ZBX-3161 for more details.

this resulted in a minor regression : ZBX-7739