Redesign forms to MVC rails and migrate javascript from Prototype to jQuery
(ZBXNEXT-870)
[ZBXNEXT-914] Redesign Administration->DM Created: 2011 Aug 24 Updated: 2017 May 31 Resolved: 2012 Apr 12 |
|
Status: | Closed |
Project: | ZABBIX FEATURE REQUESTS |
Component/s: | Frontend (F) |
Affects Version/s: | None |
Fix Version/s: | 2.0.0 |
Type: | Change Request (Sub-task) | Priority: | Minor |
Reporter: | Eduards Samersovs (Inactive) | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 0 |
Labels: | distributed | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified |
Attachments: | administration-authentication.png dm-node.png | ||||||||||||
Issue Links: |
|
Description |
Edit form |
Comments |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 13 ] |
(1) When creating a new node, the "Type" select doesn't have the "Master" option. <Eduard> RESOLVED <pavels> Now the "Master node" select is missing for child nodes. <Eduard> Because you don't have master yet.. <pavels> But we should be able to add child nodes using the local node as the master. <Eduard> RESOLVED <pavels> CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 13 ] |
(2) When trying to create a node with the node id "0", the error message just says "ERROR: Cannot add node". I think we should add the "Warning. Incorrect value for field "ID"." message. <Eduard> RESOLVED <pavels> CLOSED. |
Comment by Alexei Vladishev [ 2012 Mar 13 ] |
(3) Unable to link 1500 or more hosts in Proxy management form. <Eduard> RESOLVED sorting, but actually can't repeat bug. <pavels> This seems to be caused by the max_input_vars parameter or it's Suhosin analog. It will be fixed as a separate issue. CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 13 ] |
(4) When I'm trying to edit a created node, the form looks weird. Note the error message, the duplicating "Name" fields and the "Master node" text. See https://support.zabbix.com/secure/attachment/18327/dm-node.png <Eduard> RESOLVED <pavels> We shouldn't be able to change the type of the node after it's created. <Eduard> RESOLVED <pavels> CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 13 ] |
(5) When I'm trying to create a passive proxy with a DNS interface without a DNS address, an error occurs: Undefined index: 10173 [api/classes/CHostInterface.php:537] Note, that the last message is missing the proxy name. <Eduard> RESOLVED <pavels> The same error message for hosts says "Interface with IP "127.0.0.1" cannot have empty DNS name while having "Use DNS" property on "%HOSTNAME%". Let's make it consistent. <Eduard> RESOLVED <pavels> CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 13 ] |
(6) When trying creating a proxy without a "Proxy name" the error message reads "Warning. Incorrect value for field "host".". It should be "Warning. Incorrect value for field "proxy name".". <Eduard> RESOLVED <pavels> CLOSED. <pavels> REOPENED: same thing when trying to create a proxy with an existing name: "Host "1" already exists." <Eduard> RESOLVED <pavels> CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 13 ] |
(7) History seems to be broken. <Eduard> RESOLVED <pavels> History is missing from Administration - General. This seems to have been broken in the trunk sometime earlier. <Eduard> RESOLVED <pavels> History should have a link to a specific configuration page, not just a single "Configuration of Zabbix" link. <Eduard> RESOLVED <pavels> I've changed the title of General / Other to "Other configuration parameters", it's more correct. CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 13 ] |
(8) The layout of administration/authentication and some other pages is broken in firefox https://support.zabbix.com/secure/attachment/18328/administration-authentication.png <Eduard> RESOLVED <pavels> CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 13 ] |
(9) The navigation menu is missing from the graph, application and screen forms. <Eduard> Applications, Screens RESOLVED. For Graphs I will do it in <pavels> CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 13 ] |
(10) It would be really great, if your current location in the navigation menu would be either highlighted, or displayed as text instead of link. <Eduard> RESOLVED (current location will be without link) <pavels> Doesn't work in the list of discovery rules and item prototype form. <Eduard> RESOLVED, same as (14) <pavels> Noup, still doesn't work. <Eduard> RESOLVED <pavels> Still doesn't work in the item prototype form, and in the discrovery form items are highlighted instead of discoveries. <Eduard> RESOLVED <pavels> CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 13 ] |
(11) Since you've also fixed page headers, there's one small issue. The header on monitoring/events reads "HISTORY OF EVENTS ON 13 Mar 2012 15:48:42" while on the trigger status page - "STATUS OF TRIGGERS [13 Mar 2012 15:51:23]". It should be unified. <Eduard> RESOLVED <pavels> CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 14 ] |
(12) A couple of code issues: 1. CDiscoveryRule already has a "selectPrototypes" option, there's no need for "selectItems"; <Eduard> RESOLVED <pavels> CLOSED. |
Comment by richlv [ 2012 Mar 14 ] |
apparently, the work is happening in svn://svn.zabbix.com/branches/dev/ZBXNEXT-914 |
Comment by richlv [ 2012 Mar 14 ] |
(13) apparently the trailing dot is missing for "Incorrect interface port "10051eee" provided" <Eduard> RESOLVED <pavels> CLOSED. |
Comment by Oleksii Zagorskyi [ 2012 Mar 15 ] |
(14) dev branch r26073 tested. When I click and open some discovery rule properties then I cannot click to a link "Item prototypes (2)" because it's not a hyper-link but just simple text. <Eduard> RESOLVED <zalex> Successful tested, CLOSED. |
Comment by Oleksii Zagorskyi [ 2012 Mar 15 ] |
(15) according our discussion related to <Eduard> RESOLVED |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 16 ] |
(16) The node select is missing from the top of the page. <Eduard> RESOLVED <pavels> CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 16 ] |
(17) A "S_STATUS_OF_ZABBIX" string appears in the history. <Eduard> Seems it was saved in your profile, please re-test it now.. <pavels> Yep, it's ok now. CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 19 ] |
(18) Please review my changes in r26175. <Eduard> Ok, CLOSED |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 20 ] |
TESTED. |
Comment by Eduards Samersovs (Inactive) [ 2012 Mar 20 ] |
trunk r.26226 version 2.0.0.rc2 |
Comment by richlv [ 2012 Apr 10 ] |
interestingly, this has broken map editing in opera (11.61, linux) adding a new element now fails. error console just reports : "Syntax error at line 1 in event handler: expected expression, got <end of file>" this was broken in revision r26226 <Eduard> RESOLVED in <richlv> problem gone in the dev branch, rev 26799; leaving as is for code review |