[ZBX-7109] Very slow processing of low-level discovered triggers Created: 2013 Oct 07 Updated: 2017 May 30 Resolved: 2014 Feb 02 |
|
Status: | Closed |
Project: | ZABBIX BUGS AND ISSUES |
Component/s: | Server (S) |
Affects Version/s: | 2.0.9, 2.1.7 |
Fix Version/s: | 2.0.11rc1, 2.2.2rc1, 2.3.0 |
Type: | Incident report | Priority: | Major |
Reporter: | Alexey Pustovalov | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 0 |
Labels: | performance | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified |
Issue Links: |
|
Comments |
Comment by Alexander Vladishev [ 2013 Nov 07 ] | ||||||||||||||||||||||||||||||||
(1) Separated lld source code into several files asaveljevs Looks good. Before closing, please take a look at r40087. sasha Thanks! CLOSED Available in branches/2.0 r40088. | ||||||||||||||||||||||||||||||||
Comment by Alexander Vladishev [ 2013 Nov 08 ] | ||||||||||||||||||||||||||||||||
Related issue: | ||||||||||||||||||||||||||||||||
Comment by Alexander Vladishev [ 2013 Dec 16 ] | ||||||||||||||||||||||||||||||||
(2) moved filtering of lld rows to the one place
wiper svn://svn.zabbix.com/branches/dev/ZBX-7109 r41040 tested CLOSED Available in pre-2.0.11 r41051, pre-2.2.2 r41053 and pre-2.3.0 (trunk) r41054. | ||||||||||||||||||||||||||||||||
Comment by richlv [ 2014 Jan 07 ] | ||||||||||||||||||||||||||||||||
(3) documented perf improvement in : RESOLVED, please review sasha added more details, please review. <richlv> clarified a bit more, please, review sasha Thank you! CLOSED | ||||||||||||||||||||||||||||||||
Comment by richlv [ 2014 Jan 07 ] | ||||||||||||||||||||||||||||||||
this also fixed | ||||||||||||||||||||||||||||||||
Comment by Alexander Vladishev [ 2014 Jan 17 ] | ||||||||||||||||||||||||||||||||
Whats new:
Tests:One discovery rule with 2 item prototypes and 2 trigger prototypes. Received 2048 new records. 2.0.11
2.0.11 with the fix
| ||||||||||||||||||||||||||||||||
Comment by Alexander Vladishev [ 2014 Jan 18 ] | ||||||||||||||||||||||||||||||||
Fixed in the development branch svn://svn.zabbix.com/branches/dev/ZBX-7109 | ||||||||||||||||||||||||||||||||
Comment by Aleksandrs Saveljevs [ 2014 Jan 24 ] | ||||||||||||||||||||||||||||||||
(4) Parameter "parent_triggerid" in function DBlld_trigger_make() is unused. Also, this function has "DB" prefix, but it does not do anything with the database. sasha RESOLVED in r41871 asaveljevs CLOSED | ||||||||||||||||||||||||||||||||
Comment by Aleksandrs Saveljevs [ 2014 Jan 24 ] | ||||||||||||||||||||||||||||||||
(5) Please take a look at minor fixes during code review in r41875. sasha Thanks! CLOSED | ||||||||||||||||||||||||||||||||
Comment by Alexander Vladishev [ 2014 Jan 27 ] | ||||||||||||||||||||||||||||||||
(6) [I] trunk: The fields trigger_discovery.name and trigger_discovery.triggerdiscoveryid should be removed. sasha RESOLVED in r41936 sasha Already tested by asaveljevs CLOSED | ||||||||||||||||||||||||||||||||
Comment by Alexander Vladishev [ 2014 Jan 27 ] | ||||||||||||||||||||||||||||||||
Fixed in pre-2.0.11 r41917. | ||||||||||||||||||||||||||||||||
Comment by Alexander Vladishev [ 2014 Jan 28 ] | ||||||||||||||||||||||||||||||||
2.2 and trunk are fixed in the development branches:
asaveljevs In 2.2 branch, I have fixed a bunch of typos in r41984. Please take a look. asaveljevs In trunk branch, database index after upgrade from 2.2 has a different name compared to that from a fresh database. REOPENED. | ||||||||||||||||||||||||||||||||
Comment by yuusou [ 2014 Jan 29 ] | ||||||||||||||||||||||||||||||||
Will this patch re-create triggers and graphs that were deleted in previous versions? | ||||||||||||||||||||||||||||||||
Comment by Alexander Vladishev [ 2014 Jan 29 ] | ||||||||||||||||||||||||||||||||
yuusou, We can't create such patch. | ||||||||||||||||||||||||||||||||
Comment by yuusou [ 2014 Jan 29 ] | ||||||||||||||||||||||||||||||||
Alexander, If that's the case, then this rewrite doesn't fix | ||||||||||||||||||||||||||||||||
Comment by richlv [ 2014 Jan 29 ] | ||||||||||||||||||||||||||||||||
it does fix that - triggers won't get deleted in such case anymore. | ||||||||||||||||||||||||||||||||
Comment by Alexander Vladishev [ 2014 Jan 30 ] | ||||||||||||||||||||||||||||||||
Fixed in pre-2.2.2 r41993 and pre-2.3.0 r42023. | ||||||||||||||||||||||||||||||||
Comment by richlv [ 2014 Feb 02 ] | ||||||||||||||||||||||||||||||||
subissues (3) and (6) not closed, reopening | ||||||||||||||||||||||||||||||||
Comment by richlv [ 2014 Feb 02 ] | ||||||||||||||||||||||||||||||||
(7) i also moved trunk entry "[ sasha Thanks, it will be better! CLOSED |