[ZBX-8118] Don't allow to change image type for images used in maps Created: 2014 Apr 17 Updated: 2017 May 30 Resolved: 2015 Jan 13 |
|
Status: | Closed |
Project: | ZABBIX BUGS AND ISSUES |
Component/s: | Frontend (F) |
Affects Version/s: | None |
Fix Version/s: | 2.3.0 |
Type: | Incident report | Priority: | Minor |
Reporter: | Oleg Egorov (Inactive) | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 0 |
Labels: | images, maps | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified |
Issue Links: |
|
Description |
In Administration->Images change image type to background. It possible save without any error message. But should be displayed anything like Because map with this image in the future will be not possible to save. |
Comments |
Comment by Pavels Jelisejevs (Inactive) [ 2014 Apr 24 ] |
To avoid such problems we've decided to remove the "Type" parameter from the image configuration form. Please make the following changes:
|
Comment by richlv [ 2014 Apr 24 ] |
hmm. in the past, accidentally uploading a background image as an icon could be corrected just by changing the type. with the suggested changes it would have to be deleted and re-uploaded. as we are changing button label[s], i'd suggest to change them to "Upload icon" and "Upload background image" instead - having 'create' there is somewhat confusing Eduards REOPEN Discussed with Sasha and Pavel, let's call button "Create icon" and "Create background" kristsk RESOLVED in r44903. Chagned translatable strings:
<richlv> in this context "create" is highly confusing and users have repeatedly asked why the button is labelled like that. please provide the reasoning to use "create" here. Eduards CLOSED, "Create" is the name of business process, "upload" is method how we implement this functionality. |
Comment by Krists Krigers (Inactive) [ 2014 Apr 24 ] |
Resolved in r44746, r44747, branch svn://svn.zabbix.com/branches/dev/ZBX-8118. |
Comment by Krists Krigers (Inactive) [ 2014 Apr 24 ] |
(1) Translatable string changes:
Removed strings:
kristsk Updated translatable strings list. RESOLVED. iivs CLOSED. |
Comment by Eduards Samersovs (Inactive) [ 2014 Apr 24 ] |
(2) adm.images.php:148 This code can be written in 1 line: if($imageType == IMAGE_TYPE_ICON) { $submitCaption = _('Upload icon'); } else { $submitCaption = _('Upload background image'); } $submitCaption = ($imageType == IMAGE_TYPE_ICON) ? _('Upload icon') : _('Upload background image'); After this changes variable $submitCaption will be used once so also can be optimized.. |
Comment by Eduards Samersovs (Inactive) [ 2014 Apr 24 ] |
(3) administration.general.image.edit.php:46 $imageTab->addTab('imageTab', ($this->data['imagetype'] == IMAGE_TYPE_ICON ? _('Icon') : _('Background')), $imageFormList); must be $imageTab->addTab('imageTab', ($this->data['imagetype'] == IMAGE_TYPE_ICON) ? _('Icon') : _('Background'), $imageFormList); |
Comment by Eduards Samersovs (Inactive) [ 2014 Apr 24 ] |
(4) Incorrect string, please changes: Eduards CLOSED |
Comment by Eduards Samersovs (Inactive) [ 2014 Apr 24 ] |
(5) Undefined index in Image API request for query: ,"id":0,"auth":"303e0a760eabd231c43eaf916be1ee37"} Notice: Undefined index: name in /home/zabbix/www/testing- kristsk RESOLVED in r44793. Eduards REOPEN, Empty name if we try to update unexisting image: "Cannot update \"imagetype\" for image \"\"." {"jsonrpc":"2.0","method":"image.update","params": {"imageid":9999999999999999,"imagetype":1},"id":0,"auth":"303e0a760eabd231c43eaf916be1ee37"} Also:
kristsk RESOLVED in r44900. Eduards REOPEN little formatting improvements:
kristsk RESOLVED in r44968.
Eduards CLOSED |
Comment by Eduards Samersovs (Inactive) [ 2014 Apr 30 ] |
(6) Please resolve conflicts after merging with trunk kristsk RESOLVED in r45009. Eduards CLOSED |
Comment by Eduards Samersovs (Inactive) [ 2014 Apr 30 ] |
Tested |
Comment by Krists Krigers (Inactive) [ 2014 Apr 30 ] |
Merged and committed to trunk in r45022. |
Comment by Pavels Jelisejevs (Inactive) [ 2014 May 06 ] |
(7) This needs to be documented in the API changelog. kristsk RESOLVED. jelisejev Great, thanks! CLOSED. |
Comment by Martins Valkovskis [ 2014 May 07 ] |
(8) Documented in general documentation as well:
jelisejev Thanks! CLOSED. |
Comment by richlv [ 2014 Nov 01 ] |
subissues still open : |