[ZBX-9889] Duplicated nanosecond value for vmware eventlog items Created: 2015 Sep 18 Updated: 2017 Jul 10 Resolved: 2015 Oct 15 |
|
Status: | Closed |
Project: | ZABBIX BUGS AND ISSUES |
Component/s: | Proxy (P), Server (S) |
Affects Version/s: | 2.4.6 |
Fix Version/s: | 2.4.7rc1, 3.0.0alpha3 |
Type: | Incident report | Priority: | Blocker |
Reporter: | Alexey Pustovalov | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 0 |
Labels: | logmonitoring, nanoseconds, vmware | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified |
Issue Links: |
|
Description |
Currently we have a check to avoid duplicated nanoseconds for a few values of a Vmware eventlog item in case of same timestamp. But in case of log items ns could be filled with duplicated data before the check will be performed: static void DCcheck_ns(zbx_timespec_t *ts) { if (ts->ns >= 0) return; .... |
Comments |
Comment by dimir [ 2015 Oct 13 ] |
Fixed in svn://svn.zabbix.com/branches/dev/ZBX-9889 . |
Comment by Andris Zeila [ 2015 Oct 14 ] |
(1) If the timespec seconds part gets incremented when item is added to history then the item will be requeued with the updated rather than original value. It would be better to use local variable for timespec adjustments in dc_add_history() function. Actually the zbx_timespec_t *ts parameter should be const, though not sure if it's worth changing in all related places. <dimir> Good point, added those "const" modifiers. RESOLVED in r56137 wiper CLOSED |
Comment by Andris Zeila [ 2015 Oct 14 ] |
Successfully tested |
Comment by dimir [ 2015 Oct 14 ] |
Fixed in pre-2.4.7 r56146, pre-3.0.0alpha3 (trunk) r56147. |
Comment by Oleksii Zagorskyi [ 2015 Oct 16 ] |
Confirmed by Andris that it happened only for vmware log items. |
Comment by Oleksii Zagorskyi [ 2015 Oct 16 ] |
Dimir, maybe ChangeLog worth to be update too? |
Comment by dimir [ 2015 Oct 16 ] |
zalex_ua, you are absolutely right. Fixed in 2.4 and trunk ChangeLogs. |
Comment by Kim Jongkwon [ 2017 Jul 10 ] |
Almost the same issue Fixed in Zabbix 2.2.17. More info at |