[ZBXNEXT-511] items should have a description field Created: 2010 Sep 16  Updated: 2011 Dec 22  Resolved: 2011 Apr 05

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F), Server (S)
Affects Version/s: None
Fix Version/s: 2.0.0

Type: New Feature Request Priority: Major
Reporter: Aleksandrs Saveljevs Assignee: Aleksandrs Saveljevs
Resolution: Fixed Votes: 0
Labels: None

Attachments: PNG File bug_14.png     PNG File bug_15.png     PNG File bug_2.png     PNG File bug_3.png     PNG File bug_4.png     PNG File bug_5.png    

 Description   

Similarly to triggers that have comments and maintenances that have descriptions, items should have descriptions too.



 Comments   
Comment by richlv [ 2010 Sep 16 ]

partially duplicates ZBXNEXT-337 and ZBX-2755

Comment by Alexey Fukalov [ 2010 Sep 22 ]

fixed

Comment by Aleksandrs Saveljevs [ 2010 Sep 23 ]

Available in development branch svn://svn.zabbix.com/branches/dev/zbxnext-511-item-description.

Comment by Aleksandrs Saveljevs [ 2010 Sep 29 ]

Some of the changes to be made to database schema:

  • items.description => items.name
  • items.description_details => items.description (also blob => text)
  • triggers.description => triggers.name
  • triggers.comments => triggers.description (also blob => text)
  • maintenances.description: blob => text
  • media_type.description => media_type.name

Will have to check whether other tables should be updated as well.

Comment by richlv [ 2010 Sep 29 ]

item multiplier/formula is very confusing, but it should also be taken in context of xml export, where field names sometimes can be matching, and sometimes - not

Comment by Konstantin Buravcov (Inactive) [ 2010 Oct 19 ]

DB patches and schema committed to svn://svn.zabbix.com/branches/dev/zbxnext-511-item-description

Comment by richlv [ 2011 Jan 25 ]

looks like this was never finished/merged ?

Comment by Aleksandrs Saveljevs [ 2011 Jan 25 ]

It will have to be done once again.

Comment by Alexander Vladishev [ 2011 Feb 24 ]

All right, we have to finish this task.

Here is list of things to be done:

  • the branch should probably be recreated, it is just too old
  • items.description => items.name, items.description (text)
  • add support of {ITEM.DESCRIPTION<1-9>}
  • GUI form for items should be changed (Description -> Name)
  • GUI item mass updated should be changed as well (add support for the new Description field)

Re-naming of other table fields is out of scope.

Comment by richlv [ 2011 Mar 22 ]

(1) something to pay attention to : when attempting to create a discovery rule w/o name error message says :

Incorrect value for field "description".

the field is named "Name"

<Vedmak> FIXED
<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 30 ]

(2) Undefined index when creating an item. The error message about item key is not helpful either. See bug_2.png.

<Vedmak> FIXED
<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 30 ]

(3) The description text area does not look good in mass update. See bug_3.png.

<Vedmak> FIXED
<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 30 ]

(4) When saving an item prototype, description is saved as its name. See bug_4.png.

<Vedmak> FIXED
<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 30 ]

(5) On the trigger prototype page, it shows discovery rule's description instead on name. See bug_5.png.

<Vedmak> FIXED
<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 30 ]

(6) Saving a trigger without name complains about incorrect value for field "description".

<Vedmak> FIXED
<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 30 ]

Documented

{ITEM.DESCRIPTION}

and

{ITEM.KEY}

macros at http://www.zabbix.com/documentation/2.0/manual/appendix/macros/supported_by_location.

Comment by Aleksandrs Saveljevs [ 2011 Mar 31 ]

(7) In trigger list, triggers that are created by low-level discovery from trigger prototypes have links to discovery rules. These links are descriptions of discovery rules, not their names.

<Vedmak> FIXED
<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 31 ]

(8) In "Latest data" filter it says: "Show items with description like".

<Vedmak> FIXED
<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 31 ]

(9) I propose we replace 'description_expanded' with 'name_expanded'. Similarly, variable $item_description should be renamed to $item_name. Also, $max_desc_len should be $max_name_len.

<Vedmak> FIXED
<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 31 ]

(10) In item list, filtering by name yields "Undefined index: filter_name[/home/asaveljevs/zabbix-svn/branches/dev/ZBXNEXT-511/frontends/php/items.php:860]".

<Vedmak> FIXED
<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 31 ]

(11) Different issue, but configuration of discovered triggers can be accessed through "Triggers top 100" report.

<Vedmak> it's not connected to this issue
<asaveljevs> Moved to ZBX-3674. CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 31 ]

(12) It is possible to create a trigger that references an item that does not exist.

<Vedmak> FIXED

<asaveljevs> Perfect. But since we started messing with invalid trigger expressions, could you please take a look at why we have an undefined index when switching trigger expression to "

{Zabbix server: .last(0)}

=0" (note the space in place of item key).

<Vedmak> FIXED

<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 31 ]

(13) It is possible to create a trigger that references a discovery rule. If we then click on that discovery rule in the trigger expression, we get no permissions error.

<Vedmak> it's not connected to this issue
<asaveljevs> Moved to ZBX-3674. CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 31 ]

(14) Undefined index when accessing "Configuration" -> "Actions". See bug_14.png.

<asaveljevs> Moved to ZBX-3678. CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 31 ]

(15) The popup in bar reports does not close itself when clicking on an item. See bug_15.png.

<asaveljevs> Disregard that. This problem occurs in 1.8, too.
<asaveljevs> Moved to ZBX-3676. CLOSED

Comment by Alexander Vladishev [ 2011 Apr 01 ]

Server side tested.

Comment by Aleksandrs Saveljevs [ 2011 Apr 05 ]

(16) [API] Should rename "description" to "name" on http://www.zabbix.com/documentation/2.0/manual/appendix/api/item/get. The examples with "description" are probably still valid, but they are not as natural anymore.

<Vedmak> changed, but as mentioned, it was valid

<asaveljevs> I have also renamed "description" to "name" in "sortfield" row. If you like it, please close this comment and merge the branch.

<Vedmak> Like it, CLOSED

Comment by Alexey Fukalov [ 2011 Apr 05 ]

trunk 18905

Generated at Mon Nov 19 15:20:48 EET 2018 using JIRA 7.3.9#73021-sha1:26adfd3d76803e1a04219c5cd05b58dbafff0dbf.