Redesign forms to MVC rails and migrate javascript from Prototype to jQuery
(ZBXNEXT-870)
[ZBXNEXT-903] Redesign Configuration->Items Created: 2011 Aug 24 Updated: 2017 May 31 Resolved: 2012 Mar 22 |
|
Status: | Closed |
Project: | ZABBIX FEATURE REQUESTS |
Component/s: | Frontend (F) |
Affects Version/s: | None |
Fix Version/s: | 2.0.0 |
Type: | Change Request (Sub-task) | Priority: | Blocker |
Reporter: | Eduards Samersovs (Inactive) | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 0 |
Labels: | itemconfigform | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified |
Attachments: | item-interface.png | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Issue Links: |
|
Description |
Specification http://zabbix.org/wiki/Docs/specs/ZBXNEXT-903 |
Comments |
Comment by richlv [ 2011 Sep 02 ] |
if this refers to item config form, would be nice to take |
Comment by richlv [ 2012 Jan 20 ] |
(1) redesign seems to be fairly nice, but there seems to be no design document at all. current implementation should be documented on the specification wiki and basically describe how it works now (field order, value mappings and applications being sorted alphabetically etc etc) <alexei> We need design doc! I have so many ideas for this form. <richlv> just to note down that current spec is seriously lacking - doesn't list field ordering, field visibility depending on contents of other fields etc <richlv> sorry, this doesn't work. i don't know how should i put it. THIS DOESN'T WORK. |
Comment by dimir [ 2012 Jan 25 ] |
(2) When doing "mass update" of SNMPv3 (authPriv) item to change it to SNMPv2c the "SNMPv3 auth passphrase" and "SNMPv3 priv passphrase" fields are left in the form after update. The bug is not reproduced with direct item edit, only when doing mass update. FYI in 1.8 it's reproduced in both cases. <dimir> CLOSED. Moved to a separate issue |
Comment by richlv [ 2012 Jan 26 ] |
item filter issues are also being looked at. as such, the following would be nice to consider : |
Comment by Eduards Samersovs (Inactive) [ 2012 Jan 28 ] |
Implemented in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-903 |
Comment by Oleksii Zagorskyi [ 2012 Jan 29 ] |
(3) [Usability] I need to scroll page vertically to save an item changes -> unexpected. <Eduard> Have decided not create new Tab, because all fields are important.. So it's ok. <alexei> Yes, it is ok. We decided not to introduce any new tabs for now. CLOSED |
Comment by Oleksii Zagorskyi [ 2012 Jan 29 ] |
At least the <Eduard> RESOLVED |
Comment by Alexei Vladishev [ 2012 Jan 30 ] |
(4) Connect as an user having read-write permission to a host Configuration->Hosts->Items (click on a host having templated items), click on a template item. See errors below the form: reset() expects parameter 1 to be array, null given [include/forms.inc.php:951] <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexei Vladishev [ 2012 Jan 30 ] |
(5) Configuration->Templates, click on template items You will see list of items of a host, not template. It seems host selection is remembered in item filter. <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexei Vladishev [ 2012 Jan 30 ] |
(6) Configuration->Hosts->Items Click on a template Template_Linux in item name "Template_Linux:Buffers memory". You are supposed to see list of Template_Linux items, however host items are displayed. Probably related to (5). <Eduard> (5) RESOLVE this issue <Vedmak> CLOSED |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Jan 31 ] |
(7) If the host doesn't have any available interfaces for the selected item type, the interface select element breaks (tested in Firefox). https://support.zabbix.com/secure/attachment/17947/item-interface.png <Eduard> RESOLVED )) <pavels> CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Jan 31 ] |
(8) when selecting some SNMP or IPMI type, the select key button becomes disabled, but the input itself is still editable. <Eduard> It's ok, for SNMP and IMPI user type key by hands.. <pavels> Oh, OK. CLOSED. |
Comment by Alexei Vladishev [ 2012 Jan 31 ] |
(9) Configuration->Hosts->Items Look at the debug information. The amount of API calls, permission checks and unnecessarily data exchange kills performance. It has to be fixed. <Eduard> RESOLVED <Vedmak> There is still quite a lot sqls.. ~130 more than in trunk. Maybe we should discuss that problem together. <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Jan 31 ] |
(10) It would be nice to vertically align the custom multiplier checkbox, in firefox it's shifted to the top. <Eduard> RESOLVED, still not in css at this time.. <pavels> Ok, CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Jan 31 ] |
(11) Maybe we should group the input fields into several logical groups (e.g. type specific fields, intervals and history, applications) and add a margin between them? The form would be more usable, and it will be clearer, how the fields depend on each other. <pavels> After some discussion with Eduards and Sasha we've decided not to do that now. CLOSED. |
Comment by Alexei Vladishev [ 2012 Jan 31 ] |
(12) Applications not sorted in the list of item prototypes "CPU, Availability", must be "Availability, CPU". <Eduard> RESOLVED <Vedmak> Sorting is not natural: 1, 12, 2. <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Jan 31 ] |
(13) In configurations.item.edit.php: <Eduard> RESOLVED <pavels> I don't think that using large ternary operators in function calls is a good idea. I mean blocks like: $itemFormList->addRow(_('Host'), array( |
Comment by Alexei Vladishev [ 2012 Jan 31 ] |
(14) Please fix <Eduard> RESOLVED also in Hosts and Host inventories. <alexei> please make 'Filter' preferred action, i.e. mark it with yellow border <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexei Vladishev [ 2012 Feb 01 ] |
(15) Only interfaces matching item type must be displayed. If no interfaces found then empty (or ' <Eduard> RESOLVED <alexei> it is not correct, the logic must be as follows: case ITEM_TYPE_ZABBIX: <Eduard> RESOLVED" <pavels> I think the message should read "No interfaceS found". Plus, when we try to submit a form with that message, it still submits some interface ID and the error message reads "Item uses incorrect interface type" instead of "No interface for item". <Eduard> After discussion with Pavels we decided not to do this. CLOSED <pavels> Wait, we've decided no to change the "No interface found" message, the part about the error remains. REOPENED. <Eduard> RESOLVED <pavels> CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Feb 03 ] |
(16) Regarding itemTypeInterface() in functions.js. It's not a good idea to duplicate this logic on the client side. I think we should pass the interface mapping rules as an associative array from the PHP side. <Eduard> RESOLVED, impl. without any array.. <Vedmak> I'm not sure what it was about initially, but "insert_javascript_itemTypeInterface" must be removed from CItemGeneral class And i think Pavel's idea about implementation was that we should not change more than one function/method if we add new interface. <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Feb 03 ] |
(17) In the item mass update form the "show value mappings" link should not be displayed if the value "show value" checkbox is unchecked. <Eduard> RESOLVED <pavels> The "show value mapping" link is broken (leads to config.php) <Eduard> RESOLVED <pavels> CLOSED. |
Comment by Alexei Vladishev [ 2012 Feb 03 ] |
(18) Please fix <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexander Vladishev [ 2012 Feb 03 ] |
(19) "Log time format" field should be visible only with "Type of information" = "Log" <Eduard> RESOLVED <Sasha> CLOSED |
Comment by Alexander Vladishev [ 2012 Feb 03 ] |
(20) "SNMP OID", "SNMP community" and "Port" fields should not be visible with "Type of information" = "Character" <Eduard> RESOLVED <Sasha> CLOSED |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Feb 03 ] |
(21) in the "copy to" form in FireFox there is no margin between the "target" label and the lower border. <Eduard> RESOLVED <pavels> CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Feb 03 ] |
(22) The "Group" drop down is not working in firefox in the "copy to" form. <Eduard> RESOLVED <pavels> CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Feb 03 ] |
(23) In configuration.item.edit.js the two jQuery.ready blocks should be united in one. <Eduard> RESOLVED <pavels> CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Feb 03 ] |
(24) In configuration.item.edit.php the numerous zbx_subarray_push should be somehow restructured to be more maintainable. <Eduard> After discussion with Pavels we decided optimize it not in this time. CLOSED |
Comment by Alexey Fukalov [ 2012 Feb 03 ] |
(25) [GUI] <Eduard> RESOLVED <pavels> CLOSED. |
Comment by Alexey Fukalov [ 2012 Feb 03 ] |
(26) [GUI] <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Feb 03 ] |
(27) [GUI] <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Feb 03 ] |
(28) [GUI] Also that button has "hand" cursor even if disabled. <Eduard> Cursor RESOLVED <Vedmak> "Select" button should be disabled also for "Zabbix trapper", "External check", "Database monitor", "SSH agent", "TELENT agent", "JMX agent", "Calculated" item types. <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Feb 03 ] |
(29) [GUI] <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Feb 03 ] |
(30) [GUI] <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Feb 03 ] |
(31) [GUI] <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Feb 03 ] |
(32) [GUI] <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Feb 03 ] |
(33) [GUI] <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexander Vladishev [ 2012 Feb 03 ] |
(34) [GUI] flexible intervals in "Mass update" and "Item" forms should be unified. <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Feb 06 ] |
(35) [GUI] <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Feb 06 ] |
(36) [GUI] <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by richlv [ 2012 Feb 07 ] |
(37) add an application to an item that has a name : try to use it in item subfilter : [02/07/2012 12:59:18 AM] JavaScript - items.php?sid=df9ac3e9bc8c64ca&form_refresh=4&filter_groupid=0&filter_hostid=0&filter_group=&filter_hostname=2&filter_application=&filter_name=&filter_key=&filter_type=-1&filter_delay=&filter_value_type=-1&filter_history=&filter_trends=&filter_status=-1&filter_with_triggers=-1&filter_templated_items=-1&subfilter_apps%5BU%23%25%40%26*%23%24%40%26*%23%24%26%24%40%232%5D=U%23%25%40%26*%23%24%40%26*%23%24%26%24%40%232 <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Feb 07 ] |
(38) [GUI] <Eduard> RESOLVED <Vedmak> Previous fixed, but i found one more case. When select "Type of information" numeric unsigned and "Data type" boolean, multiplier fields are hidden, then change <Vedmak> CLOSED |
Comment by Eduards Samersovs (Inactive) [ 2012 Feb 08 ] |
trunk r.25256 version pre-1.9.10 |
Comment by richlv [ 2012 Mar 21 ] |
(39) the merge has resurrected hosts_mon.php file, which was deleted in rev 24986 <Eduard> Out of |