Redesign forms to MVC rails and migrate javascript from Prototype to jQuery
(ZBXNEXT-870)
[ZBXNEXT-908] Redesign Configuration->Graphs Created: 2011 Aug 24 Updated: 2017 May 31 Resolved: 2012 Apr 18 |
|
Status: | Closed |
Project: | ZABBIX FEATURE REQUESTS |
Component/s: | Frontend (F) |
Affects Version/s: | None |
Fix Version/s: | 2.0.0 |
Type: | Change Request (Sub-task) | Priority: | Minor |
Reporter: | Eduards Samersovs (Inactive) | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 0 |
Labels: | graphs | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified |
Issue Links: |
|
Description |
Edit form; item ordering must be changed to the draggable one as elsewhere; also see (5) in |
Comments |
Comment by Eduards Samersovs (Inactive) [ 2012 Apr 04 ] |
Implemented in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-908 |
Comment by Alexey Fukalov [ 2012 Apr 04 ] |
(1) <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by richlv [ 2012 Apr 04 ] |
(2) let's enable "Show working time" and "Show triggers" checkboxes by default for new graphs <Eduard> RESOLVED <richlv> dev branch rev 26651 - they still seem to be disabled by default <Eduard> Rich, you test code faster rather than I can commit to in svn )) <richlv> hey, "resolved" means "committed" |
Comment by richlv [ 2012 Apr 04 ] |
(3) in graph elements, colour codes now use lowercase (uppercase everywhere else and before) <Eduard> RESOLVED <richlv> CLOSED |
Comment by richlv [ 2012 Apr 04 ] |
(4) apparently, new graph elements now use randomised colour. <Eduard> RESOLVED <richlv> totally broken colours aren't generated anymore, but some quick colour choosing algorithm description would be still needed. <Eduard> RESOLVED <richlv> i meant some description here that we could later adapt for the zabbix manual <richlv> i believe https://zabbix.org/wiki/Docs/specs/ZBXNEXT-908 is a good place to describe the algo <Eduard> RESOLVED |
Comment by richlv [ 2012 Apr 04 ] |
(5) open a graph, save it (without changing anything). <Eduards> 5.2 - It's hard to simple resolve because in graph item array we can receive NEW items and DELETED items.. so easy way is delete and recreate all )) <richlv> for anything that won't be fixed here, please, create new issues (although they should be ZBX, not ZBXNEXT ) <richlv> won't be fixed here, split out as |
Comment by richlv [ 2012 Apr 04 ] |
(6) currently it is possible to add all kind of mixed items from templates and hosts to a single custom graph. or, to put it otherwise, if the first item to be added to a graph is from from a template, subsequent items can only be added from the same template (group & host dropdowns are disabled and provide a helpful tooltip) <Eduard> RESOLVED <Vedmak> now i cannot change item, "Critical error. Incorrect value "host_templateid" for "srcfld3" field." in opened popup. And still can create graphs with mixed items. <Eduard> RESOLVED <Vedmak> items from mixed sources can be added by updating already added items. <Eduard> RESOLVED <Vedmak> it is still possible Also, when graph created with lld created items, these items cannot be updated error in popup. <Eduard> RESOLVED <Vedmak> problem with lld created items still exists. Also, open new graph form, add template item, click save, get empty name error, remove that item, try to add another, only items from template can be added. Also, if for axis item we selected host item, we can add template items after that. <Eduard> RESOLVED <Vedmak> CLSOED |
Comment by richlv [ 2012 Apr 05 ] |
(7) it is possible to add an item twice. this was not possible in 1.8 also reported as (1) in <Eduard> Decided allow adding multiple items, because they can be configured with different functions. <richlv> CLOSED |
Comment by Alexey Fukalov [ 2012 Apr 05 ] |
(8) <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Apr 05 ] |
(9) <Eduard> RESOLVED <Vedmak> previous was fixed, but now discovered graphs names are clickable and redirect to "ERROR: No permissions to referred object or it does not exist!" <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Apr 05 ] |
(10) <Eduard> Decided not to fix, because in Preview we see a warning message. <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Apr 05 ] |
(11) <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Apr 10 ] |
(12) <Eduard> RESOLVED <Vedmak> Update still happens to wrong item. open graph, remove one item, try to update last item. <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Apr 10 ] |
(13) <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Apr 10 ] |
(14) <Eduard> RESOLVED (12) <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Apr 10 ] |
(15) <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Apr 10 ] |
(16) <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by richlv [ 2012 Apr 11 ] |
(17) set percentile value to "abc", try to save the graph - percentile is removed. it should always stay the same, never cleared <Eduard> RESOLVED <richlv> for numbers, .00 is added - but let's assume that's ok, CLOSED |
Comment by richlv [ 2012 Apr 11 ] |
(18) maybe we should limit percentile field lengths to 5 characters ? that should allow entering strings like : more precision here might not be necessary. api also should limit percentile values to 5 chars, though <Eduard> RESOLVED, precision maxlenght set to 6 to support "100.00" value. <richlv> ah, i can't count <Eduard> Decided not to fix. <richlv> frontend part closed (fix would complicate things a bit too much and it's a really minor problem), but reviewer should verify the api part as well <Vedmak> There are no API validation for such things, i think we won't implement it in this issue.. CLOSED |
Comment by richlv [ 2012 Apr 11 ] |
(19) try to save percentile as "abc" - frontend complains that it's not "double". maybe we can change that to "decimal number" ? <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Apr 11 ] |
(20) <span id="items_29_name" class="link" onclick="PopUp('popup.php?writeonly=1&dstfrm=graphForm&dstfld1=items_52_itemid&dstfld2=items_52_name&dstfld3=items_52_host_templateid' These concatenations should be removed. <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Apr 12 ] |
(21) <Eduard> RESOLVED <Vedmak> not really fixed, but decided not to fix CLOSED <richlv> probably worth specifying why this won't be fixed <Vedmak> probably too much investigation is needed. <richlv> please, split it out in a separate zbx then <Vedmak> created <richlv> CLOSED |
Comment by Alexey Fukalov [ 2012 Apr 12 ] |
(22) <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Apr 12 ] |
(23) <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Oleksii Zagorskyi [ 2012 Apr 13 ] |
(24) [usability] opened color picker should be moved a bit right. <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Apr 13 ] |
(25) <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by richlv [ 2012 Apr 13 ] |
spec draft in https://zabbix.org/wiki/Docs/specs/ZBXNEXT-908 |
Comment by Alexey Fukalov [ 2012 Apr 13 ] |
(26) <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexey Fukalov [ 2012 Apr 13 ] |
(27) <Eduard> RESOLVED <Vedmak> CLOSED |
Comment by Alexander Vladishev [ 2012 Apr 16 ] |
(28) Now we can edit templated graphs. It shouldn't be so <Eduard> RESOLVED <Sasha> REOPENED
<Eduard> RESOLVED <Sasha> CLOSED |
Comment by Alexander Vladishev [ 2012 Apr 16 ] |
(29) The link from the list of graphs opens a form of a template instead of the list of graphs from a template <Eduard> RESOLVED |